From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 4BECC3858D28; Sun, 30 Jan 2022 08:32:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4BECC3858D28 Received: by mail-wm1-x32c.google.com with SMTP id v123so7982476wme.2; Sun, 30 Jan 2022 00:32:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e6kIJ7m3Xxx7LX9GuK8PTICqAVOv+xGsrzo3ifxAB+k=; b=wivnGC9xMeUexU6gjaipoZ4zA+i00e16L9Tg5TlXulTGqBLypXlQkCPqlmBAV8I9GW EdCZUO5099AEDanrqgb1vwLADLJa+VCDq0gEUCkVr6cQHQ1X+9+q2T+S48nUTCWLlfSp YcnZgpYybxEFk+Y+tW2HVMT457YWk8fCwbFj4YxG/x2oY/IrzjqfPqiLx9usG1YG+Lof mOBveUvktrzWDoctC6bXzucA4qi6djHzA2qkD7Dxrt+AtX+NKfUYo58fhmtweFLAIutn HCy3Ni3CV6sh0Pnj7w9O3jvTLpgukp80t3irnctAtpMUTtlzK8AJQB7gCQQULiFlqgF1 WPew== X-Gm-Message-State: AOAM532u+TnM+ZOOCuiANGMjVaeyNOQcOd5N8tZ1sNkP1UiDB9/83+w6 ytk60Gt2cpa2fg2TbcXsOzskIZNMaP5nOUGCg7g= X-Google-Smtp-Source: ABdhPJyHxQvnn9n2pzipXDwWeyNRTq378fUbhnZ4n4G3G7qOg5CzfaYmYFRSmQOAYlZVKgG+pWeiXarKuAnUinM8cM0= X-Received: by 2002:a7b:c929:: with SMTP id h9mr21897281wml.176.1643531542890; Sun, 30 Jan 2022 00:32:22 -0800 (PST) MIME-Version: 1.0 References: <20220130013541.A127620418@pchp3.se.axis.com> In-Reply-To: <20220130013541.A127620418@pchp3.se.axis.com> From: Jonathan Wakely Date: Sun, 30 Jan 2022 08:32:08 +0000 Message-ID: Subject: Re: [PATCH] libstdc++ testsuite: Increase lwg3464.cc timeout factors to 20 To: Hans-Peter Nilsson Cc: gcc-patches , "libstdc++" X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jan 2022 08:32:25 -0000 On Sun, 30 Jan 2022, 01:37 Hans-Peter Nilsson via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > These tests have always been failing for my cris-elf > autotester running a simulator; they take about 20 minutes > each, compared to the timeout of 720 seconds, doubled > because they timed out in another simulator setup. > > They are the *only* libstdc++ tests that timeout for my > setup so I thought this'd be best fixed in the testsuite > rather than a local timeout setting (in e.g. the baseboard > file). And, better make it an increase that counts. Or, > maybe they're actually needlessly excessive? They are testing behaviour when a counter overflows, so they have to read that many bytes. Making them do less work would not test that condition. But there is nothing target-specific in that code, so it should be fine to disable them for simulators. They're already disabled for LP64 because overflowing the 64-bit counter would take forever. I think that would be better than letting them potentially run for 40 minutes even on real hardware.