From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id C0BE73858D20; Thu, 28 Sep 2023 07:23:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0BE73858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-523100882f2so14960532a12.2; Thu, 28 Sep 2023 00:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695885808; x=1696490608; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wXqkjnODGzxnSZsmcco8Cvu7kwp+Bs4UThSR7A8k2Rg=; b=jGwMoIzMsB2fXnZ0FaXMkjRafJtrTQz89NN9cn1gFBvstAVumiJzNv+QGKrAlFogen d6KtoEHRHnv5ytiqTMcEKWqQS7dUhp8KSCrVk677OoHYD6Mxq06RmeSgTI5ODZuJZ/kv n27GDBY5jo3UaKZlCu07+A9re5IGMG4PifEKHc/J9Oy98eWRNI5OTRsCMfbIC1Fqdalu xh9i3wgXGRGSAzssgCxOpZgMJnnOkWc4+r/6/WccnSySSNI3kbB5kWCXy+i4hP3ttl47 t4/frF29hVc46WaBgwiuzU/fXp4kcRGH9yVcn2FFj46MOee6IgaPlucPY6NnxNDxQQLK /Gxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695885808; x=1696490608; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wXqkjnODGzxnSZsmcco8Cvu7kwp+Bs4UThSR7A8k2Rg=; b=T31iw7qWofvT7Tw288VNtOMqcZttyAmZ5H47UN4QbacLRcY1REtq8wlEiTI6KOA1Yo ohpi4r0s9LgT5HqBKZCAbh2UKSyrv55EapBX/FF6vw5MchmNJs7ke6y2Lw3xdq+MEbgp KN6DMl0Dqoqdb1tIooZG2LFDercjwemZA50gr4wzeIR1KWhzrP9GCZDt2c52pU/V5+7j brcsklVFasm+y1nMHTV80YQWFpkSEqxO/075tvagpl6cDI2z6/0lcwTiD+UupupFbX3I OlDBPxm2KkhZcV1JjqsMF7P1pSeFDcAGicFLH91VBci454nrSt2atm/fSIP7nVq9osBv o6Tg== X-Gm-Message-State: AOJu0YwM30coi9eP5dq2rR3hsf91DsVrO0n5KVIwNQegbh12ssrl+Rr2 Wdp7ImJkrQBVumabg+IzhSglj/Gz/8Gb5Cb/hKM= X-Google-Smtp-Source: AGHT+IFeqgvDiGWu2zAg+QLmSu+9/dDStX0bRCu+Vz+o+m815OAmDS5d3sCxEYP0MD43UqeZ8U0fbdcKgaJF+I/37JE= X-Received: by 2002:a17:907:75c6:b0:9a2:143e:a071 with SMTP id jl6-20020a17090775c600b009a2143ea071mr468523ejc.17.1695885808012; Thu, 28 Sep 2023 00:23:28 -0700 (PDT) MIME-Version: 1.0 References: <20221222233804.772229-1-jwakely@redhat.com> <878r8r4og4.fsf@tromey.com> <874jjf4jia.fsf@tromey.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 28 Sep 2023 08:23:16 +0100 Message-ID: Subject: Re: [committed] libstdc++: Add GDB printers for types To: Tom Tromey Cc: Jonathan Wakely , Jonathan Wakely via Gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="0000000000002a92cb0606662ff0" X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002a92cb0606662ff0 Content-Type: text/plain; charset="UTF-8" On Wed, 27 Sept 2023 at 20:57, Jonathan Wakely wrote: > > > > On Wed, 27 Sept 2023, 18:25 Tom Tromey via Libstdc++, < libstdc++@gcc.gnu.org> wrote: >> >> >> I have fixes for most of the issues that are worth fixing (I didn't >> >> bother with line lengths -- FWIW in gdb we just run 'black' and don't >> >> worry about these details), >> >> Jonathan> I used autopep8 and committed the result as >> Jonathan> e08559271b2d797f658579ac8610dbf5e58bcfd8 so the line lengths >> Jonathan> should be OK now. >> >> Yeah, my patches are on top of that, but flake8 still complains, and I >> still see lines > 79 characters. However maybe flake8 isn't the checker >> you want to use, or maybe you have something set up for a different line >> length? > > > I don't think I have anything set up for python formatting at all, I just committed whatever autopep8 did with its default settings. It looks like adding the -a flag would have made more changes. > > If that's suboptimal, we can consider other tools, if they're reliable and easy to run. The changes made by black seem reasonable, though I prefer it with -S to disable string-normalization. It also needs an option to use 79 as the maximum line length. --0000000000002a92cb0606662ff0--