From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id A2F7A3858D1E; Fri, 8 Sep 2023 10:10:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2F7A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-99bed101b70so233131066b.3; Fri, 08 Sep 2023 03:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694167816; x=1694772616; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=H5ja5IuCbq6BTpbPrs6pLKQc6cyhbnh0d3GdOUCpnNE=; b=JTUPQwF8qoi/pRWvEkgGsP2SwQ3u4Qqz+KNpjjL9ZnmLp1C6yJ0hjf4MbdMNma5jvY E2u28o03u9MTF9nvkYmO/eD2CkufwVykPfF5k+Y3/afh6aQ+NVA6TZ9jNvXutQ8txGjI ZiYlQnQlYB3pA7V7PkD+HYNKa37LW58SYHGsomRzm9uMvbKVB8Vs1PZ6MCXQIsPL+mCi glmWMEM5ebkff2JyszkpBk6QVyKnGiYNYW1QPzGNOWe9Sp4/f77k9wNP0BfW9zhFD/1n 5g39T/j24aB7PDb4di9Q27ba0rnKVxlK9D2hv1glGAGCRIStTPZKOuHq7CWW8kcoFmGh A+gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694167816; x=1694772616; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H5ja5IuCbq6BTpbPrs6pLKQc6cyhbnh0d3GdOUCpnNE=; b=jnLsRbXWMzvd7PlGcL5iZh70MyciXz/OhSvoi3pn3xilftjeWJTz+9ARPA+7S8V15w l3XeL1FJnzCsCCrzpTv84WrIS/8+QRIoNN0gp2+K0OyJRS0pT/ojSQV1h+CeRtwtSTPz fdCYxRmJIa1kPbPZQzEzqGn7viNPTEEdRopmcowTGgk371lInGBEQQNdynRWRuPtpX5L 3yjIDHgei9DSsTEZv3bfTqPAPj1WU9lY9Ok/JBST5M6uQGhve38Y/bBSWUUd73+q3HMK W7wcfI41J609mBhFWx/+ldcaYpAOQwgajaiNPS/gaxY03E9LmK+evJv57+M9hfM/wsId oD6A== X-Gm-Message-State: AOJu0YwNjfiwf+tuk5Fz2x9KJSZ8LCN0t37iwoS56pTq81NWuBZhTtnF TWgqQJ0ZpvXU833GS54udp+xEyAw5jUSATqy/AM= X-Google-Smtp-Source: AGHT+IFdVCDcNcwsWtyFHjYL0LtFAMGONVE6C7HVH1ARneTQ9JiL3Fu7v1+wOJ5OnI97DyVM869DNb4dxK3m33VXGsU= X-Received: by 2002:a17:906:76c8:b0:9a5:7e64:5c55 with SMTP id q8-20020a17090676c800b009a57e645c55mr1508761ejn.22.1694167816001; Fri, 08 Sep 2023 03:10:16 -0700 (PDT) MIME-Version: 1.0 References: <0784b8c8a8149b672e01ad9da657f6cbf9df7227.camel@espressif.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 8 Sep 2023 11:10:03 +0100 Message-ID: Subject: Re: [PATCH] libbacktrace: Fix unconditional -Werror To: Alexey Lapshin Cc: "libstdc++" , Jonathan Wakely , Hans-Peter Nilsson , gcc-patches Content-Type: multipart/alternative; boundary="000000000000dcdfbc0604d62e1a" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000dcdfbc0604d62e1a Content-Type: text/plain; charset="UTF-8" The patch looks good, thanks. I noticed the unconditional -Werror the other day when testing a build on avr. N.B. All patches should go to gcc-patches (as well as a more specific list like libstdc++ when appropriate). OK for trunk On Fri, 8 Sept 2023, 10:49 Alexey Lapshin via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > Added to CC: jwakely@redhat.com, hp@axis.com > > > On Fri, 2023-09-08 at 12:39 +0400, Alexey Lapshin wrote: > > -Werror flag should depend on --enable-werror configure option > > > > --- > > libstdc++-v3/src/libbacktrace/Makefile.am | 2 +- > > libstdc++-v3/src/libbacktrace/Makefile.in | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.am > b/libstdc++-v3/src/libbacktrace/Makefile.am > > index 9abf9dd64a1..27c1ea570e0 100644 > > --- a/libstdc++-v3/src/libbacktrace/Makefile.am > > +++ b/libstdc++-v3/src/libbacktrace/Makefile.am > > @@ -45,7 +45,7 @@ libstdc___libbacktrace_la_CPPFLAGS = \ > > $(BACKTRACE_CPPFLAGS) > > > > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \ > > - -Wcast-qual -Werror > > + -Wcast-qual > > C_WARN_FLAGS = $(WARN_FLAGS) -Wstrict-prototypes -Wmissing-prototypes > -Wold-style-definition -Wno-unused-but-set-variable > > CXX_WARN_FLAGS = $(WARN_FLAGS) -Wno-unused-parameter > > AM_CFLAGS = $(C_WARN_FLAGS) > > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.in > b/libstdc++-v3/src/libbacktrace/Makefile.in > > index 1c1242d8827..b78c8443751 100644 > > --- a/libstdc++-v3/src/libbacktrace/Makefile.in > > +++ b/libstdc++-v3/src/libbacktrace/Makefile.in > > @@ -368,7 +368,7 @@ VTV_CXXFLAGS = @VTV_CXXFLAGS@ > > VTV_CXXLINKFLAGS = @VTV_CXXLINKFLAGS@ > > VTV_PCH_CXXFLAGS = @VTV_PCH_CXXFLAGS@ > > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \ > > - -Wcast-qual -Werror > > + -Wcast-qual > > > > XMLCATALOG = @XMLCATALOG@ > > XMLLINT = @XMLLINT@ > > --000000000000dcdfbc0604d62e1a--