From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id B876D3858C74; Wed, 23 Aug 2023 07:02:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B876D3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-99bc9e3cbf1so1085527066b.0; Wed, 23 Aug 2023 00:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692774163; x=1693378963; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4xJnzjHkonLkrbGWU97u4IdzqSSX1d3RsbPVCEjmJUk=; b=dt2jZmvt9gRTQiKOxgq0YgVeV6igGb4+lwB0rzNkcuMeulftu3yV0tbjSHlWzWjB06 DnK8syG1qv8y/X//1qhnqoufW1uPLflPhfFyIq1eN69vnaxstZxZfVoWSSr7mxe4wHcX Scsjd/1XKOfhdNFa3VyOBdWjMMRwQPAKzwE0h2RU/nwqnR7qgLZJmvbuvqZTiDHBRrbA fW9/o6hD0U1cssPI/uGqXBjTpL7Q15nscO9LrrPQUAEGjQINZUgIsV1V6ZCUlIUk07pq xoRLVnI6r4VN9/waG/OiaFwDBaqucxVNRgjn2mB/drI7DaRfAL8aY4liz0aorZlcZF5m jPuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692774163; x=1693378963; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4xJnzjHkonLkrbGWU97u4IdzqSSX1d3RsbPVCEjmJUk=; b=doV1gupRac/K4SiiCb9ZCoFu/vUALD0GroeGCePvxtW1UkWnLgEPzBYFtAMYiv9FKy +10L4vZv5e0MAeKKW1E7tn+35GNWagzJ4Y0lG/g0V/+CwhkpC3jt184IU5YIvvuhx5bp 3ZOWH1tLR7qiAT6DEthlQPpRmkeqijvVmoZLMTGPalaokdmdl13efksnPLGC7a+0qlU4 9ip8bb0XneSTByWlAdxv2O3INE0+zjBEfRG4ClrtZclIwXylg9zF1tmVpTKEBkLHVUJa dqOH+VNb++YrxdL76v5vw47dzs5CiQzVd3Xr7Q9Dkc4CKzZEXWJOjCUJM9AJR9YsKQcQ fCyQ== X-Gm-Message-State: AOJu0YypV6B+E8KcI3d6EEio7b7T659slyTJn6/j92iYdUcCanRyUBRO inrEFwVPbSnKfqEDzdgMGZcNzM8502RP6+Lapp8= X-Google-Smtp-Source: AGHT+IHe3IgA+f3hcUAM3tijmEjmrr+niyW3N4k8Z8QIpyvUUoMq3/XrC+SwlcOL3Oekqw0SXa2nNEX5q0RNwhqo5QA= X-Received: by 2002:a17:907:9717:b0:99d:ae3:80a3 with SMTP id jg23-20020a170907971700b0099d0ae380a3mr13396780ejc.0.1692774162868; Wed, 23 Aug 2023 00:02:42 -0700 (PDT) MIME-Version: 1.0 References: <20230807211335.701619-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 23 Aug 2023 08:02:31 +0100 Message-ID: Subject: Re: [committed] i386: Fix grammar typo in diagnostic To: Hongtao Liu Cc: Marek Polacek , Jonathan Wakely , "libstdc++" , gcc-patches Content-Type: multipart/alternative; boundary="000000000000a9aee1060391b25e" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000a9aee1060391b25e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 23 Aug 2023, 06:15 Hongtao Liu via Libstdc++, wrote: > On Wed, Aug 23, 2023 at 7:28=E2=80=AFAM Hongtao Liu = wrote: > > > > On Tue, Aug 8, 2023 at 5:22=E2=80=AFAM Marek Polacek via Libstdc++ > > wrote: > > > > > > On Mon, Aug 07, 2023 at 10:12:35PM +0100, Jonathan Wakely via > Gcc-patches wrote: > > > > Committed as obvious. > > > > > > > > Less obvious (to me) is whether it's correct to say "GCC V13" here.= I > > > > don't think we refer to a version that way anywhere else, do we? > > > > > > > > Would "since GCC 13.1.0" be better? > > > > > > x86_field_alignment uses > > > > > > inform (input_location, "the alignment of %<_Atomic %T%> > " > > > "fields changed in %{GCC 11.1%}= ", > > > > > > so maybe the below should use %{GCC 13.1%}. "GCC V13" looks unusual > > > to me. > > %{GCC 13.1%} sounds reasonable. > looks like %{ can't be using in const char*, so use % instead. > > How about: > > Author: liuhongt > Date: Wed Aug 23 07:31:13 2023 +0800 > > Adjust GCC V13 to GCC 13.1 in diagnotic. > > gcc/ChangeLog: > > * config/i386/i386.cc (ix86_invalid_conversion): Adjust GCC > V13 to GCC 13.1. > > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > index e7822ef6500..88d9d7d537f 100644 > --- a/gcc/config/i386/i386.cc > +++ b/gcc/config/i386/i386.cc > @@ -22899,7 +22899,7 @@ ix86_invalid_conversion (const_tree fromtype, > const_tree totype) > || (TYPE_MODE (totype) =3D=3D BFmode > && TYPE_MODE (fromtype) =3D=3D HImode)) > warning (0, "%<__bfloat16%> is redefined from typedef % " > - "to real %<__bf16%> since GCC V13, be careful of " > + "to real %<__bf16%> since %, be careful of " > "implicit conversion between %<__bf16%> and %; " > "an explicit bitcast may be needed here"); > } > Why does it need to be quoted? What's wrong with just saying GCC 13.1 without the %< decoration? > > > > > > > -- >8 -- > > > > > > > > gcc/ChangeLog: > > > > > > > > * config/i386/i386.cc (ix86_invalid_conversion): Fix grammar. > > > > --- > > > > gcc/config/i386/i386.cc | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > > > > index 50860050049..5d57726e22c 100644 > > > > --- a/gcc/config/i386/i386.cc > > > > +++ b/gcc/config/i386/i386.cc > > > > @@ -22890,7 +22890,7 @@ ix86_invalid_conversion (const_tree > fromtype, const_tree totype) > > > > warning (0, "%<__bfloat16%> is redefined from typedef > % " > > > > "to real %<__bf16%> since GCC V13, be careful of " > > > > "implicit conversion between %<__bf16%> and > %; " > > > > - "a explicit bitcast may be needed here"); > > > > + "an explicit bitcast may be needed here"); > > > > } > > > > > > > > /* Conversion allowed. */ > > > > -- > > > > 2.41.0 > > > > > > > > > > Marek > > > > > > > > > -- > > BR, > > Hongtao > > > > -- > BR, > Hongtao > --000000000000a9aee1060391b25e--