From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 76BBE3858C52; Thu, 28 Sep 2023 18:49:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 76BBE3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9b2cee55056so39866266b.3; Thu, 28 Sep 2023 11:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695926958; x=1696531758; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qMNLh0RE0LXH0W4MUstpMXomjebFkSRbe2AtMIHf6no=; b=KOW+hBK9Wf2DDtGD4uQezqAuq4lXm/pKREkpSQi2d/0rac4s9/p4fqUgKpgqpVhbQk +Bed0Mj7G5IRCBe+phND97UKGkAP0k6/8sCXRrPViRgl7ot33lt49N195BRduEwygF79 vbT/qzVpKf0pCedAhGk7Cp5JLa+3YwPFE4aEE0itqzl4COqkQLO4LmKSD7vXc2uSgw1r o7J3s2vr5885QI6aXVkb95af4W8ZLlP3roRXTdSRgro6B2D4Xoo9047Vdxb01W5fr3dq KV4VUpd9r6vcgfMp+Fl55T5RC6eqd1m/QIPbHNGove4GWVW1onUDihqlpr1KoI2z47vw gBFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695926958; x=1696531758; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qMNLh0RE0LXH0W4MUstpMXomjebFkSRbe2AtMIHf6no=; b=L9pGxV0pfXXo+O2y/eYZuEKPhl5+Ewbbdhtl1SyRyn0Y02mKFzE8IZl8uUGKpxdxDv vZp2dSbxTt5tcI00qduZkrUdJQivlLkk9ZlG2HW4XF3o69v4xYSvkn+mrGFQfEUyN7Ls hantgZIqOi3ynOKv2t86p9Sbul1LtxUt3rh+9uLgSqfDhUmdgVNiDYysAFGE+xP6kydO +5lbZiOaQziBLUwNeHWAU++PhA09xyhokou91P5plNfeC4+oWjSdSkkPv3Q3gCjrtFZZ JKK5VJGjKY0V2BIDg7vSrWTeyffRzvR7NZNsVy9ALmDg48olQi9lYMbSEYncrnhBB85p HrdQ== X-Gm-Message-State: AOJu0YzgsCjRpVxAmoa/KMQFFFgpEinEa7q2xn1qoP3TE4VdoZHJLBOv W/qdlFKpHrLZjtcziN66q9mv/Ev5dgKK8KazVzOlE4m7 X-Google-Smtp-Source: AGHT+IHOVPTIv26JyWkbqeosssUmqLeTZ5IrAz1wo2vEOgLZPSfkVUzkD1BAKiRnQ25yi3YtlFVthLrBrQA6gcb2VGU= X-Received: by 2002:a17:906:292a:b0:9a1:d29c:6a9d with SMTP id v10-20020a170906292a00b009a1d29c6a9dmr2053283ejd.46.1695926957933; Thu, 28 Sep 2023 11:49:17 -0700 (PDT) MIME-Version: 1.0 References: <20230928174630.4004388-1-tromey@adacore.com> <20230928174630.4004388-2-tromey@adacore.com> In-Reply-To: <20230928174630.4004388-2-tromey@adacore.com> From: Jonathan Wakely Date: Thu, 28 Sep 2023 19:49:06 +0100 Message-ID: Subject: Re: [PATCH 1/7] libstdc++: Show full Python stack on error To: Tom Tromey Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000e48a8006066fc360" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000e48a8006066fc360 Content-Type: text/plain; charset="UTF-8" On Thu, 28 Sept 2023, 18:48 Tom Tromey via Libstdc++, wrote: > This changes the libstdc++ test suite to arrange for gdb to show the > full Python stack if any sort of Python exception occurs. This makes > debugging the printers a little simpler. > Oh I wish I'd known about this sooner. OK for trunk, thanks. > libstdc++-v3/ChangeLog: > > * testsuite/lib/gdb-test.exp (gdb-test): Enable Python > stack traces from gdb. > --- > libstdc++-v3/testsuite/lib/gdb-test.exp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libstdc++-v3/testsuite/lib/gdb-test.exp > b/libstdc++-v3/testsuite/lib/gdb-test.exp > index d8e572ef7b3..af7d970d388 100644 > --- a/libstdc++-v3/testsuite/lib/gdb-test.exp > +++ b/libstdc++-v3/testsuite/lib/gdb-test.exp > @@ -141,6 +141,8 @@ proc gdb-test { marker {selector {}} {load_xmethods 0} > } { > puts $fd "set auto-load no" > # Now that we've disabled auto-load, it's safe to set the target file > puts $fd "file ./$output_file" > + # See the full backtrace of any failures. > + puts $fd "set python print-stack full" > # Load & register *our* copy of the pretty-printers > puts $fd "source $printer_code" > puts $fd "python register_libstdcxx_printers(None)" > -- > 2.40.1 > > --000000000000e48a8006066fc360--