From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id B0CAD3857B93; Wed, 25 May 2022 15:18:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0CAD3857B93 Received: by mail-wm1-x332.google.com with SMTP id c9-20020a7bc009000000b0039750ec5774so3532880wmb.5; Wed, 25 May 2022 08:18:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JMbnAm63pk4YKZAIXwqFAAt9E0FNoQvg1s6G6x9B3OM=; b=lpT78J8Nw9PLdJuhuIoTvGcLbp13cJoEqVvnidYpsLEDlSbtWKhaaS4X4Vj5rCSLjS KGCW7w4iJH7IFuatY2/2s9uEXqAVzkMpZZ5a2nfPEroAjffGdIx6RE6T5cF35A8LjBz2 SAF0A5Do0yGlPAt20+0jmjQ7f96mpnJVrhGkrPDQp1yuQLc6cJEFGnf55v35+dO04Auq 4H7HXQ41eU5RZ1qN2jKHb9e2sgTOfSnKHv7L2VVxCm2zAOhPSPP7kp63mNrFlMz6Qpnx FdvvUVkKBGsYpIazJTGWr31At8XrzG2iP9GJKur4vp0flUzRhBr0wD64iGu4cToyyWj/ SMGg== X-Gm-Message-State: AOAM533JZvLbEiyO2EhUUcpMd3gfFQVlZ158UPEUjdvpE1Y1w1BmsGsj diIgJSiOuZUWLK/mw5w3EkbOhImH9oeDYzW3530= X-Google-Smtp-Source: ABdhPJzKVUu//S0WI3KqPkBQtl0MK+ZE3a4yR5LzpZ91skNS11KF9u5R2kAt2aoBdwDdCkwbt9j4BqJycr8VmjvZHSw= X-Received: by 2002:a05:600c:4e4c:b0:397:6ec6:d226 with SMTP id e12-20020a05600c4e4c00b003976ec6d226mr2897063wmq.85.1653491893687; Wed, 25 May 2022 08:18:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 25 May 2022 16:18:02 +0100 Message-ID: Subject: Re: [PATCH v3] libstdc++: fix pointer type exception catch [PR105387] To: Jakob Hasse Cc: "libstdc++@gcc.gnu.org" , gcc-patches , Anton Maklakov , Ivan Grokhotkov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 15:18:17 -0000 On Wed, 25 May 2022 at 03:30, Jakob Hasse via Libstdc++ wrote: > > Hello, > > two weeks ago I submitted the second version of the patch PR105387 for th= e bug 105387. Now I added a pointer-to-member exception test just to make s= ure that it doesn't break in case RTTI is enabled. The test is disabled if = RTTI is disabled. I didn't receive any feedback so far regarding the second= version of the patch. Is there any issue preventing acceptance? Just a lack of time to review it properly. It's on my list. > > I ran the conformance tests on libstdc++v3 by running > make -j 18 check RUNTESTFLAGS=3Dconformance.exp > > Results for the current version (only difference is the added pointer-to-= member test): > > Without RTTI before applying patch: > =3D=3D=3D libstdc++ Summary =3D=3D=3D > > # of expected passes 14560 > # of unexpected failures 5 > # of expected failures 95 > # of unsupported tests 702 > > Without RTTI after applying patch: > =3D=3D=3D libstdc++ Summary =3D=3D=3D > > # of expected passes 14562 > # of unexpected failures 5 > # of expected failures 95 > # of unsupported tests 703 > > With RTTI before applying patch: > =3D=3D=3D libstdc++ Summary =3D=3D=3D > > # of expected passes 14598 > # of unexpected failures 2 > # of expected failures 95 > # of unsupported tests 683 > > With RTTI after applying patch: > =3D=3D=3D libstdc++ Summary =3D=3D=3D > > # of expected passes 14602 > # of unexpected failures 2 > # of expected failures 95 > # of unsupported tests 683 > > Given that the pointer-to-member test is disabled when RTTI is disabled, = the results look logical to me. >