From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id CC3473858403; Mon, 12 Sep 2022 18:30:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC3473858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x531.google.com with SMTP id e18so14118264edj.3; Mon, 12 Sep 2022 11:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=I654f288aRc7psW1RwlxRoBBJxpGBulBkr2JzhXbO0A=; b=XfKc9h17R+YykF5G/WFlBkNNpfbvjnSNBkj8x2Z7KqO+iL9dqCfJSQv81Uf3MiJcbN 6RTDtIWEr6YjmG/HCtazoRwaPV0gczPVHXsBBkfmI1Rs+WklawM/qy2eRchuemmnSCG5 BG/4r454INPwu2ZK3bSyQgbMmN9S8eUhtBAJY9nBp5C/CFGpcGGttQJ4rcd7AENe+DtI 5C8W67ESxgHOAQsfCY34HskxW0vli1AhCWjAkqUmzShdrFxONlpvT+Ep52oc73ASWWTs UdI+Y6AJb6MnSvWdrwEauU7aCjsk3Y7kcm7E9uHvnO0GF+TFWgHeTB4I5rfhRCGx6sz+ jPNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=I654f288aRc7psW1RwlxRoBBJxpGBulBkr2JzhXbO0A=; b=YqtjLw1kCblvPc/f+O9UGDqdNRfsFUPBcuFkOGsAUTKnqw2mCJFt41MlwvH3oZcfax QNhb5q908jykZT8KknLxpdXR7/uH+Hd83XjzemYbFRvDLy1O/spV1ozTcVmrqh3WqxWI mSaX9Ls5MLpkAF67hNtJDbY2CS/CGP9bd7zbvqS0Iw7unB49O+kWOtwe2mgDi10af8mK t/bTxa11oxaeoLGn1ZpeOc1WxYmRVzGu4MkEkaW+8csHhIOQBiGw9AhugGpLa6Cn3boR YllfI1fyR0kp6eRlZVztJ8iXfKqpHKX+crFSFFh/Vzg76eMyxd00QrUKwNp7Sm2fjwfB 4EIQ== X-Gm-Message-State: ACgBeo1nrkbjDowKqrHK60WhOGNWvTPJ48OO7tVQfRk9hD+WTXjg5sMT ixSPyU6lPycrF43ec27GhTTQISGhaC3ZEhlT9do= X-Google-Smtp-Source: AA6agR6VmjkC5LX0a449QiCQPP+7s2NMJgLYcYSuQEHGuA0VBP/8uvE2rHqbMDq8NvAHb+gCzWpUsTN14H5rL0Jz9SU= X-Received: by 2002:a05:6402:44c:b0:445:f2f1:4add with SMTP id p12-20020a056402044c00b00445f2f14addmr23396612edw.257.1663007442431; Mon, 12 Sep 2022 11:30:42 -0700 (PDT) MIME-Version: 1.0 References: <20220912164531.1742034-1-ppalka@redhat.com> In-Reply-To: <20220912164531.1742034-1-ppalka@redhat.com> From: Jonathan Wakely Date: Mon, 12 Sep 2022 19:30:30 +0100 Message-ID: Subject: Re: [PATCH 1/4] libstdc++: Add already-accepted testcase [PR106320] To: Patrick Palka Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000dd71b405e87f1785" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000dd71b405e87f1785 Content-Type: text/plain; charset="UTF-8" On Mon, 12 Sep 2022, 17:46 Patrick Palka via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > Although PR106320 only affected the 10 and 11 branches, and the testcase > from there was already correctly accepted on trunk and the 12 branch, we > should also add the testcase to 12/trunk for inter-branch consistency. > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/12? > Yes, good idea to add this. > PR libstdc++/106320 > > libstdc++-v3/ChangeLog: > > * testsuite/std/ranges/adaptors/join.cc (test13): New test. > --- > libstdc++-v3/testsuite/std/ranges/adaptors/join.cc | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/libstdc++-v3/testsuite/std/ranges/adaptors/join.cc > b/libstdc++-v3/testsuite/std/ranges/adaptors/join.cc > index 8986f718229..530ab6663b5 100644 > --- a/libstdc++-v3/testsuite/std/ranges/adaptors/join.cc > +++ b/libstdc++-v3/testsuite/std/ranges/adaptors/join.cc > @@ -205,6 +205,18 @@ test12() > }(); > } > > +void > +test13() > +{ > + // PR libstdc++/106320 > + auto l = std::views::transform([](auto x) { > + return x | std::views::transform([i=0](auto y) { > + return y; > + }); > + }); > + std::vector> v{{5, 6, 7}}; > + v | l | std::views::join; > +} > int > main() > { > @@ -220,4 +232,5 @@ main() > test10(); > test11(); > test12(); > + test13(); > } > -- > 2.37.3.542.gdd3f6c4cae > > --000000000000dd71b405e87f1785--