From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 324BF3858D28 for ; Fri, 19 Aug 2022 18:48:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 324BF3858D28 Received: by mail-ed1-x52f.google.com with SMTP id q2so4570454edb.6 for ; Fri, 19 Aug 2022 11:48:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=yd1OCuezdjMU323a9Xc45tKHuhtCr4r0J3PIQPXQT2o=; b=QEN75B/OXVfn/xIw0VDEN89IGzKEBkSMej9hTNDBpDHwDwHa3yT79IDyxpTlqlLYMg JJdDD+/Z3/ExEwvzz/Mh4x0UkO4K30wv2hjt+pDTGJvw+W5OiMcoKb+hK3SMwlyG9ewS 1F8jgem/Ywo7XnEQgIHcv5Y+Qtl7itzOW9S/RVNzkhyA6HBTVdBZeMJt0oC2tbMe6QiP coxf5acI8gBjqrmVWhNda+6LiGBSeYLv4WvgdkfRpajzoXhXMsPLqmGSF3cGRxem//HJ ViQHGzFZ35CSxUPTOUX1OVMt2XutPtHm21b3Ktp+fcjmI8oRi5DQASzOyxdbTdF/QwS/ Yfnw== X-Gm-Message-State: ACgBeo3bPDFdQfnft9oX9D1CcWQJh8RXjOP5INsvTIcGbaGUOEiJCBes wRGnhuHvuRn8J5U3k3q/spHZHWmIuZ3xqCN8USE= X-Google-Smtp-Source: AA6agR6/tSth6Nk1TlODR0ett4iBACnMLJSVdIDRMa/2PWyTLwufihwDKdtAaBy0CD7aHKuA/gJ1YnN8Z0B1PsVcjc0= X-Received: by 2002:a05:6402:3585:b0:445:e56b:faf7 with SMTP id y5-20020a056402358500b00445e56bfaf7mr7045232edc.356.1660934918927; Fri, 19 Aug 2022 11:48:38 -0700 (PDT) MIME-Version: 1.0 References: <20220819180034.98441-1-whh8b@obs.cr> <20220819180034.98441-2-whh8b@obs.cr> In-Reply-To: <20220819180034.98441-2-whh8b@obs.cr> From: Jonathan Wakely Date: Fri, 19 Aug 2022 20:48:26 +0200 Message-ID: Subject: Re: [PATCH] libstdc++: Add std:: prefix for forward_iterator_tag To: whh8b@obs.cr Cc: "libstdc++" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 18:48:42 -0000 On Fri, 19 Aug 2022, 20:01 , wrote: > From: Will Hawkins > > libstdc++-v3/ChangeLog: > > * include/bits/basic_string (basic_string(const _CharT*, size_type > _, const _Alloc&)): > Add std:: prefix to forward_iterator_tag. > This qualification is not necessary, there is no ADL for that expression, so name lookup cannot possibly find anything except std::forward_iterator_tag. N.B. patches for libstdc++ need to be CC'd to gcc-patches as well as the libstdc++ list. --- > libstdc++-v3/include/bits/basic_string.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libstdc++-v3/include/bits/basic_string.h > b/libstdc++-v3/include/bits/basic_string.h > index b04fba95678..e7d7833e002 100644 > --- a/libstdc++-v3/include/bits/basic_string.h > +++ b/libstdc++-v3/include/bits/basic_string.h > @@ -639,7 +639,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11 > std::__throw_logic_error(__N("basic_string: " > "construction from null is not > valid")); > const _CharT* __end = __s + traits_type::length(__s); > - _M_construct(__s, __end, forward_iterator_tag()); > + _M_construct(__s, __end, std::forward_iterator_tag()); > } > > /** > -- > 2.34.1 > >