From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id F0BF53858C41; Wed, 27 Sep 2023 19:57:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0BF53858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9b2a3fd5764so571027666b.3; Wed, 27 Sep 2023 12:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695844645; x=1696449445; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SbxHtUyRkUyCSJIRWm0QNRfbE8IJzz7iZzhRN3R5/YI=; b=H+1RLT+08JQp9Quq7YrLJwVCHQ0jPrpz/qqVZmBr7Q8ocqBrn+LmKrUdm6+E/FPdqx 0eyNd192k35KJ4dZf6NufU7AHdOWMrHotdJJZuxzOuJGaVdDxnXQgHZNa6jSS8WjU5Nu G1hZDuF5xFsFZ7FbS5V+3tpz2NY9+XSGZLiRxrtKjntvjMs5CGkmIZWnc+YsJejCChq5 oaP+0I1VCzuNiWjviGr0bKfgXLWxIUKhlM0ryHlXy3Wm5wZZrmFv7Xy+AU4NHfCfXqKD nZQmW0jL0W2bR9umYpZEcm5UiWuj+f9B0G1J2txe93KGZYSAnz3VTU3UlMhCrtEQv9JL U8wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695844645; x=1696449445; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SbxHtUyRkUyCSJIRWm0QNRfbE8IJzz7iZzhRN3R5/YI=; b=s5WVFjOjKYyZtecOcLXmQ6RN/mO3QuYlvJvU7/ojtI+xnyGbYRRi49Ps4HnEjp874o 50bchHulV9HEfUkQcYqkrB6IEXGrMhq6uQkseJlErutJMkzwKuus+9XyJVPMo/H9Mly8 ZAJZdhHMueGw54Wui7odfUTsYxHYcyc0aOPcq4K1mkv0yW8NXIOHOWiTvZaVorn7k6JW 32nrXSSULWHJFk4qoU9J9SGjDle+LpZDw7r4K5pR+k/DwAKHCwyEv1lZTZQI3ZdYw/xW WNesDN74Z9wljOsXj2bUnS8WaL8DsspxwbSCVAMSwWFGRW3VQrtkGE/05t0r2mm2bWOl CbGg== X-Gm-Message-State: AOJu0YyALzuXC5CA0qZRShSSIA7JCMqod+UH1miMt6Ec398wXaNNqHBA n0yuM1F7OTP+qLa5wCzREVxw2DgEYXGSHyYrbmE= X-Google-Smtp-Source: AGHT+IFX9zmHh8Cl85lCPqmcR59LfnJ7FzhM8t1oUoqEGqUOoWNHFFizLXap4r78jKMfFuGWZ27I/WIGu3lbli+kGTo= X-Received: by 2002:a17:907:b19:b0:9a1:e293:9882 with SMTP id h25-20020a1709070b1900b009a1e2939882mr2648468ejl.63.1695844645444; Wed, 27 Sep 2023 12:57:25 -0700 (PDT) MIME-Version: 1.0 References: <20221222233804.772229-1-jwakely@redhat.com> <878r8r4og4.fsf@tromey.com> <874jjf4jia.fsf@tromey.com> In-Reply-To: <874jjf4jia.fsf@tromey.com> From: Jonathan Wakely Date: Wed, 27 Sep 2023 20:57:13 +0100 Message-ID: Subject: Re: [committed] libstdc++: Add GDB printers for types To: Tom Tromey Cc: Jonathan Wakely , Jonathan Wakely via Gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000af9fb406065c9948" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000af9fb406065c9948 Content-Type: text/plain; charset="UTF-8" On Wed, 27 Sept 2023, 18:25 Tom Tromey via Libstdc++, wrote: > >> I have fixes for most of the issues that are worth fixing (I didn't > >> bother with line lengths -- FWIW in gdb we just run 'black' and don't > >> worry about these details), > > Jonathan> I used autopep8 and committed the result as > Jonathan> e08559271b2d797f658579ac8610dbf5e58bcfd8 so the line lengths > Jonathan> should be OK now. > > Yeah, my patches are on top of that, but flake8 still complains, and I > still see lines > 79 characters. However maybe flake8 isn't the checker > you want to use, or maybe you have something set up for a different line > length? > I don't think I have anything set up for python formatting at all, I just committed whatever autopep8 did with its default settings. If that's suboptimal, we can consider other tools, if they're reliable and easy to run. > Jonathan> So the fix is to just change the string to '{} {}' which I've > pushed > Jonathan> as 1fab05a885a308c19cf42b72fd36805ddf27fdc8 now (also attached). > > Thank you. > > Tom > --000000000000af9fb406065c9948--