From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id C9AE33858404; Sun, 30 Jan 2022 17:06:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C9AE33858404 Received: by mail-wm1-x336.google.com with SMTP id k6-20020a05600c1c8600b003524656034cso4742632wms.2; Sun, 30 Jan 2022 09:06:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ovYvLJ8fME/nbvTiZD+0mgNld1878xBBkct1NrvOBd4=; b=XQJhzVAdeddxcjsE1UmS1w7dT7g9DwCBwQ26ekuK4h1xAYw1hT1LcSXOEPreH18ARw dGBHBTgwRyIzsaZ2aZ6ruimbbgL/sfbS2BZP1Kok1mO0djoYwDDseKojPSNPOWpQVkxH TQFZpkzh78SrY8Xw9qaXP2ElRvgCbV1grAlWa/oy7pRTsVhEg9IrW0YyYRFXDBNbuWpo onH4TMAfswEIsy9UtcSXrcqSC+9RaXqtcmv++CaukYp4U5FBE+bIUq498kXJUdg31VEF tsYjX/TMvLY0wmIZgc4pmhMjdblfGbactm+wBKciCb9MM9qZMWr5PmYXgdqTsaTz1Lbp u++Q== X-Gm-Message-State: AOAM533n/9phf0RL2PKItIt9qhmSaKSrsPwtg2rIsuMFrdbtlF34L+id U4pNopJUehJSOYbb/iBSQ3SurnwisCf14+YdPr0= X-Google-Smtp-Source: ABdhPJwD/SXZrjR/b5MQR/6l8y4bVWdybRpPtTO3ZX975/Vrk1sZjd0lAjuV8ERQP3Li5z+e+BfYa2RLEi5gjvKX8CM= X-Received: by 2002:a05:600c:1e2a:: with SMTP id ay42mr23804900wmb.131.1643562399665; Sun, 30 Jan 2022 09:06:39 -0800 (PST) MIME-Version: 1.0 References: <20220130013541.A127620418@pchp3.se.axis.com> <20220130165420.0B0152041A@pchp3.se.axis.com> In-Reply-To: <20220130165420.0B0152041A@pchp3.se.axis.com> From: Jonathan Wakely Date: Sun, 30 Jan 2022 17:06:28 +0000 Message-ID: Subject: Re: [PATCH] libstdc++ testsuite: Don't run lwg3464.cc tests on simulators to 20 To: Hans-Peter Nilsson Cc: gcc-patches , "libstdc++" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jan 2022 17:06:42 -0000 On Sun, 30 Jan 2022 at 16:54, Hans-Peter Nilsson wrote: > > (I had to add separation between your reply and mine in the > quoted parts; you may be aware.) > > > From: Jonathan Wakely > > Date: Sun, 30 Jan 2022 09:32:08 +0100 > > On Sun, 30 Jan 2022, 01:37 Hans-Peter Nilsson via Libstdc++, > wrote: > > > These tests have always been failing for my cris-elf > > > autotester running a simulator; they take about 20 minutes > > > each, compared to the timeout of 720 seconds, doubled > > > because they timed out in another simulator setup. > > > > > > They are the *only* libstdc++ tests that timeout for my > > > setup so I thought this'd be best fixed in the testsuite > > > rather than a local timeout setting (in e.g. the baseboard > > > file). And, better make it an increase that counts. Or, > > > maybe they're actually needlessly excessive? > > > > They are testing behaviour when a counter overflows, so > > they have to read that many bytes. Making them do less > > work would not test that condition. > > > > But there is nothing target-specific in that code, so it > > should be fine to disable them for simulators. They're > > already disabled for LP64 because overflowing the 64-bit > > counter would take forever. > > > > I think that would be better than letting them potentially > > run for 40 minutes even on real hardware. > > Ok. Then this becomes obvious (except from the dejagnu > syntax, but that has an obvious progress path). Also tested > that it still doesn't run nor gets some dejagnu error on > native x86_64-linux-gnu. > > Committed. Thanks! > > 8<--------->8 > These tests have always been failing for my autotester running a > cris-elf simulator; when unrestrained they take about 20 minutes each, > compared to the (doubled) timeout of 720 seconds, of a total 2h40min > for the whole of the libstdc++-v3 testsuite. The tests cover counter > overflow and are already disabled for LP64 targets. > > * testsuite/27_io/basic_istream/get/char/lwg3464.cc: Don't run on > simulator targets. > * testsuite/27_io/basic_istream/get/wchar_t/lwg3464.cc: Likewise. > --- > libstdc++-v3/testsuite/27_io/basic_istream/get/char/lwg3464.cc | 2 +- > .../testsuite/27_io/basic_istream/get/wchar_t/lwg3464.cc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/testsuite/27_io/basic_istream/get/char/lwg3464.cc b/libstdc++-v3/testsuite/27_io/basic_istream/get/char/lwg3464.cc > index f426ff7dd867..5d4de3d6cb54 100644 > --- a/libstdc++-v3/testsuite/27_io/basic_istream/get/char/lwg3464.cc > +++ b/libstdc++-v3/testsuite/27_io/basic_istream/get/char/lwg3464.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // . > > -// { dg-do run { target { ! lp64 } } } > +// { dg-do run { target { { ! lp64 } && { ! simulator } } } } > // { dg-timeout-factor 2 } > > #include > diff --git a/libstdc++-v3/testsuite/27_io/basic_istream/get/wchar_t/lwg3464.cc b/libstdc++-v3/testsuite/27_io/basic_istream/get/wchar_t/lwg3464.cc > index 4be6beb2310f..e2349df8c7d6 100644 > --- a/libstdc++-v3/testsuite/27_io/basic_istream/get/wchar_t/lwg3464.cc > +++ b/libstdc++-v3/testsuite/27_io/basic_istream/get/wchar_t/lwg3464.cc > @@ -15,7 +15,7 @@ > // with this library; see the file COPYING3. If not see > // . > > -// { dg-do run { target { ! lp64 } } } > +// { dg-do run { target { { ! lp64 } && { ! simulator } } } } > // { dg-timeout-factor 2 } > > #include > -- > 2.30.2 > >