Re: [PATCH] gcc-changelog: Add libstdc++-v3/testsuite to wildcard prefixes

[Jonathan Wakely <jwakely.gcc@gmail.com>]

On Mon, 30 Nov 2020 at 09:44, Martin Liška <mliska@suse.cz> wrote:
>
> On 11/27/20 5:23 PM, Jonathan Wakely wrote:
> > This allows using "testsuite/*" in libstdc++-v3/ChangeLog entries, which
> > was one of the original motivations for adding wildcard support in the
> > first place:
> > https://gcc.gnu.org/pipermail/gcc/2020-June/232719.html
> >
> > contrib/ChangeLog:
> >
> >       * gcc-changelog/git_commit.py (wildcard_prefixes): Add libstdc++
> >       testsuite directory.
> >
> > OK to push?
>
> Hello.
>
> It's fine, please push it.

Done.

>
> >
> > This still doesn't actually meet my needs, because I'd like to be able
> > to do:
> >
> >       * testsuite/foo/*: Something for foo tests.
> >       * testsuite/bar/baz/*: Something for baz tests.
>
> Fixed by the patch that I've just pushed.
>
> >
> > So it would be nice if wildcards worked for any directory below a
> > wildcard prefix (as long as the directory actually exists).
>
> It works for me now:
>
> $ git show c41c8c19dcc17f319c1306424f8e7de4868ce037 --stat
> commit c41c8c19dcc17f319c1306424f8e7de4868ce037
> Author: Martin Liska <mliska@suse.cz>
> Date:   Mon Nov 30 10:35:05 2020 +0100
>
>      Test me.
>
>      libstdc++-v3/ChangeLog:
>
>              * doc/html/*: All you need is love.
>
>   libstdc++-v3/doc/html/manual/debug.html | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> $ git gcc-verify -p c41c8c19dcc17f319c1306424f8e7de4868ce037
> Checking c41c8c19dcc17f319c1306424f8e7de4868ce037: OK
> ------ libstdc++-v3/ChangeLog ------
> 2020-11-30  Martin Liska  <mliska@suse.cz>
>
>         * doc/html/*: All you need is love.
>
> Does it also work for you now? Or does it still have a limitation?

I can have a commit which only uses wildcards now, thanks.

I still can't use sub-directories with wildcards, but I can live with that.



> Thanks,
> Martin
>
> >
> > It also seems that I can't have a commit where all changes are
> > described by a wildcard entry. It seems to require a non-wildcard one
> > too. But that means I can't make changes to hundreds of tests without
> > also making some other change, or doing something like:
> >
> >       * testsuite/foo/foo-1.cc: A specific change.
> >          * testsuite/*: Likewise.
> >
> > I suppose I can live with the latter, but it would still be nice if
> > this worked:
> >
> >       * testsuite/foo/foo-1.cc: A specific change.
> >          * testsuite/foo/*: Likewise.
> >          * testsuite/bar/baz/*: Likewise.
> >
> > i.e. sub-directories below a wildcard prefix.
> >
> >
>