From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id BBE7F3857027; Tue, 16 Nov 2021 09:32:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BBE7F3857027 Received: by mail-wm1-x329.google.com with SMTP id f7-20020a1c1f07000000b0032ee11917ceso1885929wmf.0; Tue, 16 Nov 2021 01:32:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YqNj9L0X344jIkbFeOFYh4y6kU7xH2t92zAHrCgk/9g=; b=yfs7Bj1ieO00Hqa/lH2UiIz45TvvPEuYuZ1eOELL0YTAzUSoE5gX73e0fX5mAxThtE +YWHmzZ2vIUaVnKfWEQNtVPX/K3a+XmcJlLowoP3ikUqd76kCeQwZaXVbm3E5yD8rOGw 8qGjTbS0tRoI77v8gmmk64nWlBD4eUOIIVvc4clx3dsZM7pUEoIRxAInRtEqkxIgnEye Tc27W//U3m8azJLIXQGY53beIIrsUT9Zfbb+MihnBGuIm2kw5HxeqPhnJvtD1j25GuNd Tv4Mur5+VrsTx7+F9RlEAVGyWgp3zP+L94lb2Czrxw9ApxQTidGunKIbJzylsEjcWfFq IVDQ== X-Gm-Message-State: AOAM530h8TJlQU2OAf7z8GoR4sRj70pCo3IEwEdyDaBgErLwNTSZOJqF ULdbh0RaN1jHInsLgKqigVmuDCRVJJJQ+MOghxlSLQbe X-Google-Smtp-Source: ABdhPJwqNjgZwUUGGeCBrAe8LHH9jGGYhrkus86rJ+yyIPns+tPBj34TAdG7qr5++5JXN/GLmKyOpR+kfqZmiL9fyj0= X-Received: by 2002:a1c:488:: with SMTP id 130mr6154471wme.157.1637055177871; Tue, 16 Nov 2021 01:32:57 -0800 (PST) MIME-Version: 1.0 References: <20211116002505.2324582-1-ppalka@redhat.com> <87ee7gedjk.fsf@oldenburg.str.redhat.com> In-Reply-To: <87ee7gedjk.fsf@oldenburg.str.redhat.com> From: Jonathan Wakely Date: Tue, 16 Nov 2021 09:32:46 +0000 Message-ID: Subject: Re: [PATCH 1/5] libstdc++: Import the fast_float library To: Florian Weimer Cc: "Patrick Palka via Libstdc++" , gcc-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 09:33:00 -0000 On Tue, 16 Nov 2021 at 08:01, Florian Weimer wrote: > > * Patrick Palka via Libstdc: > > > This copies the fast_float library[1] into the compiled-in library > > sources. We're going to use this library in our floating-point > > std::from_chars implementation for faster and more portable parsing of > > binary32/64 decimal strings. > > > > [1]: https://github.com/fastfloat/fast_float > > > > Series tested on x86_64, i686, ppc64, ppc64le and aarch64, does it > > look OK for trunk? > > Missing Signed-off-by:? That's not needed if Patrick is still covered by an FSF assignment. > > > diff --git a/libstdc++-v3/src/c++17/fast_float/LICENSE-APACHE b/libstdc++-v3/src/c++17/fast_float/LICENSE-APACHE > > new file mode 100644 > > index 00000000000..26f4398f249 > > --- /dev/null > > +++ b/libstdc++-v3/src/c++17/fast_float/LICENSE-APACHE > > @@ -0,0 +1,190 @@ > > + Apache License > > + Version 2.0, January 2004 > > + http://www.apache.org/licenses/ > > > diff --git a/libstdc++-v3/src/c++17/fast_float/LICENSE-MIT b/libstdc++-v3/src/c++17/fast_float/LICENSE-MIT > > new file mode 100644 > > index 00000000000..2fb2a37ad7f > > --- /dev/null > > +++ b/libstdc++-v3/src/c++17/fast_float/LICENSE-MIT > > @@ -0,0 +1,27 @@ > > +MIT License > > + > > +Copyright (c) 2021 The fast_float authors > > You also need to include the README file, which makes it clear that > recipients can choose between Apache and MIT. GCC needs to use the MIT > option, I think. I think we could use Apache as well, because this code isn't going to appear in public headers so the problematic clause doesn't apply. But MIT is simpler.