From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely.gcc@gmail.com>
Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com
 [IPv6:2a00:1450:4864:20::42b])
 by sourceware.org (Postfix) with ESMTPS id 086B53858D3C;
 Tue, 26 Oct 2021 09:05:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 086B53858D3C
Received: by mail-wr1-x42b.google.com with SMTP id e12so17868855wra.4;
 Tue, 26 Oct 2021 02:05:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=eMkjq5EAayjRKwsVaT6tjYKDEmv/Qq81XPKZp/YGmKI=;
 b=jhCsIIYjuhroWLMfv6eoT7Dw8NFLOU6NzDrJmAerx2CssZxe6YxQTpEaCw0KYt+Ob6
 h0c29X9bB2e61LFJYFR/PQWH9zKzekfdlVZZQyMFsHvI0f8VUKw07Y3Gl/3xr+mOdo+2
 GbDnsNFzBaFmX1XUfFuA7jx5QANoFYXRuC5h9fOpuK87JeZiI1HY5E2yUh03CNAlRqxq
 tajgE0qYHiBwvXP1B4LFgzBEgpq3JB046Xg0w2QMz9m+D0HkjwqIDgMaPeZeIb7MWxFO
 40A4yt5cxp67RbJjsb4WxLW+w6FJ0nfXGTP5+djnLnuLN4U1WJFXyAZg0RNFsz1i3AF1
 EkRQ==
X-Gm-Message-State: AOAM530AzPk3Uq2eAlOS6mKOFSMo+3/zNO2c25qh3QM5EvsGp49Jtgqx
 Qa6Q2QyZCvQrQIu07J76ncDCbB8cVc++qSEXyEE=
X-Google-Smtp-Source: ABdhPJzhMH2v7xqGjo0ibQ27VvqDJ/B+plivFVrcDqlmvmR9vMuoIn7wNPJpvA4e82EtvHHVSd3UpiRl7zu5UEY0cw4=
X-Received: by 2002:adf:f50f:: with SMTP id q15mr31156176wro.324.1635239110963; 
 Tue, 26 Oct 2021 02:05:10 -0700 (PDT)
MIME-Version: 1.0
References: <yddtuh52ube.fsf@CeBiTec.Uni-Bielefeld.DE>
In-Reply-To: <yddtuh52ube.fsf@CeBiTec.Uni-Bielefeld.DE>
From: Jonathan Wakely <jwakely.gcc@gmail.com>
Date: Tue, 26 Oct 2021 10:05:00 +0100
Message-ID: <CAH6eHdSibaYs717voXPTFrhTxv+cHv4VcVzT9_GhFNsN8-ij1g@mail.gmail.com>
Subject: Re: [PATCH] libstdc++: Fix 17_intro/names.cc on Solaris
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, "libstdc++" <libstdc++@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Oct 2021 09:05:13 -0000

On Mon, 25 Oct 2021 at 12:55, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
> 17_intro/names.cc and experimental/names.cc currently FAIL on Solaris
>
> FAIL: 17_intro/names.cc (test for excess errors)
> FAIL: experimental/names.cc (test for excess errors)
>
> Excess errors:
> /usr/include/sys/timespec_util.h:22: error: expected ')' before ';' token
> /usr/include/stdlib.h:157: error: expected unqualified-id before '[' token
> /usr/include/stdlib.h:157: error: expected ')' before '[' token
>
> <sys/timespec_util.h> has
>
> extern int timespeccompare(const struct timespec *l, const struct timespec *r);
>
> while <stdlib.h> has
>
> typedef struct drand48_data {
>         unsigned int _initialised;
>         unsigned short int x[3];
>         unsigned short int a[3];
>         unsigned int c;
>         unsigned short lastx[3];
> } drand48_data;
>
> both of which are broken by defining r resp. x to ( in the testcase.
>
> Fixed by undoing the defines.  Tested on i386-pc-solaris2.11,
> sparc-sun-solaris2.11, and x86_64-pc-linux-gnu.
>
> Ok for master?

OK, thanks