From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 630E13858D1E; Sun, 14 Jan 2024 07:52:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 630E13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 630E13858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705218743; cv=none; b=HRtGOhc4b1c/O8I5E+zACEp3VH5GZoyBBslgIi66C+I65NK+gme7ReEclm7paFu3yTeA8oKaVkxQ1+S6qwFWKVEf1IABRW53Lop5LVv4cM2FCVBfrTZhy0q+IwgizuQlibLpxsFBQ33ZIAJDpUeaw2qn+qxh/rCVlzn3WCfFIj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705218743; c=relaxed/simple; bh=jEg49eKQ7HpaAuCazQCm8zfMMM86o5BP5ijFV2zQLcM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Z65TgbfmBvC9ieH8IheLZb6A8gitIfcgbkrd+qFL1dfm5D92nKq9qx7Z5QYLcVb41+V0zjgBrmLsoXIZV13qqxcihQmZVNr254T3kpvzTvh5QZ8RtGrt+0/Fh8est/UzhKCCA1SBRSEmjBhM06Zpsr5KVc46YNx+AJG3XzTOkJU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a2c375d2430so409550666b.1; Sat, 13 Jan 2024 23:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705218740; x=1705823540; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jEg49eKQ7HpaAuCazQCm8zfMMM86o5BP5ijFV2zQLcM=; b=XHJZopx0zqdBsl8lUO0e66jNL1NAkOjnt5OBu9tCGveUn7DV2w/TN8fnsD422gNBRi dKM9CPqjPYds1DwMrY2MrESTtwVO6dshvzNmy85wYRrta+N5ZMbTo1cDIg99PZPYsFA9 aw1Q8oNZ8eZxfjawKvCd3gkuJoR08ENJyvUISNys4/8yC8VnSh8TPTPmyY4TR5I5Myl0 CM/OFlUuvrQoWEyCNxihgKbaVP5ah10PovW/Cm5pe3QKxK3j4z9ytNUvlVNtiHT0XGAB qkCPuJovbSeW1sL3vUMyH/7jus7PzFY6gAdlu9Wan30D/utnn6xql1m1q4JMffKFq6ll PiuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705218740; x=1705823540; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jEg49eKQ7HpaAuCazQCm8zfMMM86o5BP5ijFV2zQLcM=; b=LFDpoqxVl4VEGdt3e7wRa8f0pphpoboR/pcDtX21zuRflrFcZe0zpEQGbkBcL+OGCW gHuDTzIUt8aHWU7jyduwx6Vh/EVuSWqlkyUqydRjFxSPep4HBtkxdHoD6SGdFh5/a3pW Cvq7dPfmEI++RDPgxqROxULtasol5JOTCgltT4UUf5ZeEcKzcRcf2YPSPMguEl9BgoXR qwCs3gbXDXggYXtGyyPoHf7+ZHl1oVBnncN2UsNST15Cyw6MFkmrKSPqN4LahA1z1PqU kTTCBtGR6GiZfDFT8w/P4CgCyZN3T0auTMnJDRzWNaD2ytvHY8JF+spDbuEO4D0yyBU9 6AxA== X-Gm-Message-State: AOJu0YydnsDrGAJ7gSHG0AWfuJRV71Gh5qcC1Wb6Gt4uD3WI23lAbBhr C58c9AOQtsKv7bcy6XHLFBMsHn/6uALWZJGGyfU= X-Google-Smtp-Source: AGHT+IGVXQuYbuKcvksYNOdRpM4f4hJebYCZ0o1F8exRdXfKw4+jFfe3Abj2MSTFInH7bhRVLIF15kHvS8PBEKAjIds= X-Received: by 2002:a17:906:30cd:b0:a2d:423a:721b with SMTP id b13-20020a17090630cd00b00a2d423a721bmr669929ejb.69.1705218739842; Sat, 13 Jan 2024 23:52:19 -0800 (PST) MIME-Version: 1.0 References: <20240114000534.1775261-1-me@jdemille.com> <4e73bdee-b91d-40f8-8fa2-738e525b8835@jdemille.com> In-Reply-To: <4e73bdee-b91d-40f8-8fa2-738e525b8835@jdemille.com> From: Jonathan Wakely Date: Sun, 14 Jan 2024 07:52:06 +0000 Message-ID: Subject: Re: [PATCH] libsupc++: Fix UB terminating on foreign exception To: Julia DeMille Cc: Andrew Pinski , gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="00000000000040b3c9060ee32dcc" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000040b3c9060ee32dcc Content-Type: text/plain; charset="UTF-8" On Sun, 14 Jan 2024, 01:36 Julia DeMille, wrote: > On 1/13/24 19:17, Andrew Pinski wrote: > > 2 things, changelogs go into the email message rather than directly as > > part of the patch., > The reason for this is that the ChangeLog files are auto-generated from the git commit messages, not edited by hand. Patches to those files rarely apply cleanly anyway, because they change so frequently that patches are stale almost immediately. > Apologies. I have prepared a revised patch, and will send it when > applicable. > Thanks. > > Second I wonder if you could add a multiple language testcase using > > GNU objective-C exceptions as an example. > > If not directly adding a testcase there, at least a simple test that > > shows the issue outside of the testsuite? > > I initially discovered this during experimenting with unwinds from a > Rust library ("C-unwind" ABI) into a C++ application. I can upload the > code I used for that. > That would be great thanks. If not obvious, easy instructions for building the test would be helpful for Rust newbs such as myself! --00000000000040b3c9060ee32dcc--