From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 3B8613861917; Thu, 28 Sep 2023 19:02:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B8613861917 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9ad8d47ef2fso1700003966b.1; Thu, 28 Sep 2023 12:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695927730; x=1696532530; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VeRcoUChZVF1wXxQLOgZA0z9Wy3uPa3q4omtbaciJHU=; b=PEY/z/2K6wNrNzcyRWmr8svmxpvEgT+2jXI3Pn9KMHtKNmQh9j+sGzwiLxpQ+50lqg 1x6M+8XTQzf1Am4YaqcAlTUxFLY2bXjsRrsgHMd+J91Kfrkt9Q6ix1oQZPRiDeC4GrHH ybeUVmV65IqtUVKwF3cWqTObdnSUw2Ba1mqZIjZkdzfYDugoTyOTbrkFLTklfm1wSceV BzVBhpZTLRf/tMyNrc5tHff4N0WNj9hikh4YDWn7a++945f5wSMxkZhb8gnYdYZkLmyn IQ2VKvQYhxx67HSjw2RGxMKi8i+KN23D8va6xvUwGE+mbT48+44pcEwPYqe2EvmJcnFz F1Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695927730; x=1696532530; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VeRcoUChZVF1wXxQLOgZA0z9Wy3uPa3q4omtbaciJHU=; b=tqCzaw8zhWEk0u2eJZq2yaQfePlsD/tDjADZdtcqCvnXIEjEReEFACf7SCvfWiPVme 4kfHGs7fOdo9Bg20K1PVR6K0RJG5gmFHxi9jscVZ1zjBKNegQEaaCjyvpBgev33sr8b9 E0U7yzXQ7EY2/AdgBXWtm+FZo2tOpQShLkFhJ/xNHwoIK6kx7PZP7AC4LhBSoIR73kdN y+ZnEpkP5J6KuxFuhJ4D9V50AEdKwuh19PHQZ42Qd3xgfQ5X6Y7r3asRSwlkLtUwUuYw s/OHUki+LLBMf32hf22V6BfKYTHzZn7G6bVz7UjW5Ir46aW6Ma5lXvEhKCWuCOGPnD9i KFFA== X-Gm-Message-State: AOJu0Yw5stW9hM8uCkSE1lMhTXMRSUorGNB0Q0OEQ0Uot+3xlSNuGz4b /k18pMqmIYRv6/4Zl06Tk14NCX3b+GOeDcgI6RU= X-Google-Smtp-Source: AGHT+IFm6spVi48D5ii75fAonMu22lkJsmc5OoqFeITqGJFqJ571/rMQ1JNZT6QlOsX9Twe6jNzyqP9DGCOIWJDhl5A= X-Received: by 2002:a17:906:7695:b0:9ae:3d7b:6f46 with SMTP id o21-20020a170906769500b009ae3d7b6f46mr1976838ejm.46.1695927729804; Thu, 28 Sep 2023 12:02:09 -0700 (PDT) MIME-Version: 1.0 References: <20230928174630.4004388-1-tromey@adacore.com> <20230928174630.4004388-6-tromey@adacore.com> In-Reply-To: <20230928174630.4004388-6-tromey@adacore.com> From: Jonathan Wakely Date: Thu, 28 Sep 2023 20:01:58 +0100 Message-ID: Subject: Re: [PATCH 5/7] libstdc++: Remove std_ratio_t_tuple To: Tom Tromey Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000e658ac06066ff1bc" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000e658ac06066ff1bc Content-Type: text/plain; charset="UTF-8" On Thu, 28 Sept 2023, 18:55 Tom Tromey via Libstdc++, wrote: > This removes the std_ratio_t_tuple function from the Python > pretty-printer code. It is not used. Apparently the relevant parts > were moved to StdChronoDurationPrinter._ratio at some point in the > past. > I think I added it at the same time as that printer, rather than moving it there later. I don't remember if I wanted to replace the _ratio method with that function, or vice versa, but it looks like I never finished whatever I meant to do. Either way, we don't need to keep the unused function. OK, thanks. > libstdc++-v3/ChangeLog: > > * python/libstdcxx/v6/printers.py (std_ratio_t_tuple): > Remove. > --- > libstdc++-v3/python/libstdcxx/v6/printers.py | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py > b/libstdc++-v3/python/libstdcxx/v6/printers.py > index 6bf4fe891fd..94ac9232da7 100644 > --- a/libstdc++-v3/python/libstdcxx/v6/printers.py > +++ b/libstdc++-v3/python/libstdcxx/v6/printers.py > @@ -1985,14 +1985,6 @@ class StdFormatArgsPrinter(printer_base): > return "%s with %d arguments" % (typ, size) > > > -def std_ratio_t_tuple(ratio_type): > - # TODO use reduced period i.e. duration::period > - period = self._val.type.template_argument(1) > - num = period.template_argument(0) > - den = period.template_argument(1) > - return (num, den) > - > - > class StdChronoDurationPrinter(printer_base): > "Print a std::chrono::duration" > > -- > 2.40.1 > > --000000000000e658ac06066ff1bc--