From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id B25B8385771F; Thu, 11 Jan 2024 09:55:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B25B8385771F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B25B8385771F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704966944; cv=none; b=ufwVmLbQMOQA5GRb1/n1SugP+AlNi1Ght1rnvmL0Cg7MWphtrWesOtt6rHzNet2doJYxthzuEUVW4/fVtPZznNkYU1nTf77qV+GSlx5vucrueQhJVlKZRvaW2fIjSPPVDfmdTUs9G0cZxOj5GU5WbMa5ccHOcYwoc+Jdzjz/1HE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704966944; c=relaxed/simple; bh=3HAqfGgpVsmHAQ3X8T6U1WHNmVgoF3qpkTjCjkXxR3E=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=qe5WxsHKbF660IlDOlZEMZ4oGITXYxo6oEqf8jvquErHjj3a1QxthOSSfXjjr+oglePzC5NBfjteXTh/nL87TYsKZndudpSNbNx1Rv62EpGLC8Wn5tHKhqs4Vupnd4qqFZ9vIWl7T096Pu19shYqXeYbIE43r7rjSD+F+WsZ7B0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2cd33336b32so67830151fa.0; Thu, 11 Jan 2024 01:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704966941; x=1705571741; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5/S7/RwWVy6emZQr1Ir1lXF+KmJk9LfIS3tyuzaWh84=; b=NFIBTusTFUso6HouPxYt59l0UEsnA9i3xr/xTDTDR3NdW7Jq8gC/2ajjp5hORItRCK aXyM/t3IPCuIkvmsQ9Vmqfx4Ll+xlZIJQpum0Uq0fhj3U3L3yJQIWeiRrTT9ZcmGeb2A KlJH3rFrLX2g+xS12Lh39wwVC6VTiIXd0E7tAFZGCfL1KHyYCF3V6y+G5BSQLDa1xQM/ oaza2PPKO02sW9LRA84I9GFoIIoQZFIH/JVIXVc+hvnqryYlMbd8miN9nwd21KR8Idpe C4tm+AzFkyatebUBiV0MjuvMtExQCxNJfsmpPGQVBk3r60Fa/XqvscGOt/rhbaAbOlvh 8Y5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704966941; x=1705571741; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5/S7/RwWVy6emZQr1Ir1lXF+KmJk9LfIS3tyuzaWh84=; b=VetjDREaH7n3LzVbTVpbVLIMmtt08ydOKvtCy/yaQNUxZJB2+n71WpR1WCd5DCE7tQ AmzR1wqlrqxE1/RThpIPn3Ij8rYaaXLnlRK+SL3QcEU6Y6STTILlrqlDyZkuv4jvy4/d 7Yq7ddkQWUxjLAgoSUZM2rfJEFR2moHsIqd559z5DO0BJDH4W6RXFa0xoIDUwRKVNIUe RebTj5zBvXXgMIu/C6vtpJxfH+JILSmAqQyjHoIpIQ4t9YYq0DjOWUcmvYeMHGTsnfLb tEzXrQLG4imj7u0h7MoVpTEMhDcN89Sa/MQ75MMq0A/pvaZFyBRJTFfWrVSodmnKBVfd v2rA== X-Gm-Message-State: AOJu0YzRbk8mOfTQrtjzV5yieZ/MmBQvOtTXg6saypJaez/AhMJJhBsX datSqV+q2wqDdGD2H5KbkfssMcH1CEu+7yoGS8Nefbq8 X-Google-Smtp-Source: AGHT+IHVtwqGIjAkav1TRxOirvFaIc/CDoh4t9vRAYydQyMQhxsJJYVTsJHYsVMPdnbvkc00ZhB5lZeDSslpMYt5vao= X-Received: by 2002:a2e:96c4:0:b0:2cd:900c:d602 with SMTP id d4-20020a2e96c4000000b002cd900cd602mr85977ljj.88.1704966940809; Thu, 11 Jan 2024 01:55:40 -0800 (PST) MIME-Version: 1.0 References: <20240111062222.525186-1-kmatsui@gcc.gnu.org> <20240111094038.876653-1-kmatsui@gcc.gnu.org> <20240111094038.876653-2-kmatsui@gcc.gnu.org> In-Reply-To: <20240111094038.876653-2-kmatsui@gcc.gnu.org> From: Jonathan Wakely Date: Thu, 11 Jan 2024 09:55:28 +0000 Message-ID: Subject: Re: [PATCH v2 2/2] libstdc++: Use using instead of typedef in opts-common.h To: Ken Matsui Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000dc5fe4060ea88c1d" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000dc5fe4060ea88c1d Content-Type: text/plain; charset="UTF-8" On Thu, 11 Jan 2024, 09:43 Ken Matsui, wrote: > libstdc++-v3/ChangeLog: > > * src/filesystem/ops-common.h (stat_type): Use using. > > Signed-off-by: Ken Matsui > --- > libstdc++-v3/src/filesystem/ops-common.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/src/filesystem/ops-common.h > b/libstdc++-v3/src/filesystem/ops-common.h > index d78a54754c2..e302d8caae6 100644 > --- a/libstdc++-v3/src/filesystem/ops-common.h > +++ b/libstdc++-v3/src/filesystem/ops-common.h > @@ -118,7 +118,7 @@ namespace __gnu_posix > inline int close(int fd) > { return ::_close(fd); } > > - typedef struct ::__stat64 stat_type; > + using stat_type = struct ::_stat64; > You've removed an underscore, is that intentional? Has this been compiled + tested with mingw? > inline int stat(const wchar_t* path, stat_type* buffer) > { return ::_wstat64(path, buffer); } > @@ -184,7 +184,7 @@ namespace __gnu_posix > using ::open; > using ::close; > # ifdef _GLIBCXX_HAVE_SYS_STAT_H > - typedef struct ::stat stat_type; > + using stat_type = struct ::stat; > using ::stat; > # ifdef _GLIBCXX_USE_LSTAT > using ::lstat; > -- > 2.43.0 > > --000000000000dc5fe4060ea88c1d--