From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 737053857C63; Fri, 15 Jan 2021 19:48:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 737053857C63 Received: by mail-wr1-x42c.google.com with SMTP id m4so10419895wrx.9; Fri, 15 Jan 2021 11:48:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/lePRahyvhBkQIrismQOXVrS3OogjjGlGmho/sPYqSY=; b=VYRsuaSRFo1yYuXQMOybstzDJ51sjMB8M9x5f67UVqOVlx3xt/NHrQ8rBRVy6InXzl brIq1EPRO7e915mIZkqQv3KKl+/OVOVIodh8feeb48IyWFQM5oSLkDn2aZkirZt5heCJ CYF5J2qQdR8ZxWtpbDzBjF9EeT0HraYL1ol5HdAVOS0w28G5bF0RXBR7Yh+iAohqOtfA TrrSLeR6zrLO4rVIA0azW/wFYciLrQOwR5dbWuvz9mNImNOOCtQ7vnTViP3hnFJQuoRo TIXexAVCdl41EvDGoyt1rMdgu9K+Xm87cpQDiNTz31cd03QJfbwo4HAMyLfaHPxp2aZm 2N5g== X-Gm-Message-State: AOAM532wtvo0jVUCb06YJU02LXymiLiKzD/LKiODYvF54p+mlGgC6ZgA hvw5BFac1S3wjqKBM24bpbdJxSeNv9ROPVCpWF4= X-Google-Smtp-Source: ABdhPJwB02fXuVYzm5Ct1E+StzhdJNfn4JHIvVsIUGl6KIVxW92vYlNFkvB4Kj/90qB8S09+ZKIZKxWRAvGIULSbalI= X-Received: by 2002:adf:9e47:: with SMTP id v7mr14567481wre.185.1610740080613; Fri, 15 Jan 2021 11:48:00 -0800 (PST) MIME-Version: 1.0 References: <20210114134142.GC7692@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 15 Jan 2021 19:47:49 +0000 Message-ID: Subject: Re: Add dg-require-wchars to libstdc++ testsuite To: Alexandre Oliva Cc: Jonathan Wakely , "libstdc++" , gcc-patches@gcc.gnu.org, Corentin Gay X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2021 19:48:03 -0000 On Fri, 15 Jan 2021, 16:19 Alexandre Oliva, wrote: > On Jan 15, 2021, Jonathan Wakely wrote: > > > On Thu, 14 Jan 2021, 22:22 Alexandre Oliva, wrote: > >> ... it is definitely the case that the target currently defines wchar_t, > >> and it even offers wchar.h and a lot of (maybe all?) wcs* functions. > >> This was likely not the case when the patch was first written. > >> > >> I'll double check whether any of the patch is still needed for current > >> versions. > > With the tests I've run since yesterday, I've determined that: > > - the wchar-related patches for the libstdc++ testsuite, that I had > proposed last year, are no longer needed > > - your two patchlets did not bring about any regressions to test > results, not in mainline x86_64-linux-gnu native, not with the trivial > backports to the gcc-10 tree for x-arm-vxw7r2 that was the focus of my > immediate attention. > > So, I withdraw my submissions of the testsuite patches, and I encourage > you to proceed with the two changes you proposed. > Great, I'll save them in a git branch to be revisited in stage 1. > However, for avoidance of any doubt, I'll restate that I cannot vow for > whether they're enough to fix the issues we'd run into back when > wchar/wcs* were not supported in the target system, because now they > are, so the changes do not bring any visible improvements to our results > either. > Understood, thanks for checking them though. >