From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id D34283858C52; Thu, 28 Sep 2023 18:47:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D34283858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9a9f139cd94so1661899966b.2; Thu, 28 Sep 2023 11:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695926851; x=1696531651; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=toGJ2z/a9BTVLgRy0B7T2b79/SJngJxlq1/d1cr4Zgw=; b=CDO4raKLKBA3/wqQs8TI6iE9wCf4LrKpWfzJVUN2/YC+L9NT8GcnVGXqq3XLuHuuVw tPeruo/4uh5tNElnqSZRqlLRej2+wpEN8w4gLFsxjl+wCdH+bhbYbPk4GLiqEffn5gpi rPp8T2JYH95dan8wTVJJVQOlZjcuSdVsYdRAh8S4smxPZ+qULCZZSBq4kZ9l8RFuD1jv G6UP8n1bilFHW6mm2aM/GXx0oxXMGfZjO5BDtqryEizcFGkf5Ou9HXWt/m2+ca0hAoS0 f2u7QpK58W0eaEoGstV1I733XOJ6pj1MJx21xwRXpnKlIQwu9+OJEXnl0a+FXZStgYSs BtDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695926851; x=1696531651; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=toGJ2z/a9BTVLgRy0B7T2b79/SJngJxlq1/d1cr4Zgw=; b=F6VhfyZ8yzLeyNmyuokbeyHJWWtBWAeuMeJgFwes9uTvdtO37y6MxgO8YMI4N2siV9 UrPSl4s2Vzf2a3dt3uiGLbp5QEWtKgcjGnXbg6c0gLJeZhI8goPkA+yO0UvxnHn4dw/a O0rc+DqpIWiEpECafeP3m2EnBIhVR752opa+fDAfJSPVE4uTnR4f/Woj/KNx9sRb4teS fY2pspRKveQhwKQMEV3TM1JNw05wQhVpIaikJIi0baBR8ojxpsk//YgvztAhR+Jiz1Zn tTU9D8HHjpET61hCj+jH2uwGL6pF1gqrl8qLwcC13OGRVWsBM2sUS6mmc8PdVwlqPfGW bChg== X-Gm-Message-State: AOJu0YzcTNZu8EZtLnaOOfU9/AUti18yXu0Hl0WMTIWCCttJbLbX0fyG CaEgXCa9XzJ/wdGHsbyM7xcwH+KLWY42X/LdCqs= X-Google-Smtp-Source: AGHT+IEwbAvwQI2Ch1Eq4xD9rMjIYh4NF3cfdsJ4y4k2SLtZbyhh8XcKdwROS9xV3ReDshTFZ7pCCZZ/e0qa5BxCKRk= X-Received: by 2002:a17:906:2931:b0:9a2:19ea:88f7 with SMTP id v17-20020a170906293100b009a219ea88f7mr1620513ejd.64.1695926851091; Thu, 28 Sep 2023 11:47:31 -0700 (PDT) MIME-Version: 1.0 References: <20221222233804.772229-1-jwakely@redhat.com> <878r8r4og4.fsf@tromey.com> <874jjf4jia.fsf@tromey.com> <87r0mi2o88.fsf@tromey.com> In-Reply-To: <87r0mi2o88.fsf@tromey.com> From: Jonathan Wakely Date: Thu, 28 Sep 2023 19:47:19 +0100 Message-ID: Subject: Re: [committed] libstdc++: Add GDB printers for types To: Tom Tromey Cc: Jonathan Wakely , Jonathan Wakely via Gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="00000000000086431906066fbd96" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000086431906066fbd96 Content-Type: text/plain; charset="UTF-8" On Thu, 28 Sept 2023, 18:37 Tom Tromey, wrote: > Jonathan> The changes made by black seem reasonable, though I prefer it > Jonathan> with -S to disable string-normalization. It also needs an > Jonathan> option to use 79 as the maximum line length. > > I've got some patches I'm about to send. > > I made a pyproject.toml to auto-configure black (and isort), and this > works fine, but it also makes a bunch of edits. So I'd rather send that > separately, after the current batch of patches is handled. > > flake8 still isn't really happy, I guess because there are strings that > cause lines over 79, and black doesn't split those. But meh, maybe > suppressing some flake8 errors is the way to go. > I was about to push some changes to split those strings up. > Tom > --00000000000086431906066fbd96--