From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Correctly call _string_types function
Date: Wed, 4 Oct 2023 16:11:48 +0100 [thread overview]
Message-ID: <CAH6eHdTNJLr=PtWEH2=o6uLLChN+RR+60FfPPBkvXgQzEG3aVw@mail.gmail.com> (raw)
In-Reply-To: <20231004151005.1676194-1-tromey@adacore.com>
On Wed, 4 Oct 2023 at 16:10, Tom Tromey <tromey@adacore.com> wrote:
>
> flake8 points out that the new call to _string_types from
> StdExpAnyPrinter.__init__ is not correct -- it needs to be qualified.
OK, thanks.
>
> libstdc++-v3/ChangeLog:
>
> * python/libstdcxx/v6/printers.py
> (StdExpAnyPrinter.__init__): Qualify call to
> _string_types.
> ---
> libstdc++-v3/python/libstdcxx/v6/printers.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py b/libstdc++-v3/python/libstdcxx/v6/printers.py
> index 23efbd171ec..9a51f26d8e0 100644
> --- a/libstdc++-v3/python/libstdcxx/v6/printers.py
> +++ b/libstdc++-v3/python/libstdcxx/v6/printers.py
> @@ -1386,7 +1386,7 @@ class StdExpAnyPrinter(SingleObjContainerPrinter):
> # FIXME need to expand 'std::string' so that gdb.lookup_type works
> if 'std::string' in mgrname:
> mgrtypes = []
> - for s in _string_types():
> + for s in StdExpAnyPrinter._string_types():
> try:
> x = re.sub(r"std::string(?!\w)", s, m.group(1))
> # The following lookup might raise gdb.error if the
> --
> 2.40.1
>
prev parent reply other threads:[~2023-10-04 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 15:10 Tom Tromey
2023-10-04 15:11 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdTNJLr=PtWEH2=o6uLLChN+RR+60FfPPBkvXgQzEG3aVw@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).