From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: Jonathan Wakely <jwakely@redhat.com>,
"libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] gcc-changelog: Add libstdc++-v3/testsuite to wildcard prefixes
Date: Mon, 30 Nov 2020 12:23:18 +0000 [thread overview]
Message-ID: <CAH6eHdTOTU1SDyYVh7BVz3ZZdjf0XQyghgqAQg=_6A+CiqoG9A@mail.gmail.com> (raw)
In-Reply-To: <96a940e8-8411-0c25-f1ba-8b6c4dc9b13b@suse.cz>
On Mon, 30 Nov 2020 at 12:14, Martin Liška <mliska@suse.cz> wrote:
>
> On 11/30/20 12:58 PM, Jonathan Wakely wrote:
> > I can have a commit which only uses wildcards now, thanks.
>
> Good!
>
> >
> > I still can't use sub-directories with wildcards, but I can live with that.
>
> Why? The example I presented did so:
>
> libstdc++-v3/ChangeLog:
> * doc/html/*: All you need is love.
>
> and I modified the following file:
> libstdc++-v3/doc/html/manual/debug.html | 3 ++-
>
> Isn't that a sub-directory?
But libstdc++/doc/html is the entry in the wildcard_prefixes list.
What I mean is using a sub-directory in the changelog:
* doc/html/manual/*: Love is all you need.
The use case is for subsets of the testsuite. I've added
libstdc++-v3/testsuite to the wildcard_prefixes, which means I can now
do this:
* testsuite/*: Update all 28_regex tests.
But I would like to do this:
* testsuite/28_regex/*: Update all tests.
The concrete use case is:
* testsuite/20_util/specialized_algorithms/pstl/*: Add dg-timeout-factor.
* testsuite/25_algorithms/pstl/*: Likewise.
* testsuite/26_numerics/pstl/*: Likewise.
* testsuite/28_regex/*: Likewise.
I'm modifying four specific sub-directories, so I'd like to say that
in the changelog. Currently to allow that I'd have to add every
directory under libstdc++-v3/testsuite to the wildcard_prefixes (which
doesn't scale) or just be vague instead of saying which
sub-directories are affected:
* testsuite/*: Add dg-timeout-factor to most pstl and regex tests.
next prev parent reply other threads:[~2020-11-30 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 16:23 Jonathan Wakely
2020-11-30 9:43 ` Martin Liška
2020-11-30 11:58 ` Jonathan Wakely
2020-11-30 12:14 ` Martin Liška
2020-11-30 12:23 ` Jonathan Wakely [this message]
2020-11-30 12:43 ` Martin Liška
2020-11-30 12:48 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdTOTU1SDyYVh7BVz3ZZdjf0XQyghgqAQg=_6A+CiqoG9A@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).