From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Jonathan Wakely <jwakely@redhat.com>,
gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org,
kyrylo.tkachov@arm.com, richard.earnshaw@arm.com
Subject: Re: [PATCH 2/2] libstdc++: Add dg-require-thread-fence in several tests
Date: Wed, 13 Sep 2023 16:56:12 +0100 [thread overview]
Message-ID: <CAH6eHdT_NUZ5W+b4=2Ly5ctAiFqyqnOZvQZqkium56D=P=D9pQ@mail.gmail.com> (raw)
In-Reply-To: <CAPS5khan6Ua3Y2CKvibxh__gffaCUPVqUzS3rPC-t9gaBiY8Qg@mail.gmail.com>
On Wed, 13 Sept 2023 at 16:38, Christophe Lyon via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> On Tue, 12 Sept 2023 at 11:07, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> > On Tue, 12 Sept 2023 at 08:59, Christophe Lyon
> > <christophe.lyon@linaro.org> wrote:
> > > I've noticed several undefined references to
> > __glibcxx_backtrace_create_state too
> > > 19_diagnostics/stacktrace/current.cc
> > > 19_diagnostics/stacktrace/entry.cc
> > > 19_diagnostics/stacktrace/stacktrace.cc
> >
> > Odd. These were changed in r14-3812-gb96b554592c5cb to link to
> > libstdc++exp.a instead of libstdc++_libbacktrace.a, and
> > __glibcxx_backtrace_create_state should be part of libstdc++exp.a now.
> > If the target doesn't support libbacktrace then the symbols will be
> > missing from libstdc++exp.a, but then the test should fail to match
> > the effective target "stacktrace".
> >
> > Strange, it looks like these libs were not correctly rebuilt after I
> rebased to have your patches.
> I've rebuilt from scratch and these undefined references are not present
> indeed.
Great! Thanks for checking.
I sent a proposed patch that should remove most of the other
unnecessary uses of atomics, as suggested yesterday:
https://patchwork.sourceware.org/project/gcc/patch/20230913123226.2083892-1-jwakely@redhat.com/
Would you be able to check whether that improves the results further for arm4t?
I think with that, you should only need the dg-require-thread-fence
for the 9 or so tests under 29_atomics/ which really do require atomic
synchronization.
next prev parent reply other threads:[~2023-09-13 15:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 19:30 [PATCH 1/2] testsuite: Add and use thread_fence effective-target Christophe Lyon
2023-09-10 19:30 ` [PATCH 2/2] libstdc++: Add dg-require-thread-fence in several tests Christophe Lyon
2023-09-11 10:59 ` Jonathan Wakely
2023-09-11 12:36 ` Christophe Lyon
2023-09-11 13:10 ` Jonathan Wakely
2023-09-11 13:57 ` Christophe Lyon
2023-09-11 15:22 ` Jonathan Wakely
2023-09-11 15:27 ` Richard Earnshaw (lists)
2023-09-11 15:39 ` Christophe Lyon
2023-09-11 16:11 ` Jonathan Wakely
2023-09-12 7:59 ` Christophe Lyon
2023-09-12 9:07 ` Jonathan Wakely
2023-09-13 15:37 ` Christophe Lyon
2023-09-13 15:56 ` Jonathan Wakely [this message]
2023-09-14 9:09 ` [PATCH v2 " Christophe Lyon
2023-09-14 9:25 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdT_NUZ5W+b4=2Ly5ctAiFqyqnOZvQZqkium56D=P=D9pQ@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=kyrylo.tkachov@arm.com \
--cc=libstdc++@gcc.gnu.org \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).