From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 4CF493858D20; Wed, 13 Sep 2023 15:56:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CF493858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9ad810be221so720866b.2; Wed, 13 Sep 2023 08:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694620584; x=1695225384; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CP6iEMSOC775Yxd2nZM/+ZgjI5AYPYCyyxgwLolfOb8=; b=CrLTw49DTs00G9f0WjE9vuREFyShDbhZhV5AHF5eC9+mxV3fGIUDp1kLLX0ZKau2k+ 1tqi3yibBYJsLNO+wup14NurVVQXjVzb+l1OXnkSfAxLVwmPbNwgp7bb7gRuCxdkImoW bsRWM64MsCgRgWeHuORl3qmPOwnUcwv4qgH9zReg8ZMBRnazpxOZugk3hj/cxdPUZWZI +E+i5Obo2TNH7BypT6B21evlivGP9QUs6fWeBtOPOwk85mII+1Uvx2aIFk8sKygR1pwR uJn2lIowH/+s+9uPu4EwET1fQ/ngjTN6WJ0ecBZ94/DoD0bxMCPkOdshtZ626fvVCeiI AiIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694620584; x=1695225384; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CP6iEMSOC775Yxd2nZM/+ZgjI5AYPYCyyxgwLolfOb8=; b=mbcG2MWphC1eSY+SrX+fxHFDozoAUFOEaPA+eiSfHpaYlC8iGWtUCVGYQSTVarxGIb aTIN1y6CCm7rTJAuHA53EnxL4RMNKO1jpK8qITaqpssijFycYLwRFDxj72UK3/3oOA52 onV+mcV54QQiv29CKbP2POVog4V8Y+anrMI+uO03I6Nnj/DmWGQj+e3GplpJc9kkGUwg Pa344AFoUwtI9h3MeSpIhO9B1G2ohyW0r0YuKHCZwl4BgKlfFyx7QuoPX8f4LUS3JRPB rWfl8WsPgFkNSvp4+MtmHh0nMmPBRueEHO6dccIVxC5/K5Lq1g4Gh7gbCR9+tbNf+Nbm f7jg== X-Gm-Message-State: AOJu0YwlgOgO7Y5/1ta5kDAQdtTkxjYFW9yYu9hZVw9xiGrKZvP3i3hV ru29FZgqT9VMDUb1VApIni5UVE69Dc9ThLwGkzCaQ83rQHo= X-Google-Smtp-Source: AGHT+IESld0ipAM43Z141UmEYwht66fW2IeIC6IU6MkWU52nrdtmqwAluTXfLt3YM6+wdWwIWTVPGcS/uL3AA4DVyXA= X-Received: by 2002:a17:906:32c9:b0:9aa:114d:3e1f with SMTP id k9-20020a17090632c900b009aa114d3e1fmr2477739ejk.46.1694620583690; Wed, 13 Sep 2023 08:56:23 -0700 (PDT) MIME-Version: 1.0 References: <20230910193045.3549775-1-christophe.lyon@linaro.org> <20230910193045.3549775-2-christophe.lyon@linaro.org> In-Reply-To: From: Jonathan Wakely Date: Wed, 13 Sep 2023 16:56:12 +0100 Message-ID: Subject: Re: [PATCH 2/2] libstdc++: Add dg-require-thread-fence in several tests To: Christophe Lyon Cc: Jonathan Wakely , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, kyrylo.tkachov@arm.com, richard.earnshaw@arm.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 13 Sept 2023 at 16:38, Christophe Lyon via Libstdc++ wrote: > > On Tue, 12 Sept 2023 at 11:07, Jonathan Wakely wrote: > > > On Tue, 12 Sept 2023 at 08:59, Christophe Lyon > > wrote: > > > I've noticed several undefined references to > > __glibcxx_backtrace_create_state too > > > 19_diagnostics/stacktrace/current.cc > > > 19_diagnostics/stacktrace/entry.cc > > > 19_diagnostics/stacktrace/stacktrace.cc > > > > Odd. These were changed in r14-3812-gb96b554592c5cb to link to > > libstdc++exp.a instead of libstdc++_libbacktrace.a, and > > __glibcxx_backtrace_create_state should be part of libstdc++exp.a now. > > If the target doesn't support libbacktrace then the symbols will be > > missing from libstdc++exp.a, but then the test should fail to match > > the effective target "stacktrace". > > > > Strange, it looks like these libs were not correctly rebuilt after I > rebased to have your patches. > I've rebuilt from scratch and these undefined references are not present > indeed. Great! Thanks for checking. I sent a proposed patch that should remove most of the other unnecessary uses of atomics, as suggested yesterday: https://patchwork.sourceware.org/project/gcc/patch/20230913123226.2083892-1-jwakely@redhat.com/ Would you be able to check whether that improves the results further for arm4t? I think with that, you should only need the dg-require-thread-fence for the 9 or so tests under 29_atomics/ which really do require atomic synchronization.