From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Hans-Peter Nilsson <hp@axis.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++-v3 expected: Don't test ABI-variant properties in requirements.cc
Date: Wed, 6 Apr 2022 16:57:58 +0100 [thread overview]
Message-ID: <CAH6eHdTa0rXD=LVhMe6zQBjZ1AtQ2prTaxB8cLcSpqGEhfHNpA@mail.gmail.com> (raw)
In-Reply-To: <20220406144234.781D92042B@pchp3.se.axis.com>
Thanks!
On Wed, 6 Apr 2022, 15:42 Hans-Peter Nilsson, <hp@axis.com> wrote:
> > From: Jonathan Wakely <jwakely.gcc@gmail.com>
> > Date: Tue, 5 Apr 2022 20:47:58 +0200
>
> > On Tue, 5 Apr 2022, 17:44 Hans-Peter Nilsson via
> > Libstdc++,
> > <libstdc++@gcc.gnu.org<mailto:libstdc%2B%2B@gcc.gnu.org>>
> > wrote:
> > Ok to commit?
> > -------------- 8< --------------
> >
> > Without this, for a target where alignment and structure-sizes are by
> > default byte-aligned, such as cris-elf, you'll see, in libstdc++.log:
> >
> > /X/gcc/libstdc++-v3/testsuite/20_util/expected/requirements.cc:127:
> error: static assertion failed
> > /X/gcc/libstdc++-v3/testsuite/20_util/expected/requirements.cc:127:
> note: the comparison reduces to '(5 == 2)'
> > compiler exited with status 1
> > FAIL: 20_util/expected/requirements.cc (test for excess errors)
> > Excess errors:
> > /X/gcc/libstdc++-v3/testsuite/20_util/expected/requirements.cc:127:
> error: static assertion failed
> >
> > It seems the intent is a smoke-test and that conditionals for ABI
> > properties are out of scope, so best to just delete this particular
> > line.
> >
> > The idea is to ensure the object is no larger than necessary.
> >
> > I think we could use == sizeof(void*)+alignof(void*) which
> > would be correct everywhere. Does that work for cris-elf?
>
> Oh right, yes it does. Ok then, I'll commit this:
>
> -------------- 8< --------------
>
> [PATCH v2] libstdc++-v3 expected: Correct minimal-size test in
> requirements.cc
>
> Without this, for a target where alignment and structure-sizes are by
> default byte-aligned, such as cris-elf, you'll see, in libstdc++.log:
>
> /X/gcc/libstdc++-v3/testsuite/20_util/expected/requirements.cc:127: error:
> static assertion failed
> /X/gcc/libstdc++-v3/testsuite/20_util/expected/requirements.cc:127: note:
> the comparison reduces to '(5 == 2)'
> compiler exited with status 1
> FAIL: 20_util/expected/requirements.cc (test for excess errors)
> Excess errors:
> /X/gcc/libstdc++-v3/testsuite/20_util/expected/requirements.cc:127: error:
> static assertion failed
>
> The intent of that line is to check that the object is not larger than
> necessary.
>
> libstdc++-v3/:
> * testsuite/20_util/expected/requirements.cc: Correct minimal-size
> test.
>
> ---
> libstdc++-v3/testsuite/20_util/expected/requirements.cc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/20_util/expected/requirements.cc
> b/libstdc++-v3/testsuite/20_util/expected/requirements.cc
> index 485aa338679c..a51a007a4fc3 100644
> --- a/libstdc++-v3/testsuite/20_util/expected/requirements.cc
> +++ b/libstdc++-v3/testsuite/20_util/expected/requirements.cc
> @@ -124,6 +124,6 @@ static_assert( move_assignable< void, G > );
> // QoI properties
> static_assert( sizeof(std::expected<char, unsigned char>) == 2 );
> static_assert( sizeof(std::expected<void, char>) == 2 );
> -static_assert( sizeof(std::expected<void*, char>) == 2 * __alignof(void*)
> );
> +static_assert( sizeof(std::expected<void*, char>) == sizeof(void*) +
> __alignof(void*) );
> static_assert( alignof(std::expected<void, char>) == 1 );
> static_assert( alignof(std::expected<void*, char>) == alignof(void*) );
> --
> 2.30.2
>
>
prev parent reply other threads:[~2022-04-06 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 16:43 Hans-Peter Nilsson
2022-04-05 18:47 ` Jonathan Wakely
2022-04-06 14:42 ` Hans-Peter Nilsson
2022-04-06 15:57 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdTa0rXD=LVhMe6zQBjZ1AtQ2prTaxB8cLcSpqGEhfHNpA@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@axis.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).