From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH 1/2] libstdc++: Define _versioned_namespace in xmethods.py
Date: Tue, 3 Oct 2023 23:57:57 +0100 [thread overview]
Message-ID: <CAH6eHdTczT5i5Gj2uRNNTLMzC_oPhgBbROQZnGg1Zya2rkiicg@mail.gmail.com> (raw)
In-Reply-To: <20231003171851.1161340-2-tromey@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]
On Tue, 3 Oct 2023, 18:19 Tom Tromey, <tromey@adacore.com> wrote:
> flake8 pointed out that is_specialization_of in xmethods.py looks at a
> global that wasn't added to the file. This patch correct the
> oversight.
>
OK, thanks
>
> libstdc++-v3/ChangeLog:
>
> * python/libstdcxx/v6/xmethods.py (_versioned_namespace):
> Define.
> ---
> libstdc++-v3/python/libstdcxx/v6/xmethods.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libstdc++-v3/python/libstdcxx/v6/xmethods.py
> b/libstdc++-v3/python/libstdcxx/v6/xmethods.py
> index 844c8a2105a..8ccf57c4d6b 100644
> --- a/libstdc++-v3/python/libstdcxx/v6/xmethods.py
> +++ b/libstdc++-v3/python/libstdcxx/v6/xmethods.py
> @@ -28,6 +28,8 @@ def get_bool_type():
> def get_std_size_type():
> return gdb.lookup_type('std::size_t')
>
> +_versioned_namespace = '__8::'
> +
> def is_specialization_of(x, template_name):
> """
> Test whether a type is a specialization of the named class template.
> --
> 2.40.1
>
>
next prev parent reply other threads:[~2023-10-03 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 17:18 [PATCH 0/2] A couple minor _versioned_namespace patches Tom Tromey
2023-10-03 17:18 ` [PATCH 1/2] libstdc++: Define _versioned_namespace in xmethods.py Tom Tromey
2023-10-03 22:57 ` Jonathan Wakely [this message]
2023-10-03 17:18 ` [PATCH 2/2] libstdc++: _versioned_namespace is always non-None Tom Tromey
2023-10-03 22:55 ` Jonathan Wakely
2023-10-03 22:57 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdTczT5i5Gj2uRNNTLMzC_oPhgBbROQZnGg1Zya2rkiicg@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).