From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 457343861837; Tue, 3 Oct 2023 22:58:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 457343861837 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9a9cd066db5so281193166b.0; Tue, 03 Oct 2023 15:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696373891; x=1696978691; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=D7cUUg5ttKDcrZgm7OPuUbAIpgngWbqUXeGkDaIUwIM=; b=Dz+GM6Cfp6lRklV4xFDnWB4v/M1YaErduoN/dkRalE8kwLC5CArc8lDmev20670gE6 tzsUUN/b2M+bd1GjbKbvaRCwDjlnC86tEhywcE56DevN7ejgOAZ47MV1J2L2KDx2UdmQ rGOcX9oHIJN9irdo59ivytlxgH5tfQdAZtpHc8z5ILv4U5/bpnWv1rh8qcg7JwBTdSps 2Bw3ont9f/2T4ZQoNS3yTkU/C2OPop2Ch+AGiYGN9ZcWBwfVxt0Wt2h8B/t8hVISw9Wd VP/0ryFbHpUrYQtiQ5p6uYzNJA1gJLSyLcjVXRQOgxM3vRSdCH98M8fqS3xPBE6z5Tfs DfQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696373891; x=1696978691; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D7cUUg5ttKDcrZgm7OPuUbAIpgngWbqUXeGkDaIUwIM=; b=WxSzSOPaOSufm/Oy+2IyLcV/xbnl783ojBA/osd/XNpYkYzo8C4eYbkC+kRgT0Quhj XMaXBor2I3oxGpzdUQ2Y626cj7fXDERDZBv2eKfP2/GJhj0tS5wmEem4By+bYeYc2r9p DHeH1fvM2u2S0/bX5RFZOxcXlttxiayV0w4Lp726JQ5/5whXmC45BLHda3gTAVYrgmRS ftoDE44qDI1xslFo/hcn/ZL9I6BkcZi1IW9WPt245B8hnPrAW9DhgZcq3nXtF8GElTAo V8n2XPcHGpsl+z93/s70pCkFGlgZ7FZQzY2hDwa467S20aH5v/yENXACs2oaePFqjDAl j2dw== X-Gm-Message-State: AOJu0Yyr2Gn/ooysW3Kl9mFYpKi+iDmJTs16whq1/pC4tDHuhSdsrvzp XOvOJE7/E4dsJO5M5llMmPDgiXYuh7oYdJv2N4g= X-Google-Smtp-Source: AGHT+IFZcqitCbWzQL6EUrF+Y9qKpb9qBm3vjAl+ziRKHH9s+Y/2FvQ/qrKhmdrgY0aUU+KV1qwRekX0zBLP97w4sJ8= X-Received: by 2002:a17:907:7786:b0:9b7:37de:6011 with SMTP id ky6-20020a170907778600b009b737de6011mr495736ejc.71.1696373890650; Tue, 03 Oct 2023 15:58:10 -0700 (PDT) MIME-Version: 1.0 References: <20231003171851.1161340-1-tromey@adacore.com> <20231003171851.1161340-2-tromey@adacore.com> In-Reply-To: <20231003171851.1161340-2-tromey@adacore.com> From: Jonathan Wakely Date: Tue, 3 Oct 2023 23:57:57 +0100 Message-ID: Subject: Re: [PATCH 1/2] libstdc++: Define _versioned_namespace in xmethods.py To: Tom Tromey Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="0000000000002898e30606d7d329" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002898e30606d7d329 Content-Type: text/plain; charset="UTF-8" On Tue, 3 Oct 2023, 18:19 Tom Tromey, wrote: > flake8 pointed out that is_specialization_of in xmethods.py looks at a > global that wasn't added to the file. This patch correct the > oversight. > OK, thanks > > libstdc++-v3/ChangeLog: > > * python/libstdcxx/v6/xmethods.py (_versioned_namespace): > Define. > --- > libstdc++-v3/python/libstdcxx/v6/xmethods.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libstdc++-v3/python/libstdcxx/v6/xmethods.py > b/libstdc++-v3/python/libstdcxx/v6/xmethods.py > index 844c8a2105a..8ccf57c4d6b 100644 > --- a/libstdc++-v3/python/libstdcxx/v6/xmethods.py > +++ b/libstdc++-v3/python/libstdcxx/v6/xmethods.py > @@ -28,6 +28,8 @@ def get_bool_type(): > def get_std_size_type(): > return gdb.lookup_type('std::size_t') > > +_versioned_namespace = '__8::' > + > def is_specialization_of(x, template_name): > """ > Test whether a type is a specialization of the named class template. > -- > 2.40.1 > > --0000000000002898e30606d7d329--