From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 90D70385703A; Sun, 13 Nov 2022 19:43:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 90D70385703A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52d.google.com with SMTP id a13so14547900edj.0; Sun, 13 Nov 2022 11:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NiJtbwnuwpThsxVPBIlLCxkDVW+k/z6egCfWFnJwmzA=; b=dNbTxd5Eo/OnG0u4G44pxO9kl9WQZfQnWxMncg4STsrjGHYezTp8WnhvjHexKR5bzw RnBw2Nxrigzgufop+QOqls1Zl7EpYkH+cSc7z3x1JktM/ibrFQ9CL+a73p7WOcmQ11I1 Ce/yfIzBATGZvKy8fjxQzdTe9X2lgeHneGXOjeB+IAYx85mP37jQKGZUWqyChfG7266N ySNSd3guxyFmntS8kYFWwkgn3KyZiV5Eu/V5qjz2WrSbrhV2czORRzPC4xlh1djON4wG QT6WbPlRCpMTYycjeFL2isss1weEkdf+2fdQiy77kLt4KB12jxzlh5trxCXlPMjUpkWL UR5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NiJtbwnuwpThsxVPBIlLCxkDVW+k/z6egCfWFnJwmzA=; b=71c2DJTCx5SH1d6VPlUQBjp5aPkLBRmWXKr9gfyFfwl/7fq7kiLpzd546tWkT+eSSk SaFdMcCFhJRp1IFNbogoDsgWVY8lttRrSMPmCwdFzr3nqQ/vGIp2UqhCfN7+Eh0ya3va LBx3c4X8S543EkTExs49ZHsxFiW6jYVTYr8/eAo98t/5usy1RseOGQgrYWJZ6Q1J0tZD hIstk2PYmnXNQ7xaqKxHksif8NpHMQ6nNqaeEQVkWkvMpkBbOcAqalwCvObzc3AFgyYs KAmp//7anPZ+M99Z5NbD9WVAJxCzrkFEp0arb5SJu5AiR6beHbD6v/6YDbqMqzsi+DNn rwLg== X-Gm-Message-State: ANoB5pkaRXBbXnCwNWKT3Et0+2u67KfnxztWHFTgQdiS6/0ZA/vREf99 IadrrOuc6RISTltNeHs1TUSAppG9koNpgJC9fVmNluq0 X-Google-Smtp-Source: AA0mqf547CXr80JiCBgZs7+1B9eTth0+iZw4S6Iexlj9nVn4hVVk3iXaqLv/MVyO6DTJyhJy+dK8XzJ/WPczRAE0+sw= X-Received: by 2002:aa7:c0d6:0:b0:467:7519:6bff with SMTP id j22-20020aa7c0d6000000b0046775196bffmr7160432edp.301.1668368585203; Sun, 13 Nov 2022 11:43:05 -0800 (PST) MIME-Version: 1.0 References: <20221113180527.2907744-1-arsen@aarsen.me> In-Reply-To: <20221113180527.2907744-1-arsen@aarsen.me> From: Jonathan Wakely Date: Sun, 13 Nov 2022 19:42:52 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories To: =?UTF-8?Q?Arsen_Arsenovi=C4=87?= Cc: "libstdc++" , gcc-patches Content-Type: multipart/alternative; boundary="000000000000e0225705ed5f54eb" X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000e0225705ed5f54eb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 13 Nov 2022, 18:06 Arsen Arsenovi=C4=87 via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > I'm unsure why this issue only started manifesting now with how old this > code is, but this should fix it. > I just pushed a change to how the debug build makefiles are generated, which presumably uncovered this latent bug. I'll review the patch in the morning. > libstdc++-v3/ChangeLog: > > * python/Makefile.am: Call mkinstalldirs before INSTALL_DATA > when installing gdb scripts. > * python/Makefile.in: Regenerate. > --- > Hi, > > Someone spotted on IRC spotted an error: if trying to install to a fresh > prefix/sysroot with --enable-libstdcxx-debug, the install fails since it's > intended target directories don't exist. I could replicate this on > r13-3944-g43435c7eb0ff60 using > > $ ../gcc/configure --disable-bootstrap \ > --enable-libstdcxx-debug \ > --enable-languages=3Dc,c++ \ > --prefix=3D$(pwd)/pfx > > Install tested on x86_64-pc-linux-gnu with and without > --enable-libstdcxx-debug. > > libstdc++-v3/python/Makefile.am | 4 ++++ > libstdc++-v3/python/Makefile.in | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/libstdc++-v3/python/Makefile.am > b/libstdc++-v3/python/Makefile.am > index f523d3a44dc..7987d33e6d9 100644 > --- a/libstdc++-v3/python/Makefile.am > +++ b/libstdc++-v3/python/Makefile.am > @@ -58,9 +58,13 @@ install-data-local: gdb.py > libname=3D`sed -ne "/^old_library=3D/{s/.*=3D'//;s/'$$//;s/ .*/= /;p;}" \ > $(DESTDIR)$(toolexeclibdir)/libstdc++.la`; \ > fi; \ > + echo " $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)"; \ > + $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir); \ > echo " $(INSTALL_DATA) gdb.py > $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py"; \ > $(INSTALL_DATA) gdb.py > $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py ; \ > if [ -n "$(debug_gdb_py)" ]; then \ > sed "/^libdir =3D /s;'$$;/debug';" gdb.py > debug-gdb.py ; \ > + echo " $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)/debug"; \ > + $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)/debug; \ > $(INSTALL_DATA) debug-gdb.py > $(DESTDIR)$(toolexeclibdir)/debug/$$libname-gdb.py ; \ > fi > diff --git a/libstdc++-v3/python/Makefile.in > b/libstdc++-v3/python/Makefile.in > index 05e79b5ac1e..a68c1836481 100644 > --- a/libstdc++-v3/python/Makefile.in > +++ b/libstdc++-v3/python/Makefile.in > @@ -623,10 +623,14 @@ install-data-local: gdb.py > libname=3D`sed -ne "/^old_library=3D/{s/.*=3D'//;s/'$$//;s/ .*/= /;p;}" \ > $(DESTDIR)$(toolexeclibdir)/libstdc++.la`; \ > fi; \ > + echo " $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)"; \ > + $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir); \ > echo " $(INSTALL_DATA) gdb.py > $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py"; \ > $(INSTALL_DATA) gdb.py > $(DESTDIR)$(toolexeclibdir)/$$libname-gdb.py ; \ > if [ -n "$(debug_gdb_py)" ]; then \ > sed "/^libdir =3D /s;'$$;/debug';" gdb.py > debug-gdb.py ; \ > + echo " $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)/debug"; \ > + $(mkinstalldirs) $(DESTDIR)$(toolexeclibdir)/debug; \ > $(INSTALL_DATA) debug-gdb.py > $(DESTDIR)$(toolexeclibdir)/debug/$$libname-gdb.py ; \ > fi > > -- > 2.38.1 > > --000000000000e0225705ed5f54eb--