From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
"libstdc++" <libstdc++@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Allow emergency EH alloc pool size to be tuned [PR68606]
Date: Tue, 11 Oct 2022 19:57:46 +0100 [thread overview]
Message-ID: <CAH6eHdTnS_pMNocwxcd_egHvs=KT9nuTBAxOoUb8aE-U2_FeXQ@mail.gmail.com> (raw)
In-Reply-To: <CAGWvny=H_rN7_4QHuDODUypOrFrDMNO8vMzedLgc2gnPeErEiA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2953 bytes --]
On Tue, 11 Oct 2022, 19:38 David Edelsohn via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
> This patch seems to have broken bootstrap on AIX. It seems to assume
> methods that aren't guaranteed to be defined.
>
It doesn't use anything that wasn't already used by that file.
I have no idea how it ever compiled if it doesn't now, but I'll take a look.
> Thanks, David
>
> libtool: compile: /tmp/GCC/./gcc/xgcc -B/tmp/GCC/./gcc/
> -B/nasfarm/edelsohn/ins
> tall/GCC/powerpc-ibm-aix7.2.5.0/bin/
> -B/nasfarm/edelsohn/install/GCC/powerpc-ibm
> -aix7.2.5.0/lib/ -isystem
> /nasfarm/edelsohn/install/GCC/powerpc-ibm-aix7.2.5.0/i
> nclude -isystem
> /nasfarm/edelsohn/install/GCC/powerpc-ibm-aix7.2.5.0/sys-include
> -fno-checking -DHAVE_CONFIG_H -I..
> -I/nasfarm/edelsohn/src/src/libstdc++-v3/../
> libiberty -I/nasfarm/edelsohn/src/src/libstdc++-v3/../include
> -D_GLIBCXX_SHARED
>
> -I/tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/powerpc-ibm-aix7.2.5.0
> -I
> /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include
> -I/nasfarm/edelsohn/src/src
> /libstdc++-v3/libsupc++ -I/nasfarm/edelsohn/install/include
> -I/nasfarm/edelsohn/
> install/include -g -O2 -DIN_GLIBCPP_V3 -Wno-error -c cp-demangle.c -fPIC
> -DPIC -o cp-demangle.o
> /nasfarm/edelsohn/src/src/libstdc++-v3/libsupc++/eh_alloc.cc: In member
> function 'void* {anonymous}::pool::allocate(std::size_t)':
> /nasfarm/edelsohn/src/src/libstdc++-v3/libsupc++/eh_alloc.cc:239:54: error:
> no matching function for call to
> '__gnu_cxx::__scoped_lock::__scoped_lock(int&)'
> 239 | __gnu_cxx::__scoped_lock sentry(emergency_mutex);
> | ^
> In file included from
> /nasfarm/edelsohn/src/src/libstdc++-v3/libsupc++/eh_alloc.cc:37:
>
> /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/ext/concurrence.h:240:14:
> note: candidate: '__gnu_cxx::__scoped_lock::__scoped_lock(__mutex_type&)'
> 240 | explicit __scoped_lock(__mutex_type& __name) :
> _M_device(__name)
> | ^~~~~~~~~~~~~
>
> /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/ext/concurrence.h:240:42:
> note: no known conversion for argument 1 from 'int' to
> '__gnu_cxx::__scoped_lock::__mutex_type&'
> 240 | explicit __scoped_lock(__mutex_type& __name) :
> _M_device(__name)
> | ~~~~~~~~~~~~~~^~~~~~
>
> /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/ext/concurrence.h:236:5:
> note: candidate: '__gnu_cxx::__scoped_lock::__scoped_lock(const
> __gnu_cxx::__scoped_lock&)'
> 236 | __scoped_lock(const __scoped_lock&);
> | ^~~~~~~~~~~~~
>
> /tmp/GCC/powerpc-ibm-aix7.2.5.0/libstdc++-v3/include/ext/concurrence.h:236:19:
> note: no known conversion for argument 1 from 'int' to 'const
> __gnu_cxx::__scoped_lock&'
> 236 | __scoped_lock(const __scoped_lock&);
> | ^~~~~~~~~~~~~~~~~~~~
> make[5]: *** [Makefile:778: eh_alloc.lo] Error 1
>
next prev parent reply other threads:[~2022-10-11 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 18:36 David Edelsohn
2022-10-11 18:57 ` Jonathan Wakely [this message]
2022-10-11 19:41 ` Jonathan Wakely
-- strict thread matches above, loose matches on Subject: below --
2022-10-07 15:54 Jonathan Wakely
2022-10-10 6:17 ` Richard Biener
2022-10-10 11:17 ` Jonathan Wakely
2022-10-10 15:10 ` Jonathan Wakely
2022-10-11 6:41 ` Richard Biener
2022-10-11 11:05 ` Jonathan Wakely
2022-10-11 11:34 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdTnS_pMNocwxcd_egHvs=KT9nuTBAxOoUb8aE-U2_FeXQ@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).