From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id BFB72385841A for ; Wed, 7 Sep 2022 11:22:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFB72385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x631.google.com with SMTP id nc14so29581658ejc.4 for ; Wed, 07 Sep 2022 04:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=uSQ8Rklz18QraZ6YlSI08Sq9pFvr6HDyh78HOUUFzls=; b=nSB+hTp51rqFR1ow9E7E7REDtt6bTTMHXw6asBYomT+Tab6qdVIhdsMMNv9YFnKk4d 73WqgxDJaixWim54I0nz9AAgUcLDXv4v7eLTOQa8XxeSap26bpMVJXziTPeQJvbPIyEL nnibUyXbBnjwwLN6ISczNJzCc5L2Nd0KNl5S1AuXPNdAYRwn2D7sJ5CLyWJOCLBM76oE iphx8WmiuTzepcD3Lie/YEoR7LfIL3+dicokrs4d+mqsNLGw1qx5MS6NY4WbvyZ/Auzm mdqfRRXly5kJF9PmO68fT1k1axTiFIEhZrYNrFC4IpN/fAL+7Jn9BWxNESylkbV1Wcui dyqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=uSQ8Rklz18QraZ6YlSI08Sq9pFvr6HDyh78HOUUFzls=; b=5aLcwnB/lsDwHfYvqTp+HuIKKUnfNVZau36GUVNhAaOU5OsOc2J8bMsmO4IopJJnQX pRQHIEg2vnmKaX8/X7aKSuS2j+AUqThn9b+Do15wB99wXeW6r5k8TtkHDK01kKf027U5 iGqjJZ94HaQSM5AH6wGEBdOh92SE3XxysR27wUADxBTNHRpcnvar4oRvlj8myPDLozk+ ygupjqGbyyUF26exNpOd7tBZfFBZwPYrZL+ZkzN4BN7DO1IPfaO6d7mMOVoQg0+t9egd qGdZW7soa3wOHLTRw1/ALWyBLYXgEkWXzyoqw7nXjCQ/qUIDtJvjmRxok+A6E1pfZ6iG AGyg== X-Gm-Message-State: ACgBeo1dGhilsKP3e+GJTsM1aFpz7TroKw+v6OH7qEwYGqsgCo0BGR3G KjTjQA0fnGKp8D/YB/Dt/PgNIcOjVcAStKT/8U0= X-Google-Smtp-Source: AA6agR439nqsIKkEyzIi0/r/f8Y1XOv/G7M5RZIZdfqXUM5E6r9J/SyXC9iz4GGaMlivQJxObQ/Mj6GhI2AHP/USSMU= X-Received: by 2002:a17:906:4fd0:b0:73d:be5b:291d with SMTP id i16-20020a1709064fd000b0073dbe5b291dmr2008254ejw.506.1662549733294; Wed, 07 Sep 2022 04:22:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 7 Sep 2022 12:22:01 +0100 Message-ID: Subject: Re: GPL carve-out missing for barrier To: Tom James Cc: "libstdc++" , Moritz Kreutzer , "Jones, Philip" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 7 Sept 2022 at 10:49, Tom James wrote: > > Hi Jonathan, > > Thanks for that, that's all useful information. > > I've had a more detailed chat with our legal people and I think getting this fixed in master solves the problem for us. > > I had wondered whether it would be possible to bump the 11.2 tag No, definitely not. > to include this change because it's not code, but actually that shouldn't be necessary. It looks like we don't use barrier at the moment, and we're unlikely to do so any time soon. > > Thanks, > Tom > > On Tue, 6 Sept 2022 at 11:56, Jonathan Wakely wrote: >> >> On Tue, 6 Sept 2022 at 11:29, Tom James wrote: >> > >> > Hi, >> > >> > I'm working on a closed-source c++ project that compiles with gcc 11.2. We >> > need to ship the GNU 11.2 run-time alongside our product, and it looks like >> > the std::barrier header is missing the GPL3 carve-out for shipping >> > run-times. >> >> Ouch, I'm pretty sure that's unintentional. I'll go back through my >> email to confirm that. >> >> >> > For the purposes of comparison, let's look at algorithm: >> > https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/std/algorithm >> > >> > Lines 16-18 read as follows: >> > // Under Section 7 of GPL version 3, you are granted additional >> > // permissions described in the GCC Runtime Library Exception, version >> > // 3.1, as published by the Free Software Foundation. >> > >> > These lines are necessary to prevent the GPL infecting our closed-source >> > code. >> >> What exactly are you shipping? There is no code from in >> libstdc++.so so unless your own code is including the header >> and odr-using the inline functions and templates in that header, I >> think your compiled code will not be affected by the license of >> . If you are including that header in the works you >> propagate, or shipping it to customers for compiling their own works >> which they will propagate, then the license exception matters. >> >> > The barrier header appears to be missing these lines: >> > https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/std/barrier >> > >> > >> > Would it be possible to please make the following changes? >> > 1. Add these lines to the master branch, >> > 2. Backport these lines to gnu 11.2 (which is the most recent version >> > supported by our toolchain). >> >> No, we can't backport anything to 11.2 because that's already been released. >> >> I'll add it to the master, gcc-12, and gcc-11 branches, which will >> mean it's present for 11.4, 12.3 and 13.1 (and all releases that >> follow them). >> >> If you are producing a combined work that includes the code, >> then unless/until you're able to wait for 11.4 and use that, you could >> copy the fixed header into your own GCC 11.2 that you distribute. > > > > -- > Tom James > > Siemens Digital Industries Software > Simulation and Test Solutions, Solution Domains Development, Server, Platform, Simulation Framework, High Performance Computing > thomasjames@siemens.com > sw.siemens.com