From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id E18C53858D39; Tue, 19 Oct 2021 18:47:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E18C53858D39 Received: by mail-wm1-x334.google.com with SMTP id o24-20020a05600c511800b0030d9da600aeso4854885wms.4; Tue, 19 Oct 2021 11:47:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=snOhGqNU5HYX4r0vD5/SSuRQp6ZwWGTz8mjQHJCMPRg=; b=sTyvTIxg+6nP6LI/zwhUvzVopbq8WbQlJqvvougKoHJx3FBghQMGyPUX9VmFh+88wS ezwRUO8tJ+ZxzzjqWToPO9MpAHqvWSWCTjEmTBRG8sAzS4yPFsO3Uq26y1h8oq6mN0SJ plKQZetrWC44SfNOcxLW7WqYlED31B1F5RHJu+KeUbpdACzwMV+Wp7WDcCHXRN/NU/Qr bfVOjliggpBFp9h8nGqMBVv/WkTJRc47CCQ7fczNPDU4NoNHAnWspD1RagQL9Z9O/TVP alrUG3X1VhGn+0gJ7aeKd8FKn24dr456yNjszsb0lfTR4fj8x+JUKmXlqO/a/ak7wvT3 RgNg== X-Gm-Message-State: AOAM53223bfIYI1ex2z36k/Xr9DiFpS9I00mOPD0bw47ULTO8zIMGlas qiLxi+e7h6vmABIRludDh2qNnainwGxdLSz65Ms= X-Google-Smtp-Source: ABdhPJzYu/TjuuFi5+8Bttlgh3zZysUgL6H/H8EmGRt8tVUbH4PMbVtnPJ15qBjCVlrJ/D9dj/Nt01uwDU/OaAi4nDM= X-Received: by 2002:a1c:e90a:: with SMTP id q10mr8153943wmc.108.1634669245189; Tue, 19 Oct 2021 11:47:25 -0700 (PDT) MIME-Version: 1.0 References: <20211019182947.1694133-1-ppalka@redhat.com> In-Reply-To: <20211019182947.1694133-1-ppalka@redhat.com> From: Jonathan Wakely Date: Tue, 19 Oct 2021 19:47:13 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Implement LWG 3580 changes to ranges::iota_view To: Patrick Palka Cc: gcc-patches , "libstdc++" X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 18:47:28 -0000 On Tue, 19 Oct 2021, 19:33 Patrick Palka via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk and branches? > Yes, thanks. > libstdc++-v3/ChangeLog: > > * include/std/ranges (iota_view::operator+): Adjust definition > as per LWG 3580. > (iota_view::operator-): Likewise. > --- > libstdc++-v3/include/std/ranges | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/include/std/ranges > b/libstdc++-v3/include/std/ranges > index 18bd087985c..5e18c98eb2f 100644 > --- a/libstdc++-v3/include/std/ranges > +++ b/libstdc++-v3/include/std/ranges > @@ -497,7 +497,10 @@ namespace ranges > friend constexpr _Iterator > operator+(_Iterator __i, difference_type __n) > requires __detail::__advanceable<_Winc> > - { return __i += __n; } > + { > + __i += __n; > + return __i; > + } > > friend constexpr _Iterator > operator+(difference_type __n, _Iterator __i) > @@ -507,7 +510,10 @@ namespace ranges > friend constexpr _Iterator > operator-(_Iterator __i, difference_type __n) > requires __detail::__advanceable<_Winc> > - { return __i -= __n; } > + { > + __i -= __n; > + return __i; > + } > > friend constexpr difference_type > operator-(const _Iterator& __x, const _Iterator& __y) > -- > 2.33.1.711.g9d530dc002 > >