From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id BD9123858D3C; Mon, 25 Mar 2024 15:42:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD9123858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD9123858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::529 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711381330; cv=none; b=Vc8LanX17ZN8onDtq3MiQHRwq2FFp6yzQ602Wz4Q+wfih5e9k1wBEMCWwS0rXmlvg06gx1kyf8cvjpu0v8B7GYHJplEeU7FRf7r2uzmClWYCwU1+Zj3VRYFeMl3fE8RxzGeukNkOUZcN/DNZxNCD+rRgGm860JPsP8YxXOPEqdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711381330; c=relaxed/simple; bh=dyY27acbGOWfhk7JQDINrfc5Ue9Mc04+oJikbTHs9Bw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=cnf4YH+x6oUkL8kln3TQHmmvhbtQIgTQxpV6KZ2/EL1O8tTXQraDK4J0t4AtoIupQXICCoZ6Q5nT6yjpIqWDtAf2aBtkx45kY3ZcEzmdwKKTScojgU85DbRQAS2n6Z68rOl5ME3C1Rm2r+UI1sn84c//h6E1RM3vIe3w/J0nTWE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-56c1364ff79so1285674a12.1; Mon, 25 Mar 2024 08:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711381327; x=1711986127; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dyY27acbGOWfhk7JQDINrfc5Ue9Mc04+oJikbTHs9Bw=; b=APe2BuexdX59as13GnMpSm4VM7Bvr1HWY7UCyzlDoG8NeIMvKVo8wiNp5KHXd278Du fPjd8MvDCvG5Wobi89LtLmQAeL3rP4dPAEG11O06kdD4AY1G+0rjvvLWh6SxUTvpeCC9 I41uof+azRcjO2sIjdMK4vdi8+vcDHehQW6J/Why8tG3tPj4faiZ4JDjwfEATrnOIsUW 3Hpa9TZFjGC/+Gr09O/Nll8tjkucJDAH4lR1bXoyMDV3dL58ZiLtCs4e8m2K04YKNKIi GYSrnD8Duor3NIWeVSmkXwXC8pnZZ0kQDHDqVCq9A/Fpwg6fZzkXLaWFR2CyWwtcRR4r y2sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711381327; x=1711986127; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dyY27acbGOWfhk7JQDINrfc5Ue9Mc04+oJikbTHs9Bw=; b=pDXtPEg3tOANjv6NqS6LRjj60RGqpGInzahRm89oXtrM8uCqJydubWATa5dmswTSkO QAD5XKalDLQ61469riLkw4+UYJj2YJr86nVGtg/Aw0hBB1Ng51WeLY80OFW5Wj0nPSw5 C6i4A9injb3J4WMwH8qnaYzv0T7EYJ7kJrRYuc6VRTzGTJjtJbXlHR3j8HnU25db+OoP JDTKlLr5P2zPSdBWjLGTnKihiUPELnVzM5bvehvApyh2aGcR1VdtYTUWoHT5tO6BG6B2 mdq58CgW3ZCo2SZe+92iY9ywaPhwgPl4YDCJnL6UtCSG4QsGXRnEGEX4IQ81KvmPyQcu 4jZQ== X-Forwarded-Encrypted: i=1; AJvYcCUYBS78kcGKrKdSJDbekL9/o4dp6XaAIEBphOqgE4dSPBkB91DthS94udEIJ9ndqdHFsGU21vxZlr09HdPAYkq5aUnsqorkax2M05dLSJZo4DD8TDL4yOLMEAMlfL/u X-Gm-Message-State: AOJu0Yy41fLF7ktBRh781Zkpp4znBZi4cNza7iy1yAWJgvTlBXL6oTLq sGkCDvxWN/XEsGYWHI0+U1qStFHMAqFVYOC6vGFIiXeN9rW3EWoevNFo+s4VQGUR4x8ss9+hJKB INbkJuVvDpW+3U1VwjoPLSsKKhnI= X-Google-Smtp-Source: AGHT+IFKiQ4v4fvvya31zcmvovqqVuMiKDz4Up4zic8YNHYSf4pR2thpN6qZGF+NsBN2s5C2l8riV0Cxm7cydBfIXH4= X-Received: by 2002:a17:907:6d04:b0:a47:4ae0:3bb9 with SMTP id sa4-20020a1709076d0400b00a474ae03bb9mr4319925ejc.23.1711381327308; Mon, 25 Mar 2024 08:42:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:906:f250:b0:a43:a7a:a9a1 with HTTP; Mon, 25 Mar 2024 08:42:06 -0700 (PDT) In-Reply-To: References: <9f2bdd3a973d98199bb5b322baa575ab2fba8a58.camel@xry111.site> From: xndcn Date: Mon, 25 Mar 2024 23:42:06 +0800 Message-ID: Subject: Re: [PING][PATCH] libstdc++: atomic: Add missing clear_padding in __atomic_float constructor To: Jonathan Wakely Cc: Jakub Jelinek , Xi Ruoyao , "H.J. Lu" , GCC Patches , "libstdc++@gcc.gnu.org" Content-Type: multipart/alternative; boundary="00000000000016f00f06147e04bc" X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000016f00f06147e04bc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Wow, thank you all, you guys! =E5=9C=A8 2024=E5=B9=B43=E6=9C=8814=E6=97=A5=E6=98=9F=E6=9C=9F=E5=9B=9B=EF= =BC=8CJonathan Wakely =E5=86=99=E9=81=93=EF=BC=9A > On Fri, 16 Feb 2024 at 15:15, Jonathan Wakely wrote: > > > > On Fri, 16 Feb 2024 at 14:10, Jakub Jelinek wrote: > > > > > > On Fri, Feb 16, 2024 at 01:51:54PM +0000, Jonathan Wakely wrote: > > > > Ah, although __atomic_compare_exchange only takes pointers, the > > > > compiler replaces that with a call to __atomic_compare_exchange_n > > > > which takes the newval by value, which presumably uses an 80-bit FP > > > > register and so the padding bits become indeterminate again. > > > > > > __atomic_compare_exchange_n only works with integers, so I guess > > > it is doing VIEW_CONVERT_EXPR (aka union-style type punning) on the > > > argument. > > > > > > Do you have preprocessed source for the testcase? > > > > Sent offlist. > > Jakub fixed the compiler, so I've pushed the attached patch now. > > Tested x86_64-linux. > --00000000000016f00f06147e04bc--