From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <paul.f.fee@gmail.com>
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com
 [IPv6:2a00:1450:4864:20::135])
 by sourceware.org (Postfix) with ESMTPS id 4A0B2383540B;
 Fri, 15 Jan 2021 01:27:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4A0B2383540B
Received: by mail-lf1-x135.google.com with SMTP id v67so10884428lfa.0;
 Thu, 14 Jan 2021 17:27:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=sYDBnBXEIGrtiT4GtZh0bRwi/54oLR8BrYvrw4F4VSY=;
 b=rgP9k/E+jZ+6nDgon35CuIlwqeFLDMx80oP6zhPrAKKTMpJU/ZaGwlu8TFXcut98Yi
 dg6RRnKnFmn8cVVi5HOpSepL7Iu6xCf3jeaw25ZY6WnPxorEUg837qexwQeKZ+iDDDgt
 T9d+awtvjDjuprmCy2WqPo8tOdO91cJP8hX+A6T9kg8Z8dQrxkX8uvBdlBGHQzxvPLSz
 GfpipjCtlTrGbdMxESpYusBxMkAH7SDP+fGR7c9X00SXoZ/ATKvlGvSMqwGrrhLlEydb
 o8P0Xn4184mn+Z3r4ToGy/GenEAHZKozK+AU1Qs8R/t0TgFh8owo+w2riL7EjGohOM0j
 aUUA==
X-Gm-Message-State: AOAM530+GlpCwbRaBfApV6sm42inNikfU2aAqe+1axhX8kcfH+P661s7
 gWhZhL+UaiCj8HaAw7rMDAYVyy001VE4Qdz8IVZX900mKDikPQ==
X-Google-Smtp-Source: ABdhPJxs4MQvhSbxC2yhR9crQkec2Ckqtjr5yA9snF5O9CbX5vZEV7T+k0xTW16HaHsVOkEvF5ZDIzGsgZTNIvV+4rE=
X-Received: by 2002:ac2:44c3:: with SMTP id d3mr4559635lfm.238.1610674037009; 
 Thu, 14 Jan 2021 17:27:17 -0800 (PST)
MIME-Version: 1.0
References: <CAJYtZHkdhSAGnUp+NTueXAp2TP+pXeUa6g1odFUHM=1ULW9a0w@mail.gmail.com>
 <20210114170644.GH7692@redhat.com>
In-Reply-To: <20210114170644.GH7692@redhat.com>
From: Paul Fee <paul.f.fee@gmail.com>
Date: Fri, 15 Jan 2021 01:27:06 +0000
Message-ID: <CAJYtZH=+6gPMjdSt+zTNr28ww+9jkyGR1yBamt69kW_cgQbFag@mail.gmail.com>
Subject: Re: [PATCH] libstdc++: c++2b, implement WG21 P1679R3
To: Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, "libstdc++" <libstdc++@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jan 2021 01:27:19 -0000

On Thu, Jan 14, 2021 at 5:06 PM Jonathan Wakely <jwakely@redhat.com> wrote:
>
> On 13/01/21 01:21 +0000, Paul Fee via Libstdc++ wrote:
> >Add contains member function to basic_string_view and basic_string.
> >
> >The new method is enabled for -std=gnu++20, gnu++2b and c++2b.  This allows
> >users to access the method as a GNU extension to C++20.  The conditional
> >test may be reduced to "__cplusplus > 202011L" once GCC has a c++2b switch.
>
> Thanks for the patch.
>
> A few comments below.
>

Thanks for the feedback, see "[PATCH v2] libstdc++: C++23, implement
WG21 P1679R3" for fixes.