From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 79A1B39730F1 for ; Wed, 9 Jun 2021 14:30:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79A1B39730F1 Received: by mail-pf1-x42e.google.com with SMTP id g6so18524127pfq.1 for ; Wed, 09 Jun 2021 07:30:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gi/22uCPpxy8QMeHgwJHxLVhIjrJCliz0IGFZdMEGb0=; b=EUQtUcUG7NlztmsFyAJiySuRDYKks5HncITMKxE4B0YTRlwTqyryp41g+1zFU568Zg MbVKjVQ+CrRhp52kPXDROHaAwBSqU0teuoqVEZdeiL8dueBdj7DMsCRR8aGo13c0a0BT 3CiVd3OZ6rEfIttYjIEAkylh7zoMh7/55H1SyNhK5lvNG7kwszG4ob63L+WsWa5pzF9H H+nNwS0Jc2JvDAiXaBYG1YXoYh5hyrzNVs8Kr63pqf8vkACtAqVShYgcoUB6GU+5c9KD jeh2DcwBrViFfZfqCGDzFWD4toYbX2+MIFRlequAb0Mo8gknusEJ78DcDXOJeyTKmhXR g6KA== X-Gm-Message-State: AOAM533BcsS9yLlVUmd/hivHgQhO72XI20eDPq87YFM/RuoRJwF1Kn+F JjctttSD8YCiSv7Rrw+zxdV+aAUiHdCunPzWMDntMQ== X-Google-Smtp-Source: ABdhPJzrkbPj8xvbVhsh5FaXbAdJZigongQefwIM7rne/+q0Ie+Zg/OrvOWBUk/mn9xdpI3LC7oSI707L5XH+FseI4k= X-Received: by 2002:a63:d45:: with SMTP id 5mr23396pgn.72.1623249048419; Wed, 09 Jun 2021 07:30:48 -0700 (PDT) MIME-Version: 1.0 References: <20210607220207.944400-1-rodgert@appliantology.com> <20210608002843.945023-1-rodgert@appliantology.com> In-Reply-To: From: Christophe Lyon Date: Wed, 9 Jun 2021 16:30:37 +0200 Message-ID: Subject: Re: [PATCH] libstdc++: Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889] To: Thomas Rodgers Cc: Jonathan Wakely , gcc Patches , "libstdc++" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 14:30:50 -0000 Hi, On Wed, 9 Jun 2021 at 01:05, Thomas Rodgers via Gcc-patches wrote: > > Tested x86_64-pc-linux-gnu, committed to master, backported to > releases/gcc-11. > > On Tue, Jun 8, 2021 at 8:44 AM Jonathan Wakely wrote: > > > On Tue, 8 Jun 2021 at 01:29, Thomas Rodgers wrote: > > > >> This time without the repeatred [PRnnnn] in the subject line. > >> > >> Fixes libstdc++/100889 > >> > > > > This should be part of the ChangeLog entry instead, preceded by PR so it > > updates bugzilla, i.e. > > > > > > > >> libstdc++-v3/ChangeLog: > >> > > > > PR libstdc++/100889 > > > > > >> * include/bits/atomic_base.h (atomic_ref<_Tp*>::wait): > >> Change parameter type from _Tp to _Tp*. > >> * testsuite/29_atomics/atomic_ref/wait_notify.cc: Extend > >> coverage of types tested. > >> > > > > > > OK for trunk and gcc-11 with that change, thanks. > > > > This is causing a regression on old arm targets: --target arm-none-linux-gnueabi RUNTESTFLAGS: -march=armv5t FAIL: 29_atomics/atomic_ref/wait_notify.cc (test for excess errors) Excess errors: /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: /ccaaHfBz.o: in function `void std::__atomic_impl::store(double*, std::remove_volatile::type, std::memory_order)': /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:971: undefined reference to `__atomic_store_8' /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: /ccaaHfBz.o: in function `std::remove_volatile::type std::__atomic_impl::load(double const*, std::memory_order)': /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:979: undefined reference to `__atomic_load_8' /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:979: undefined reference to `__atomic_load_8' /aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/arm-none-linux-gnueabi/bin/ld: /aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-arm-none-linux-gnueabi/gcc3/arm-none-linux-gnueabi/libstdc++-v3/include/bits/atomic_base.h:979: undefined reference to `__atomic_load_8' collect2: error: ld returned 1 exit status Can you check? Thanks