From: Antony Polukhin <antoshkka@gmail.com>
To: "libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: [PATCH] assert that deleting by pointer to base in unique_ptr does not cause UB
Date: Wed, 22 Sep 2021 20:08:03 +0300 [thread overview]
Message-ID: <CAKqmYPZK8RHFs7SdXZKwb_gCEwrKRyJvbcgDNLh=RU0hYebh-A@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
std::unique_ptr allows construction from std::unique_ptr of derived
type as per [unique.ptr.single.asgn] and [unique.ptr.single.ctor]. If
std::default_delete is used with std::unique_ptr, then after such
construction a delete is called on a pointer to base. According to
[expr.delete] calling a delete on a non similar object without a
virtual destructor is an undefined behavior.
This patch turns that undefined behavior into static assertions inside
std::unique_ptr.
Changelog:
* include/bits/unique_ptr.h: Add static asserts that
deleting by pointer to base in unique_ptr does not cause UB
* testsuite/20_util/unique_ptr/assign/slicing_neg.cc:
New test.
--
Best regards,
Antony Polukhin
[-- Attachment #2: unique_ptr_assert_del.txt --]
[-- Type: text/plain, Size: 4199 bytes --]
diff --git a/libstdc++-v3/include/bits/unique_ptr.h b/libstdc++-v3/include/bits/unique_ptr.h
index 6e55375..53a68f5 100644
--- a/libstdc++-v3/include/bits/unique_ptr.h
+++ b/libstdc++-v3/include/bits/unique_ptr.h
@@ -339,7 +339,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
is_convertible<_Ep, _Dp>>::type>>
unique_ptr(unique_ptr<_Up, _Ep>&& __u) noexcept
: _M_t(__u.release(), std::forward<_Ep>(__u.get_deleter()))
- { }
+ {
+ static_assert(!is_same<_Dp, default_delete<_Tp>>::value
+ || has_virtual_destructor<typename remove_cv<_Tp>::type>::value
+ || sizeof(_Tp) == sizeof(_Up),
+ "type of pointer owned by __u must be similar to the type of pointer "
+ "owned by this object or the latter must have a virtual destructor");
+ }
#if _GLIBCXX_USE_DEPRECATED
#pragma GCC diagnostic push
@@ -385,6 +391,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
unique_ptr&>::type
operator=(unique_ptr<_Up, _Ep>&& __u) noexcept
{
+ static_assert(!is_same<_Dp, default_delete<_Tp>>::value
+ || has_virtual_destructor<typename remove_cv<_Tp>::type>::value
+ || sizeof(_Tp) == sizeof(_Up),
+ "type of pointer owned by __u must be similar to the type of pointer "
+ "owned by this object or the latter must have a virtual destructor");
+
reset(__u.release());
get_deleter() = std::forward<_Ep>(__u.get_deleter());
return *this;
diff --git a/libstdc++-v3/testsuite/20_util/unique_ptr/assign/slicing_neg.cc b/libstdc++-v3/testsuite/20_util/unique_ptr/assign/slicing_neg.cc
new file mode 100644
index 0000000..e93483a
--- /dev/null
+++ b/libstdc++-v3/testsuite/20_util/unique_ptr/assign/slicing_neg.cc
@@ -0,0 +1,86 @@
+// { dg-do compile { target c++11 } }
+// { dg-prune-output "virtual destructor" }
+
+// Copyright (C) 2021 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <memory>
+
+struct A { };
+struct B : A { };
+struct C : B { int i; };
+
+struct Ac { char c; };
+struct Bc : Ac { };
+struct Cc : Bc { short s; };
+
+
+void test01()
+{
+ std::unique_ptr<B> upB;
+
+ std::unique_ptr<const A> cA;
+ cA = std::move(upB);
+
+ std::unique_ptr<volatile A> vA;
+ vA = std::move(upB);
+
+ std::unique_ptr<const volatile A> cvA;
+ cvA = std::move(upB);
+}
+
+void test02()
+{
+ std::unique_ptr<C> upC;
+
+ std::unique_ptr<const A> cA{std::move(upC)}; // { dg-error "required from here" }
+ cA = std::move(upC); // { dg-error "required from here" }
+
+ std::unique_ptr<volatile A> vA{std::move(upC)}; // { dg-error "required from here" }
+ vA = std::move(upC); // { dg-error "required from here" }
+
+ std::unique_ptr<const volatile A> cvA{std::move(upC)}; // { dg-error "required from here" }
+ cvA = std::move(upC); // { dg-error "required from here" }
+}
+
+void test03()
+{
+ std::unique_ptr<Bc> upB;
+
+ std::unique_ptr<const Ac> cA;
+ cA = std::move(upB);
+
+ std::unique_ptr<volatile Ac> vA;
+ vA = std::move(upB);
+
+ std::unique_ptr<const volatile Ac> cvA;
+ cvA = std::move(upB);
+}
+
+void test04()
+{
+ std::unique_ptr<Cc> upC;
+
+ std::unique_ptr<const Ac> cA{std::move(upC)}; // { dg-error "required from here" }
+ cA = std::move(upC); // { dg-error "required from here" }
+
+ std::unique_ptr<volatile Ac> vA{std::move(upC)}; // { dg-error "required from here" }
+ vA = std::move(upC); // { dg-error "required from here" }
+
+ std::unique_ptr<const volatile Ac> cvA{std::move(upC)}; // { dg-error "required from here" }
+ cvA = std::move(upC); // { dg-error "required from here" }
+}
next reply other threads:[~2021-09-22 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 17:08 Antony Polukhin [this message]
2021-09-22 17:22 ` Ville Voutilainen
2021-09-22 17:49 ` Antony Polukhin
2021-09-22 17:53 ` Ville Voutilainen
2021-09-22 17:44 ` Jonathan Wakely
2021-09-22 17:56 ` Antony Polukhin
2021-09-23 10:21 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKqmYPZK8RHFs7SdXZKwb_gCEwrKRyJvbcgDNLh=RU0hYebh-A@mail.gmail.com' \
--to=antoshkka@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).