From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id D07693858C62 for ; Wed, 12 Jul 2023 19:06:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D07693858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-ua1-x930.google.com with SMTP id a1e0cc1a2514c-76d846a4b85so2416028241.1 for ; Wed, 12 Jul 2023 12:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1689188779; x=1691780779; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YObb7Bzp8WW4ViyaSAJbJf9y17s/kE6bwN8NAJam+S0=; b=gyV7Dk6TFRX2mpv2Wj4s1idkc6qz3D8OI5oxiOsbSPy66kSSQeRMFTYEqXF+zcJ7ZQ ZMTzF9DfWdlIW4orhOx2dyqmo89Ekw8i/ahzUNc1jT09bwlWcInZ1PaUOE3JStoVKSjZ 6n+feC9APGVf1BP11XWGILFGPyqCuIPEXRBV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689188779; x=1691780779; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YObb7Bzp8WW4ViyaSAJbJf9y17s/kE6bwN8NAJam+S0=; b=EHosgjKFPl//hRV08CYmmfNpwxJrJpDFSo1fxUtjNqwTV+uFQ1YuGxyeKc38rhozRB +5v85Q8pmNyGi6YOcuGXCO1ZBgVWU7bBOuw7E5FNGy1VA/V2sUEDmg8/ptilEiiyQaJo KsGFDxAFhrIbebFd67hL/3uMZzo2YtQAG5jykOLL/noLuEjia0yXtZxI45oIOw7RNYtc oeUtKelEjMgCe/LRMEWYG9pydsSe1hBwtbEQT4x1WlGY5CDuFmf2ky1JWFpQu0Ib/ng1 PnetBc/5wY83lHQrXVQwuCa88ItJhVuFS4BiAqjH65q82aOEGQNouQ/tzVqIa8UbirHT 5u8Q== X-Gm-Message-State: ABy/qLa+fAIjUjl7P0u6bdauPFsU2rrn6JlP58aSQhtkSkrhq90VWIkU CnzX8f8Mu6iJyS4hWjG/chfNa9NAoaNw1Cb4cnlXgwHWfyxdsbs/ X-Google-Smtp-Source: APBJJlFRnOC6DQDytji7zjdJVR5jFOg4UDgx944x1B7mrIII/m86XRL7iiQaveZQlH5k6TXBc92pBEQipDvvazP8NeA= X-Received: by 2002:a67:e8c6:0:b0:43b:2fa9:eb3a with SMTP id y6-20020a67e8c6000000b0043b2fa9eb3amr10938328vsn.9.1689188779269; Wed, 12 Jul 2023 12:06:19 -0700 (PDT) MIME-Version: 1.0 References: <20230708044539.61276-1-kmatsui@gcc.gnu.org> <20230708044539.61276-2-kmatsui@gcc.gnu.org> In-Reply-To: From: Ken Matsui Date: Wed, 12 Jul 2023 12:06:03 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] libstdc++: use new built-in trait __is_scalar for std::is_scalar To: Xi Ruoyao Cc: Jonathan Wakely , Ken Matsui , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jul 12, 2023 at 11:56=E2=80=AFAM Xi Ruoyao wro= te: > > On Wed, 2023-07-12 at 11:32 -0700, Ken Matsui via Gcc-patches wrote: > > > conditional on the front-end change being committed first of course > > > > Does this mean we want to commit this [2/2] patch before committing > > the [1/2] patch in this case? > > No, this mean you should get 1/2 reviewed and committed first. > > > Also, can I tweak the commit message without being approved again, > > such as attaching the benchmark result? > > Yes, as long as the ChangeLog is still correct (the Git hook will reject > a push with wrong ChangeLog format anyway). I see. Thank you so much! > -- > Xi Ruoyao > School of Aerospace Science and Technology, Xidian University