From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) by sourceware.org (Postfix) with ESMTPS id E45E63858D28 for ; Mon, 3 Jul 2023 10:01:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E45E63858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-vk1-xa2a.google.com with SMTP id 71dfb90a1353d-47e2df3c418so402130e0c.3 for ; Mon, 03 Jul 2023 03:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1688378467; x=1690970467; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g1lT2Pv/TvoNix7YLw5EKNjuNYvYLN6kL9whTz4owhU=; b=hHYGn4hAUo36CGYPG35Q1j/PsLnWP9MefB9JwAja06/HkhotsKXVO76S0YuqRcHUHE l8ONWOLxtivfzx+G9nXAzd+wrlZPa8VHFR28v80ShjngRL4JNuYvXceP9u6n990A7IqU mkRhThuWl2LSeo0obYfCAJv+kPB6OpoF4EIBQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688378467; x=1690970467; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g1lT2Pv/TvoNix7YLw5EKNjuNYvYLN6kL9whTz4owhU=; b=M/edn6kl3vfGqwTxijbrmVwaPfnfSM9o1UZHNg9V9r4AyUJ1Jrx5Ph/aLcowsm/vY1 XmKhE/U6MDtx4r4CnN/mJHSoUjz+ZNquLxopenKgg+lu/7EWzirG75uuqjdERif61fh+ YpGUQUnFxShA8SCtwRPAkccpBUMpPXG9+2EhDqSG4XWOjKN272Yy5BItvQzXb1YkzqJW 9Ibmgaa/UEEmAsP3jct13/up4okVCPjSCoLhmFwuMOV0mZ94ze+oB5m/ngZKOURBiPFS 4ieFX2HPFEJMyuJrd7rMQNNlbF6qu4q/AnwhSiMLYdpl264J+y5sL3IXm9YvwDTmkY+Z JKTg== X-Gm-Message-State: ABy/qLbVb3FKvhvOQ4fExzb+0AkOWzfBjXWEUHmJS4bD54gSheifhk5Z tjzvK2R/BXUDSDMwh15bGAiBI8uEBF9a5+EDjH/sfEW5C5cYZhbc4TY= X-Google-Smtp-Source: APBJJlFtZbJUMAdwr8u4KukZESV2t6H8v7Hn95uWkqnmTZ3XfhzJMTV2VsoPD7Z96S3cu9WwsF5nQY4OGhz0/Yx/FaA= X-Received: by 2002:a1f:3fcc:0:b0:46d:d5c1:8c2a with SMTP id m195-20020a1f3fcc000000b0046dd5c18c2amr4526839vka.16.1688378467034; Mon, 03 Jul 2023 03:01:07 -0700 (PDT) MIME-Version: 1.0 References: <20230703091355.35269-1-kmatsui@cs.washington.edu> In-Reply-To: <20230703091355.35269-1-kmatsui@cs.washington.edu> From: Ken Matsui Date: Mon, 3 Jul 2023 03:00:51 -0700 Message-ID: Subject: Re: [PATCH 1/2] c++, libstdc++: implement __is_scalar built-in trait To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Here is the benchmark result for is_scalar: https://github.com/ken-matsui/gcc-benches/blob/main/is_scalar.md#mon-jul--3= -022250-am-pdt-2023 Time: -90.6237% Peak Memory Usage: -78.5155% Total Memory Usage: -82.1901% Sincerely, Ken Matsui On Mon, Jul 3, 2023 at 2:14=E2=80=AFAM Ken Matsui wrote: > > This patch implements built-in trait for std::is_scalar. The existent > __is_scalar codes were replaced with ____is_scalar to avoid unintentional > macro replacement by the new built-in. > > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_scalar. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_SCALAR. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_scalar. > * g++.dg/ext/is_scalar.C: New test. > * g++.dg/tm/pr46567.C: Use ____is_scalar instead. > * g++.dg/torture/pr57107.C: Likewise. > > libstdc++-v3/ChangeLog: > > * include/bits/cpp_type_traits.h (__is_scalar): Rename to ... > (____is_scalar): ... this. > * include/bits/stl_algobase.h: Use ____is_scalar instead. > * include/bits/valarray_array.h: Likewise. > > Signed-off-by: Ken Matsui > --- > gcc/cp/constraint.cc | 3 ++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 +++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 ++ > gcc/testsuite/g++.dg/ext/is_scalar.C | 31 +++++++++++++++++++++ > gcc/testsuite/g++.dg/tm/pr46567.C | 10 +++---- > gcc/testsuite/g++.dg/torture/pr57107.C | 4 +-- > libstdc++-v3/include/bits/cpp_type_traits.h | 2 +- > libstdc++-v3/include/bits/stl_algobase.h | 8 +++--- > libstdc++-v3/include/bits/valarray_array.h | 2 +- > 10 files changed, 55 insertions(+), 13 deletions(-) > create mode 100644 gcc/testsuite/g++.dg/ext/is_scalar.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index 8cf0f2d0974..4c27f2a3a62 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3751,6 +3751,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_UNION: > inform (loc, " %qT is not a union", t1); > break; > + case CPTK_IS_SCALAR: > + inform (loc, " %qT is not a scalar type", t1); > + break; > case CPTK_IS_AGGREGATE: > inform (loc, " %qT is not an aggregate", t1); > break; > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 8b7fece0cc8..59ae087c457 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially= _assignable", 2) > DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible= ", -1) > DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) > DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) > +DEFTRAIT_EXPR (IS_SCALAR, "__is_scalar", 1) > DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_fr= om_temporary", 2) > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_t= emporary", 2) > /* FIXME Added space to avoid direct usage in GCC 13. */ > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 8fb47fd179e..3edc7f23212 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12118,6 +12118,9 @@ trait_expr_value (cp_trait_kind kind, tree type1,= tree type2) > case CPTK_IS_UNION: > return type_code1 =3D=3D UNION_TYPE; > > + case CPTK_IS_SCALAR: > + return SCALAR_TYPE_P (type1); > + > case CPTK_IS_ASSIGNABLE: > return is_xible (MODIFY_EXPR, type1, type2); > > @@ -12296,6 +12299,7 @@ finish_trait_expr (location_t loc, cp_trait_kind = kind, tree type1, tree type2) > case CPTK_IS_ENUM: > case CPTK_IS_UNION: > case CPTK_IS_SAME: > + case CPTK_IS_SCALAR: > break; > > case CPTK_IS_LAYOUT_COMPATIBLE: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++= .dg/ext/has-builtin-1.C > index f343e153e56..75acbdfb9fc 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -146,3 +146,6 @@ > #if !__has_builtin (__remove_cvref) > # error "__has_builtin (__remove_cvref) failed" > #endif > +#if !__has_builtin (__is_scalar) > +# error "__has_builtin (__is_scalar) failed" > +#endif > diff --git a/gcc/testsuite/g++.dg/ext/is_scalar.C b/gcc/testsuite/g++.dg/= ext/is_scalar.C > new file mode 100644 > index 00000000000..457fddc52fc > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_scalar.C > @@ -0,0 +1,31 @@ > +// { dg-do compile { target c++11 } } > + > +#include // std::nullptr_t > +#include > + > +using namespace __gnu_test; > + > +#define SA(X) static_assert((X),#X) > + > +#define SA_TEST_CATEGORY(TRAIT, TYPE, EXPECT) \ > + SA(TRAIT(TYPE) =3D=3D EXPECT); \ > + SA(TRAIT(const TYPE) =3D=3D EXPECT); \ > + SA(TRAIT(volatile TYPE) =3D=3D EXPECT); \ > + SA(TRAIT(const volatile TYPE) =3D=3D EXPECT) > + > +// volatile return type would cause a warning. > +#define SA_FN_TEST_CATEGORY(TRAIT, TYPE, EXPECT) \ > + SA(TRAIT(TYPE) =3D=3D EXPECT); = \ > + SA(TRAIT(const TYPE) =3D=3D EXPECT) > + > +SA_TEST_CATEGORY(__is_scalar, int, true); > +SA_TEST_CATEGORY(__is_scalar, float, true); > +SA_TEST_CATEGORY(__is_scalar, EnumType, true); > +SA_TEST_CATEGORY(__is_scalar, int*, true); > +SA_FN_TEST_CATEGORY(__is_scalar, int(*)(int), true); > +SA_TEST_CATEGORY(__is_scalar, int (ClassType::*), true); > +SA_FN_TEST_CATEGORY(__is_scalar, int (ClassType::*) (int), true); > +SA_TEST_CATEGORY(__is_scalar, std::nullptr_t, true); > + > +// Sanity check. > +SA_TEST_CATEGORY(__is_scalar, ClassType, false); > diff --git a/gcc/testsuite/g++.dg/tm/pr46567.C b/gcc/testsuite/g++.dg/tm/= pr46567.C > index 6d791484448..d79e0afb462 100644 > --- a/gcc/testsuite/g++.dg/tm/pr46567.C > +++ b/gcc/testsuite/g++.dg/tm/pr46567.C > @@ -225,7 +225,7 @@ namespace std __attribute__ ((__visibility__ ("defaul= t"))) { > : public __traitor<__is_void<_Tp>, __is_arithmetic<_Tp> > > { }; > template > - struct __is_scalar > + struct ____is_scalar > : public __traitor<__is_arithmetic<_Tp>, __is_pointer<_Tp> > > { }; > template > @@ -1325,7 +1325,7 @@ namespace std __attribute__ ((__visibility__ ("defa= ult"))) { > } > template > inline typename > - __gnu_cxx::__enable_if::__value, void>::__type > + __gnu_cxx::__enable_if::__value, void>::__type > __fill_a(_ForwardIterator __first, _ForwardIterator __last, > const _Tp& __value) > { > @@ -1334,7 +1334,7 @@ namespace std __attribute__ ((__visibility__ ("defa= ult"))) { > } > template > inline typename > - __gnu_cxx::__enable_if<__is_scalar<_Tp>::__value, void>::__type > + __gnu_cxx::__enable_if<____is_scalar<_Tp>::__value, void>::__type > __fill_a(_ForwardIterator __first, _ForwardIterator __last, > const _Tp& __value) > { > @@ -1362,7 +1362,7 @@ namespace std __attribute__ ((__visibility__ ("defa= ult"))) { > } > template > inline typename > - __gnu_cxx::__enable_if::__value, _OutputIterator>:= :__type > + __gnu_cxx::__enable_if::__value, _OutputIterator= >::__type > __fill_n_a(_OutputIterator __first, _Size __n, const _Tp& __value) > { > for (; __n > 0; --__n, ++__first) > @@ -1371,7 +1371,7 @@ namespace std __attribute__ ((__visibility__ ("defa= ult"))) { > } > template > inline typename > - __gnu_cxx::__enable_if<__is_scalar<_Tp>::__value, _OutputIterator>::= __type > + __gnu_cxx::__enable_if<____is_scalar<_Tp>::__value, _OutputIterator>= ::__type > __fill_n_a(_OutputIterator __first, _Size __n, const _Tp& __value) > { > const _Tp __tmp =3D __value; > diff --git a/gcc/testsuite/g++.dg/torture/pr57107.C b/gcc/testsuite/g++.d= g/torture/pr57107.C > index 4dbd32bd298..65fd74ded9a 100644 > --- a/gcc/testsuite/g++.dg/torture/pr57107.C > +++ b/gcc/testsuite/g++.dg/torture/pr57107.C > @@ -27,7 +27,7 @@ namespace std __attribute__ ((__visibility__ ("default"= ))) { > }; > template struct __is_arithmetic : public __tra= itor<__is_integer<_Tp>, __is_floating<_Tp> > { > }; > - template struct __is_scalar : public __traitor= <__is_arithmetic<_Tp>, __is_pointer<_Tp> > { > + template struct ____is_scalar : public __trait= or<__is_arithmetic<_Tp>, __is_pointer<_Tp> > { > }; > } > namespace __gnu_cxx __attribute__ ((__visibility__ ("default"))) { > @@ -54,7 +54,7 @@ namespace std __attribute__ ((__visibility__ ("default"= ))) { > }; > template inline typename _Niter_base<_Iterat= or>::iterator_type __niter_base(_Iterator __it) { > } > - template = inline typename __gnu_cxx::__enable_if::__value, _Ou= tputIterator>::__type __fill_n_a(_OutputIterator __first, _Size __n, co= nst _Tp& __value) { > + template = inline typename __gnu_cxx::__enable_if::__value, _= OutputIterator>::__type __fill_n_a(_OutputIterator __first, _Size __n, = const _Tp& __value) { > for (__decltype(__n + 0) __niter =3D __n; > __niter > 0; > --__niter, ++__first) *__first =3D __value; > diff --git a/libstdc++-v3/include/bits/cpp_type_traits.h b/libstdc++-v3/i= nclude/bits/cpp_type_traits.h > index 4312f32a4e0..f7f0d558421 100644 > --- a/libstdc++-v3/include/bits/cpp_type_traits.h > +++ b/libstdc++-v3/include/bits/cpp_type_traits.h > @@ -389,7 +389,7 @@ __INT_N(__GLIBCXX_TYPE_INT_N_3) > // A scalar type is an arithmetic type or a pointer type > // > template > - struct __is_scalar > + struct ____is_scalar > : public __traitor<__is_arithmetic<_Tp>, __is_pointer<_Tp> > > { }; > > diff --git a/libstdc++-v3/include/bits/stl_algobase.h b/libstdc++-v3/incl= ude/bits/stl_algobase.h > index dd95e94f7e9..f292d26fbf0 100644 > --- a/libstdc++-v3/include/bits/stl_algobase.h > +++ b/libstdc++-v3/include/bits/stl_algobase.h > @@ -911,7 +911,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER > template > _GLIBCXX20_CONSTEXPR > inline typename > - __gnu_cxx::__enable_if::__value, void>::__type > + __gnu_cxx::__enable_if::__value, void>::__type > __fill_a1(_ForwardIterator __first, _ForwardIterator __last, > const _Tp& __value) > { > @@ -922,7 +922,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER > template > _GLIBCXX20_CONSTEXPR > inline typename > - __gnu_cxx::__enable_if<__is_scalar<_Tp>::__value, void>::__type > + __gnu_cxx::__enable_if<____is_scalar<_Tp>::__value, void>::__type > __fill_a1(_ForwardIterator __first, _ForwardIterator __last, > const _Tp& __value) > { > @@ -1060,7 +1060,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER > template > _GLIBCXX20_CONSTEXPR > inline typename > - __gnu_cxx::__enable_if::__value, _OutputIterator>:= :__type > + __gnu_cxx::__enable_if::__value, _OutputIterator= >::__type > __fill_n_a1(_OutputIterator __first, _Size __n, const _Tp& __value) > { > for (; __n > 0; --__n, (void) ++__first) > @@ -1071,7 +1071,7 @@ _GLIBCXX_END_NAMESPACE_CONTAINER > template > _GLIBCXX20_CONSTEXPR > inline typename > - __gnu_cxx::__enable_if<__is_scalar<_Tp>::__value, _OutputIterator>::= __type > + __gnu_cxx::__enable_if<____is_scalar<_Tp>::__value, _OutputIterator>= ::__type > __fill_n_a1(_OutputIterator __first, _Size __n, const _Tp& __value) > { > const _Tp __tmp =3D __value; > diff --git a/libstdc++-v3/include/bits/valarray_array.h b/libstdc++-v3/in= clude/bits/valarray_array.h > index 222fd5fd900..682770ad7db 100644 > --- a/libstdc++-v3/include/bits/valarray_array.h > +++ b/libstdc++-v3/include/bits/valarray_array.h > @@ -90,7 +90,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > inline void > __valarray_default_construct(_Tp* __b, _Tp* __e) > { > - _Array_default_ctor<_Tp, __is_scalar<_Tp>::__value>::_S_do_it(__b,= __e); > + _Array_default_ctor<_Tp, ____is_scalar<_Tp>::__value>::_S_do_it(__= b, __e); > } > > // Turn a raw-memory into an array of _Tp filled with __t > -- > 2.41.0 >