From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by sourceware.org (Postfix) with ESMTPS id 44BA63858436 for ; Wed, 22 Mar 2023 21:23:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44BA63858436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-ua1-x932.google.com with SMTP id m5so13634556uae.11 for ; Wed, 22 Mar 2023 14:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1679520221; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NjgqFsFbFOSG5b4rtCAalbjBXb8XKux4YPDnlrFUg6M=; b=lnTlITk2aeJntLnA8JyxcnJSdCLziOeGa7jQnPG4L6R3q6oWLxlZKDJfZgQ+qnms2h vP0oWtwE9QCbk5OcgvjQKH4fubPVqgPNXfU+k4d6xTNwwucrdGYKoBiCc1/NACanFziD WnYSZTGO584mlap/XbGZJCdivyzRo7b4oeGLA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679520221; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NjgqFsFbFOSG5b4rtCAalbjBXb8XKux4YPDnlrFUg6M=; b=M7MpiB5oCq2zbbF3KL6UrR83iPe4Yf29wIF9wX11a9bwvTF5qLpnbE2FA8b4Zn/rUc Zf80nOCYcBjRWxkEEMZz/DIGjl2zM1EucCbTWCG9OnDOKbcN9sNzbCzhhYfiQIuLUteD +D2cJesyb+5SA5VZrlewHOul7XjIL5Us1G6ElbVYwSDCvgtN4RQ24s7j8cNhY7FDdr6S meQkqPsuu6qupZoG8yEWCJhWrFxU8MUsJL3lJyiPr+FtYbtdv3GGmoZtg6t7UlbNE84s I4wjK5O4Riykicmd/+jvhh63zks1l96ozg2O/iTZ2hYbJScSH2b/YtsWkj4oNOFrXvEb RqnQ== X-Gm-Message-State: AAQBX9cV0kN2Hf3iyYgv9pbRQnSRQUwIt9VL7pyeKiI8PELed7deWKtE ITGgmVDdluQL1kN7UdiWin+oqNKeyHOsihdfuDL8SQ== X-Google-Smtp-Source: AKy350b9z+oxERoBao/qwZcwxytXyeN6G8CqdivxoMNdbbUCwLnfP0bskQesucLj1Nafre0N6xnbJwMyLEphzNiEEr0= X-Received: by 2002:a05:6130:28e:b0:68a:a9d:13f5 with SMTP id q14-20020a056130028e00b0068a0a9d13f5mr4739487uac.1.1679520221301; Wed, 22 Mar 2023 14:23:41 -0700 (PDT) MIME-Version: 1.0 References: <20230321163949.1950-1-kmatsui@cs.washington.edu> <20230321170700.4153-1-kmatsui@cs.washington.edu> In-Reply-To: <20230321170700.4153-1-kmatsui@cs.washington.edu> From: Ken Matsui Date: Wed, 22 Mar 2023 14:23:30 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] c++: implement __is_unsigned built-in trait To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, ppalka@redhat.com, Jonathan Wakely Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It seems I missed including Jonathan in the new patch. Could you please take a look? On Tue, Mar 21, 2023 at 10:07=E2=80=AFAM Ken Matsui wrote: > > This patch implements built-in trait for std::is_unsigned. > > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_unsigned. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_UNSIGNED. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_unsigned. > * g++.dg/ext/is_unsigned.C: New test. > --- > gcc/cp/constraint.cc | 3 ++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 ++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 ++ > gcc/testsuite/g++.dg/ext/is_unsigned.C | 47 ++++++++++++++++++++++++ > 5 files changed, 58 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_unsigned.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index 273d15ab097..bc4c3d3ec57 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3747,6 +3747,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_UNION: > inform (loc, " %qT is not a union", t1); > break; > + case CPTK_IS_UNSIGNED: > + inform (loc, " %qT is not an unsigned type", t1); > + break; > case CPTK_IS_AGGREGATE: > inform (loc, " %qT is not an aggregate", t1); > break; > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index bac593c0094..9f1fff9043e 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially= _assignable", 2) > DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible= ", -1) > DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) > DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) > +DEFTRAIT_EXPR (IS_UNSIGNED, "__is_unsigned", 1) > DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_fr= om_temporary", 2) > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_t= emporary", 2) > /* FIXME Added space to avoid direct usage in GCC 13. */ > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 87c2e8a7111..d43e2543490 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12031,6 +12031,9 @@ trait_expr_value (cp_trait_kind kind, tree type1,= tree type2) > case CPTK_IS_UNION: > return type_code1 =3D=3D UNION_TYPE; > > + case CPTK_IS_UNSIGNED: > + return TYPE_UNSIGNED (type1); > + > case CPTK_IS_ASSIGNABLE: > return is_xible (MODIFY_EXPR, type1, type2); > > @@ -12200,6 +12203,7 @@ finish_trait_expr (location_t loc, cp_trait_kind = kind, tree type1, tree type2) > case CPTK_IS_ENUM: > case CPTK_IS_UNION: > case CPTK_IS_SAME: > + case CPTK_IS_UNSIGNED: > break; > > case CPTK_IS_LAYOUT_COMPATIBLE: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++= .dg/ext/has-builtin-1.C > index f343e153e56..20bf8e6cad5 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -146,3 +146,6 @@ > #if !__has_builtin (__remove_cvref) > # error "__has_builtin (__remove_cvref) failed" > #endif > +#if !__has_builtin (__is_unsigned) > +# error "__has_builtin (__is_unsigned) failed" > +#endif > diff --git a/gcc/testsuite/g++.dg/ext/is_unsigned.C b/gcc/testsuite/g++.d= g/ext/is_unsigned.C > new file mode 100644 > index 00000000000..2bb45d209a7 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_unsigned.C > @@ -0,0 +1,47 @@ > +// { dg-do compile { target c++11 } } > + > +#include > + > +using namespace __gnu_test; > + > +#define SA(X) static_assert((X),#X) > +#define SA_TEST_CATEGORY(TRAIT, X, expect) \ > + SA(TRAIT(X) =3D=3D expect); \ > + SA(TRAIT(const X) =3D=3D expect); \ > + SA(TRAIT(volatile X) =3D=3D expect); \ > + SA(TRAIT(const volatile X) =3D=3D expect) > + > +SA_TEST_CATEGORY(__is_unsigned, void, false); > + > +SA_TEST_CATEGORY(__is_unsigned, bool, (bool(-1) > bool(0))); > +SA_TEST_CATEGORY(__is_unsigned, char, (char(-1) > char(0))); > +SA_TEST_CATEGORY(__is_unsigned, signed char, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned char, true); > +SA_TEST_CATEGORY(__is_unsigned, wchar_t, (wchar_t(-1) > wchar_t(0))); > +SA_TEST_CATEGORY(__is_unsigned, short, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned short, true); > +SA_TEST_CATEGORY(__is_unsigned, int, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned int, true); > +SA_TEST_CATEGORY(__is_unsigned, long, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned long, true); > +SA_TEST_CATEGORY(__is_unsigned, long long, false); > +SA_TEST_CATEGORY(__is_unsigned, unsigned long long, true); > + > +SA_TEST_CATEGORY(__is_unsigned, float, false); > +SA_TEST_CATEGORY(__is_unsigned, double, false); > +SA_TEST_CATEGORY(__is_unsigned, long double, false); > + > +#ifndef __STRICT_ANSI__ > +// GNU Extensions. > +#ifdef __SIZEOF_INT128__ > +SA_TEST_CATEGORY(__is_unsigned, unsigned __int128, true); > +SA_TEST_CATEGORY(__is_unsigned, __int128, false); > +#endif > + > +#ifdef _GLIBCXX_USE_FLOAT128 > +SA_TEST_CATEGORY(__is_unsigned, __float128, false); > +#endif > +#endif > + > +// Sanity check. > +SA_TEST_CATEGORY(__is_unsigned, ClassType, false); > -- > 2.40.0 >