From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 8882D3860002 for ; Wed, 20 Dec 2023 17:14:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8882D3860002 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8882D3860002 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::330 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703092453; cv=none; b=PcShiOepneC+1i1IbvJ0ga/GBFqqDuiOOhNm5+BkIm7KeJNmt5NmIOHalKqKrQnWdSKSGcuoJn7m7maKOOsvvgzVCu8XhQ/Yv5xO82gvb1A8zK3Ii7xHYsvXPpo9UoCdDVUh1j+OEif1efgxipm0EBxqQky+98wMcEISdag8xjs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703092453; c=relaxed/simple; bh=K3QIO2B/qKaI3ruLYkR2bvE3Se9HUrdUE5rd98GXAH0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=UoVMVdgiuK8cMG9fFreirqpp/1InsBiLWWR69shQzp9Fx/dClryMkvTJr61cFq/vcibHfWQKnetyCiIwN6ITHUk3u2qBgJJWOox+6aOxu6XL4WaQojA0XuDBuHiCCWkyu+uiB2bmdBI0noWuMQjjcuGqKBrA1NgEUJFVV0YXbZw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-6d9f9fbfd11so4307825a34.2 for ; Wed, 20 Dec 2023 09:14:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1703092450; x=1703697250; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FU2tk0LzJJp5Q+QU4S9/n6NgpYdMimRr40Br7D9BfAo=; b=NNjRg+uyq21F4lFtG15DoModfzcxB5tl1HEk1OETYc4Zu/keFm2JRa5Dui8w4SRErq 2DqVBSie0MhlPi8SXOze7XQJcYe7+6VzM7eX8+eBQmOqaytSuVMR5x3dMNov8GMaRouA ou/tDnxnKjI+hkAxqmr4YeNXLX+yVmmVUHgFA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703092450; x=1703697250; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FU2tk0LzJJp5Q+QU4S9/n6NgpYdMimRr40Br7D9BfAo=; b=v92v8clc0Ax1JtxjeJV8uCjr0jG7MrB+rW5zoSO218W91zjBjuX5nTKQJhV643QgrR UZ/K2Q8GLnSVOtUYgW3ONNxpavHo6wVPNVvPKFgROpOEvAdSrA9P58NgqG+xGXvW+g3K LVvCDDsu1qKGFwCr7VjtQE+bX078fRrGBoeWwURSkm0eD71+P/ZNZ+gAggQ5/iNKFqWw /egMQOTFHX9HMm/xxK/VZxLE1ZK1NBtTYkji9prN6YC+9eijUeFsBpMiedbeisOCHqC+ 52XUPCNNohUU4VFdB7UNode6gZDaCe0IbUOHpAKXGhJix6wRjEWfba1byYIqK6aOEFtP 2/9Q== X-Gm-Message-State: AOJu0YwwPjI5zrCoCQuI5E0FqExyFwHuXa6Uv2UxF7Gz+/9232pv/STG 5X6TCVowkpg64B314GjmOShN695d9Pf33UX0Sg/p+A== X-Google-Smtp-Source: AGHT+IHpJncy1fVsM8gP7J4sQafiik/RWoRwf6KAoA9hax2CeAXcVlwCthiLwYBxpo8Hsiy0HHgXbtQzo56gPqOsb/Q= X-Received: by 2002:a05:6870:8306:b0:203:b858:feb7 with SMTP id p6-20020a056870830600b00203b858feb7mr31528oae.29.1703092449790; Wed, 20 Dec 2023 09:14:09 -0800 (PST) MIME-Version: 1.0 References: <20231024020424.699427-1-kmatsui@gcc.gnu.org> <20231207051513.969952-1-kmatsui@gcc.gnu.org> <136f0838-9c65-c7e4-3d8d-acf49d08d887@idea> In-Reply-To: <136f0838-9c65-c7e4-3d8d-acf49d08d887@idea> From: Ken Matsui Date: Wed, 20 Dec 2023 09:13:34 -0800 Message-ID: Subject: Re: [PATCH v26 00/23] Optimize type traits compilation performance To: Patrick Palka Cc: Sandra Loosemore , Ken Matsui , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 20, 2023 at 7:56=E2=80=AFAM Patrick Palka w= rote: > > On Tue, 19 Dec 2023, Sandra Loosemore wrote: > > > On 12/6/23 22:11, Ken Matsui wrote: > > > This patch series optimizes type traits compilation performance by > > > implementing built-in type traits and using them in libstdc++. > > > > I'm finding that all the new g++.dg/ext/is_*.C testcases added by this = patch > > series are failing due > > to the "#include ". If that is supposed to refer to t= he file > > of that name in the libstdc++ testcase, there's no gcc option being pas= sed to > > add that location to the include search path. That .h file includes ot= her > > header files from the libstdc++ testsuite so just copying it into the s= ame > > directory as the new g++ tests doesn't work. Can you fix this, somehow= ? > > Looks like the testcases only use the trivial definition of > __gnu_test::ClassType from the header, so perhaps we can just define it > locally and remove this header include (which IIUC is intended to be > used for library tests run by the libstdc++ test harness, not front-end > tests). > > Ken, do you want to submit a patch for that? (A full bootstrap + > regtest wouldn't be necessary, it should suffice to re-run the changed > tests via e.g. make check RUNTESTFLAGS=3D"dg.exp=3D*ext*") > Sure! Let me fix this problem :) > > > > Target is nios2-elf, if that matters. > > > > -Sandra > > > > >