From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id 35C513858D35 for ; Sat, 24 Jun 2023 14:18:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35C513858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-763dc87aac4so154540185a.2 for ; Sat, 24 Jun 2023 07:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1687616254; x=1690208254; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r+PZxQOoqJSqT5OQ/s3AvA/C+Aw3GcAyWXCEqtjh2AA=; b=eBnWdqadFnuomdQsCyoCN4iKRrQUeDs4l3iee7YKtbgpgZqx6Vitm4yUUy1jaBjlh1 c1HHE6tiOLCm63L+QDwcd3ke+l5pTBK588pGDSQyB2cx28EIS9WH4uJjdg7UOZi15nZz IT4rGDRIEk/PkprBiqAdAVxweefEpsmZKmIyc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687616254; x=1690208254; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r+PZxQOoqJSqT5OQ/s3AvA/C+Aw3GcAyWXCEqtjh2AA=; b=KD6lSbo3HpBrffMlleixd0KVGV+kOwWZqES2WPk5+Px1EnV4PZ4WBatTY9+tjYWsBh AVbAP1cl3le9sR6KU6RCnoWtlcSX8S60V7xYeVeJX4DUB12MiefgIvX7HMIwKrNfktyp UNZ9Er4CPVgG9/Ohsb122hsZQ9qsgjeepkbLSdsxd4jA4gpCtRGUYFwoB6T9EEGGYesx 9dhiReJIv2h4ddiidx7ErA/Zt/TQ8dd+5Y9mJmuOZVJat173rlRnQPEKwaM2PSpPKHr6 z7mGehYL2so9YHCDWtMp8h+ovu0AXFg3dwyde5bwd+r6Mnn8AzkGQW0hVYGS9mnasAgZ WM6Q== X-Gm-Message-State: AC+VfDwuxRUowEBkSGzD3BZ5GYiBOC83nVyASZl7v89bHUplp8ztWTgm MwGOYPnnjOhXpsrWL1tBh/5udgGccAq/SUDMHaGqKQ== X-Google-Smtp-Source: ACHHUZ78bV85F2DtjgwL3x3HV3NpraxWlBEJutkUjBMopQJt22OY9R4slT/45CLowR35PzwUb/PC1iOiEvmI50mrd24= X-Received: by 2002:a05:620a:4248:b0:75e:b8b2:864d with SMTP id w8-20020a05620a424800b0075eb8b2864dmr25702940qko.69.1687616253876; Sat, 24 Jun 2023 07:17:33 -0700 (PDT) MIME-Version: 1.0 References: <20230321223957.7176-1-kmatsui@cs.washington.edu> <20230624135348.74428-1-kmatsui@cs.washington.edu> In-Reply-To: <20230624135348.74428-1-kmatsui@cs.washington.edu> From: Ken Matsui Date: Sat, 24 Jun 2023 07:17:18 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] c++: implement __is_array built-in trait To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Here is the benchmark result for is_array: https://github.com/ken-matsui/gcc-benches/blob/main/is_array.md#sat-jun-24-= 070630-am-pdt-2023 Time: -15.511% Peak Memory Usage: +0.173923% Total Memory Usage: -6.2037% On Sat, Jun 24, 2023 at 6:54=E2=80=AFAM Ken Matsui wrote: > > This patch implements built-in trait for std::is_array. > > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_array. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_ARRAY. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_array. > * g++.dg/ext/is_array.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/constraint.cc | 3 +++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 ++++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > gcc/testsuite/g++.dg/ext/is_array.C | 28 ++++++++++++++++++++++++ > 5 files changed, 39 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_array.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index 8cf0f2d0974..7cec7eba591 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3751,6 +3751,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_UNION: > inform (loc, " %qT is not a union", t1); > break; > + case CPTK_IS_ARRAY: > + inform (loc, " %qT is not an array", t1); > + break; > case CPTK_IS_AGGREGATE: > inform (loc, " %qT is not an aggregate", t1); > break; > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 8b7fece0cc8..f68c7f2e8ec 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially= _assignable", 2) > DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible= ", -1) > DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) > DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) > +DEFTRAIT_EXPR (IS_ARRAY, "__is_array", 1) > DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_fr= om_temporary", 2) > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_t= emporary", 2) > /* FIXME Added space to avoid direct usage in GCC 13. */ > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 8fb47fd179e..22f2700ec0b 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12118,6 +12118,9 @@ trait_expr_value (cp_trait_kind kind, tree type1,= tree type2) > case CPTK_IS_UNION: > return type_code1 =3D=3D UNION_TYPE; > > + case CPTK_IS_ARRAY: > + return type_code1 =3D=3D ARRAY_TYPE; > + > case CPTK_IS_ASSIGNABLE: > return is_xible (MODIFY_EXPR, type1, type2); > > @@ -12296,6 +12299,7 @@ finish_trait_expr (location_t loc, cp_trait_kind = kind, tree type1, tree type2) > case CPTK_IS_ENUM: > case CPTK_IS_UNION: > case CPTK_IS_SAME: > + case CPTK_IS_ARRAY: > break; > > case CPTK_IS_LAYOUT_COMPATIBLE: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++= .dg/ext/has-builtin-1.C > index f343e153e56..56485ae62be 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -146,3 +146,6 @@ > #if !__has_builtin (__remove_cvref) > # error "__has_builtin (__remove_cvref) failed" > #endif > +#if !__has_builtin (__is_array) > +# error "__has_builtin (__is_array) failed" > +#endif > diff --git a/gcc/testsuite/g++.dg/ext/is_array.C b/gcc/testsuite/g++.dg/e= xt/is_array.C > new file mode 100644 > index 00000000000..facfed5c7cb > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_array.C > @@ -0,0 +1,28 @@ > +// { dg-do compile { target c++11 } } > + > +#include > + > +using namespace __gnu_test; > + > +#define SA(X) static_assert((X),#X) > +#define SA_TEST_CATEGORY(TRAIT, X, expect) \ > + SA(TRAIT(X) =3D=3D expect); \ > + SA(TRAIT(const X) =3D=3D expect); \ > + SA(TRAIT(volatile X) =3D=3D expect); \ > + SA(TRAIT(const volatile X) =3D=3D expect) > + > +SA_TEST_CATEGORY(__is_array, int[2], true); > +SA_TEST_CATEGORY(__is_array, int[], true); > +SA_TEST_CATEGORY(__is_array, int[2][3], true); > +SA_TEST_CATEGORY(__is_array, int[][3], true); > +SA_TEST_CATEGORY(__is_array, float*[2], true); > +SA_TEST_CATEGORY(__is_array, float*[], true); > +SA_TEST_CATEGORY(__is_array, float*[2][3], true); > +SA_TEST_CATEGORY(__is_array, float*[][3], true); > +SA_TEST_CATEGORY(__is_array, ClassType[2], true); > +SA_TEST_CATEGORY(__is_array, ClassType[], true); > +SA_TEST_CATEGORY(__is_array, ClassType[2][3], true); > +SA_TEST_CATEGORY(__is_array, ClassType[][3], true); > + > +// Sanity check. > +SA_TEST_CATEGORY(__is_array, ClassType, false); > -- > 2.41.0 >