From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by sourceware.org (Postfix) with ESMTPS id 0F4323858C31 for ; Sat, 24 Jun 2023 12:35:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F4323858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-vk1-xa2e.google.com with SMTP id 71dfb90a1353d-471c9f2f47aso508012e0c.3 for ; Sat, 24 Jun 2023 05:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1687610138; x=1690202138; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QoI6znsa5v/1mAD/tKnpvEgYEySbrEUzoLYXVaIhqso=; b=JMhr+Kdwsi+6AqrHa8QKbvmNschKzxHkZg/9c7DBUHg4CWXHImr8n2BRBGQdKkR7fI dWXQuKnoYcpS2HUBYTAAF+reMJ20WRjjItYl6i1xFErgMjah7dQQe8JyRojrs3eX+y0O fTWVqwUv108a9/lFO+dHJbGvnm6nxRSoQjjI0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687610138; x=1690202138; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QoI6znsa5v/1mAD/tKnpvEgYEySbrEUzoLYXVaIhqso=; b=TXrPzm/wMjvX1xgMKVYohwM9aGKxz737GG6JogHZMjHldVPhAjIYmV6Tw+nTw2zIcD 8CVV3GHXl3ZmJWN8OhDGPAFECxN3dcNo6P44F3g44ADm6LV0nSAbBPPg3Ce8s/f6gQYI hleJzqHZSDS9osJQpi7oDE8VOF1y8PTjxu1YwA/oVjiUFObEhetqOsxLonMWH+AU2N0H mdByFjKE55M7kh7x4oY9qRYWwu7hwgic4vSU4c2yuaXj6slv49yFA/q4ewC+XgBX6FEO zhoAJHGQEBeDgtb4/zN7p680QAglvjvvjeMaFL2BWisUm35syGhh3Jkl9PUhVj9vSven zENA== X-Gm-Message-State: AC+VfDwQF4OA2oIhTE4Z7KYDeJNQNPqls2tSKBzT7pkBGJ6tJagNGiD0 95Kzr8Y65rhq++i5LXukJFp3hNEMiGuc4me1arP3SVy7fCrTTN9z X-Google-Smtp-Source: ACHHUZ6tCmPkMjWBt/TadhSMzAOMyAmwKoPBdfdA1QRzRKKpTKtOo3lnPbyuB30tr0Hkk5Ji9RGAJtWi0xdD0PIFVpQ= X-Received: by 2002:a1f:4cc7:0:b0:476:4267:178c with SMTP id z190-20020a1f4cc7000000b004764267178cmr1749651vka.13.1687610138276; Sat, 24 Jun 2023 05:35:38 -0700 (PDT) MIME-Version: 1.0 References: <20230322001142.13422-1-kmatsui@cs.washington.edu> <20230624103848.68000-1-kmatsui@cs.washington.edu> <270cc948b2433f001ef3fb585520201752ac1a92.camel@xry111.site> In-Reply-To: <270cc948b2433f001ef3fb585520201752ac1a92.camel@xry111.site> From: Ken Matsui Date: Sat, 24 Jun 2023 05:35:27 -0700 Message-ID: Subject: Re: [PATCH 1/2] c++: implement __is_const built-in trait To: Xi Ruoyao Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000cfcec805fedf5a3d" X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000cfcec805fedf5a3d Content-Type: text/plain; charset="UTF-8" Sure. Thank you. On Sat, Jun 24, 2023 at 5:14 AM Xi Ruoyao wrote: > Please use [PATCH v3 1/2] next time, now it's not easy to find the > latest version of the series (I'm not sure if the number "3" is > correct). > > On Sat, 2023-06-24 at 03:38 -0700, Ken Matsui via Gcc-patches wrote: > > This patch implements built-in trait for std::is_const. > > > > gcc/cp/ChangeLog: > > > > * cp-trait.def: Define __is_const. > > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_CONST. > > * semantics.cc (trait_expr_value): Likewise. > > (finish_trait_expr): Likewise. > > > > gcc/testsuite/ChangeLog: > > > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_const. > > * g++.dg/ext/is_const.C: New test. > > > > Signed-off-by: Ken Matsui > > --- > > gcc/cp/constraint.cc | 3 +++ > > gcc/cp/cp-trait.def | 1 + > > gcc/cp/semantics.cc | 4 ++++ > > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > > gcc/testsuite/g++.dg/ext/is_const.C | 19 +++++++++++++++++++ > > 5 files changed, 30 insertions(+) > > create mode 100644 gcc/testsuite/g++.dg/ext/is_const.C > > > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > > index 8cf0f2d0974..ff4ae831def 100644 > > --- a/gcc/cp/constraint.cc > > +++ b/gcc/cp/constraint.cc > > @@ -3751,6 +3751,9 @@ diagnose_trait_expr (tree expr, tree args) > > case CPTK_IS_UNION: > > inform (loc, " %qT is not a union", t1); > > break; > > + case CPTK_IS_CONST: > > + inform (loc, " %qT is not a const type", t1); > > + break; > > case CPTK_IS_AGGREGATE: > > inform (loc, " %qT is not an aggregate", t1); > > break; > > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > > index 8b7fece0cc8..b40b475b86d 100644 > > --- a/gcc/cp/cp-trait.def > > +++ b/gcc/cp/cp-trait.def > > @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, > > "__is_trivially_assignable", 2) > > DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, > > "__is_trivially_constructible", -1) > > DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) > > DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) > > +DEFTRAIT_EXPR (IS_CONST, "__is_const", 1) > > DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, > > "__reference_constructs_from_temporary", 2) > > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, > > "__reference_converts_from_temporary", 2) > > /* FIXME Added space to avoid direct usage in GCC 13. */ > > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > > index 8fb47fd179e..011ba8e46e1 100644 > > --- a/gcc/cp/semantics.cc > > +++ b/gcc/cp/semantics.cc > > @@ -12079,6 +12079,9 @@ trait_expr_value (cp_trait_kind kind, tree > > type1, tree type2) > > case CPTK_IS_ENUM: > > return type_code1 == ENUMERAL_TYPE; > > > > + case CPTK_IS_CONST: > > + return CP_TYPE_CONST_P (type1); > > + > > case CPTK_IS_FINAL: > > return CLASS_TYPE_P (type1) && CLASSTYPE_FINAL (type1); > > > > @@ -12296,6 +12299,7 @@ finish_trait_expr (location_t loc, > > cp_trait_kind kind, tree type1, tree type2) > > case CPTK_IS_ENUM: > > case CPTK_IS_UNION: > > case CPTK_IS_SAME: > > + case CPTK_IS_CONST: > > break; > > > > case CPTK_IS_LAYOUT_COMPATIBLE: > > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > > b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > > index f343e153e56..965309a333a 100644 > > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > > @@ -146,3 +146,6 @@ > > #if !__has_builtin (__remove_cvref) > > # error "__has_builtin (__remove_cvref) failed" > > #endif > > +#if !__has_builtin (__is_const) > > +# error "__has_builtin (__is_const) failed" > > +#endif > > diff --git a/gcc/testsuite/g++.dg/ext/is_const.C > > b/gcc/testsuite/g++.dg/ext/is_const.C > > new file mode 100644 > > index 00000000000..8f2d7c2fce9 > > --- /dev/null > > +++ b/gcc/testsuite/g++.dg/ext/is_const.C > > @@ -0,0 +1,19 @@ > > +// { dg-do compile { target c++11 } } > > + > > +#include > > + > > +using namespace __gnu_test; > > + > > +#define SA(X) static_assert((X),#X) > > + > > +// Positive tests. > > +SA(__is_const(const int)); > > +SA(__is_const(const volatile int)); > > +SA(__is_const(cClassType)); > > +SA(__is_const(cvClassType)); > > + > > +// Negative tests. > > +SA(!__is_const(int)); > > +SA(!__is_const(volatile int)); > > +SA(!__is_const(ClassType)); > > +SA(!__is_const(vClassType)); > > -- > Xi Ruoyao > School of Aerospace Science and Technology, Xidian University > -- Sincerely, Ken Matsui --000000000000cfcec805fedf5a3d--