* Re: [PATCH] libstdc++: use new built-in trait __remove_pointer [not found] <CAML+3pW_2+9XTYMWEVHDyU8BKBpQEuGTkwmYVr+dcwUtzHVgsw@mail.gmail.com> @ 2023-03-20 7:31 ` Ken Matsui 2023-03-20 7:57 ` Jonathan Wakely 0 siblings, 1 reply; 6+ messages in thread From: Ken Matsui @ 2023-03-20 7:31 UTC (permalink / raw) To: gcc-patches; +Cc: Patrick Palka, libstdc++ CCing libstdc++@gcc.gnu.org. On Sun, Mar 19, 2023 at 7:53 PM Ken Matsui <kmatsui@cs.washington.edu> wrote: > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_reference): Use __remove_pointer built-in trait. > > --- > diff --git a/libstdc++-v3/include/std/type_traits > b/libstdc++-v3/include/std/type_traits > index 2bd607a8b8f..cba98091aad 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > template<typename _Tp, typename> > struct __remove_pointer_helper > - { typedef _Tp type; }; > + { using type = _Tp; }; > > template<typename _Tp, typename _Up> > struct __remove_pointer_helper<_Tp, _Up*> > - { typedef _Up type; }; > + { using type = _Up; }; > > /// remove_pointer > +#if __has_builtin(__remove_pointer) > + template<typename _Tp> > + struct remove_pointer > + { using type = __remove_pointer(_Tp); }; > +#else > template<typename _Tp> > struct remove_pointer > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> > { }; > +#endif > > template<typename _Tp, typename = void> > struct __add_pointer_helper ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libstdc++: use new built-in trait __remove_pointer 2023-03-20 7:31 ` [PATCH] libstdc++: use new built-in trait __remove_pointer Ken Matsui @ 2023-03-20 7:57 ` Jonathan Wakely 2023-03-20 8:07 ` Ken Matsui 0 siblings, 1 reply; 6+ messages in thread From: Jonathan Wakely @ 2023-03-20 7:57 UTC (permalink / raw) To: Ken Matsui; +Cc: gcc-patches, Patrick Palka, libstdc++ [-- Attachment #1: Type: text/plain, Size: 1596 bytes --] On Mon, 20 Mar 2023, 07:32 Ken Matsui via Libstdc++, <libstdc++@gcc.gnu.org> wrote: > CCing libstdc++@gcc.gnu.org. > > On Sun, Mar 19, 2023 at 7:53 PM Ken Matsui <kmatsui@cs.washington.edu> > wrote: > > > > libstdc++-v3/ChangeLog: > > > > * include/std/type_traits (is_reference): Use __remove_pointer built-in > trait. > The changelog entry says is_reference but the patch is for remove_pointer. > > > --- > > diff --git a/libstdc++-v3/include/std/type_traits > > b/libstdc++-v3/include/std/type_traits > > index 2bd607a8b8f..cba98091aad 100644 > > --- a/libstdc++-v3/include/std/type_traits > > +++ b/libstdc++-v3/include/std/type_traits > > @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > > template<typename _Tp, typename> > > struct __remove_pointer_helper > > - { typedef _Tp type; }; > > + { using type = _Tp; }; > > > > template<typename _Tp, typename _Up> > > struct __remove_pointer_helper<_Tp, _Up*> > > - { typedef _Up type; }; > > + { using type = _Up; }; > The helper doesn't need to be defined for the case where we don't use it. > > > /// remove_pointer > > +#if __has_builtin(__remove_pointer) > > + template<typename _Tp> > > + struct remove_pointer > > + { using type = __remove_pointer(_Tp); }; > > +#else > > template<typename _Tp> > > struct remove_pointer > > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> > > { }; > > +#endif > > > > template<typename _Tp, typename = void> > > struct __add_pointer_helper > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libstdc++: use new built-in trait __remove_pointer 2023-03-20 7:57 ` Jonathan Wakely @ 2023-03-20 8:07 ` Ken Matsui 2023-03-20 9:11 ` Jonathan Wakely 0 siblings, 1 reply; 6+ messages in thread From: Ken Matsui @ 2023-03-20 8:07 UTC (permalink / raw) To: Jonathan Wakely; +Cc: gcc-patches, Patrick Palka, libstdc++ Ooh... Thank you for pointing that out! > The helper doesn't need to be defined for the case where we don't use it. I thought that macroing them out leads to compiler errors since users are possibly using those helpers. But do we not have to care about that? --- libstdc++-v3/ChangeLog: * include/std/type_traits (remove_pointer): Use __remove_pointer built-in trait. --- diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 2bd607a8b8f..cba98091aad 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template<typename _Tp, typename> struct __remove_pointer_helper - { typedef _Tp type; }; + { using type = _Tp; }; template<typename _Tp, typename _Up> struct __remove_pointer_helper<_Tp, _Up*> - { typedef _Up type; }; + { using type = _Up; }; /// remove_pointer +#if __has_builtin(__remove_pointer) + template<typename _Tp> + struct remove_pointer + { using type = __remove_pointer(_Tp); }; +#else template<typename _Tp> struct remove_pointer : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> { }; +#endif template<typename _Tp, typename = void> struct __add_pointer_helper On Mon, Mar 20, 2023 at 12:57 AM Jonathan Wakely <jwakely.gcc@gmail.com> wrote: > > > > On Mon, 20 Mar 2023, 07:32 Ken Matsui via Libstdc++, <libstdc++@gcc.gnu.org> wrote: >> >> CCing libstdc++@gcc.gnu.org. >> >> On Sun, Mar 19, 2023 at 7:53 PM Ken Matsui <kmatsui@cs.washington.edu> wrote: >> > >> > libstdc++-v3/ChangeLog: >> > >> > * include/std/type_traits (is_reference): Use __remove_pointer built-in trait. > > > The changelog entry says is_reference but the patch is for remove_pointer. > > >> > >> > --- >> > diff --git a/libstdc++-v3/include/std/type_traits >> > b/libstdc++-v3/include/std/type_traits >> > index 2bd607a8b8f..cba98091aad 100644 >> > --- a/libstdc++-v3/include/std/type_traits >> > +++ b/libstdc++-v3/include/std/type_traits >> > @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >> > >> > template<typename _Tp, typename> >> > struct __remove_pointer_helper >> > - { typedef _Tp type; }; >> > + { using type = _Tp; }; >> > >> > template<typename _Tp, typename _Up> >> > struct __remove_pointer_helper<_Tp, _Up*> >> > - { typedef _Up type; }; >> > + { using type = _Up; }; > > > The helper doesn't need to be defined for the case where we don't use it. > > >> > >> > /// remove_pointer >> > +#if __has_builtin(__remove_pointer) >> > + template<typename _Tp> >> > + struct remove_pointer >> > + { using type = __remove_pointer(_Tp); }; >> > +#else >> > template<typename _Tp> >> > struct remove_pointer >> > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> >> > { }; >> > +#endif >> > >> > template<typename _Tp, typename = void> >> > struct __add_pointer_helper ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libstdc++: use new built-in trait __remove_pointer 2023-03-20 8:07 ` Ken Matsui @ 2023-03-20 9:11 ` Jonathan Wakely 2023-03-20 13:26 ` Ken Matsui 0 siblings, 1 reply; 6+ messages in thread From: Jonathan Wakely @ 2023-03-20 9:11 UTC (permalink / raw) To: Ken Matsui; +Cc: gcc-patches, Patrick Palka, libstdc++ On Mon, 20 Mar 2023 at 08:08, Ken Matsui <kmatsui@cs.washington.edu> wrote: > > Ooh... Thank you for pointing that out! > > > The helper doesn't need to be defined for the case where we don't use it. > > I thought that macroing them out leads to compiler errors since users > are possibly using those helpers. But do we not have to care about > that? No, absolutely not. > > --- > libstdc++-v3/ChangeLog: > > * include/std/type_traits (remove_pointer): Use __remove_pointer built-in trait. > > --- > diff --git a/libstdc++-v3/include/std/type_traits > b/libstdc++-v3/include/std/type_traits > index 2bd607a8b8f..cba98091aad 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > template<typename _Tp, typename> > struct __remove_pointer_helper > - { typedef _Tp type; }; > + { using type = _Tp; }; > > template<typename _Tp, typename _Up> > struct __remove_pointer_helper<_Tp, _Up*> > - { typedef _Up type; }; > + { using type = _Up; }; > > /// remove_pointer > +#if __has_builtin(__remove_pointer) > + template<typename _Tp> > + struct remove_pointer > + { using type = __remove_pointer(_Tp); }; > +#else > template<typename _Tp> > struct remove_pointer > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> > { }; > +#endif > > template<typename _Tp, typename = void> > struct __add_pointer_helper > > On Mon, Mar 20, 2023 at 12:57 AM Jonathan Wakely <jwakely.gcc@gmail.com> wrote: > > > > > > > > On Mon, 20 Mar 2023, 07:32 Ken Matsui via Libstdc++, <libstdc++@gcc.gnu.org> wrote: > >> > >> CCing libstdc++@gcc.gnu.org. > >> > >> On Sun, Mar 19, 2023 at 7:53 PM Ken Matsui <kmatsui@cs.washington.edu> wrote: > >> > > >> > libstdc++-v3/ChangeLog: > >> > > >> > * include/std/type_traits (is_reference): Use __remove_pointer built-in trait. > > > > > > The changelog entry says is_reference but the patch is for remove_pointer. > > > > > >> > > >> > --- > >> > diff --git a/libstdc++-v3/include/std/type_traits > >> > b/libstdc++-v3/include/std/type_traits > >> > index 2bd607a8b8f..cba98091aad 100644 > >> > --- a/libstdc++-v3/include/std/type_traits > >> > +++ b/libstdc++-v3/include/std/type_traits > >> > @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > >> > > >> > template<typename _Tp, typename> > >> > struct __remove_pointer_helper > >> > - { typedef _Tp type; }; > >> > + { using type = _Tp; }; > >> > > >> > template<typename _Tp, typename _Up> > >> > struct __remove_pointer_helper<_Tp, _Up*> > >> > - { typedef _Up type; }; > >> > + { using type = _Up; }; > > > > > > The helper doesn't need to be defined for the case where we don't use it. > > > > > >> > > >> > /// remove_pointer > >> > +#if __has_builtin(__remove_pointer) > >> > + template<typename _Tp> > >> > + struct remove_pointer > >> > + { using type = __remove_pointer(_Tp); }; > >> > +#else > >> > template<typename _Tp> > >> > struct remove_pointer > >> > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> > >> > { }; > >> > +#endif > >> > > >> > template<typename _Tp, typename = void> > >> > struct __add_pointer_helper ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libstdc++: use new built-in trait __remove_pointer 2023-03-20 9:11 ` Jonathan Wakely @ 2023-03-20 13:26 ` Ken Matsui 2023-03-20 22:24 ` Ken Matsui 0 siblings, 1 reply; 6+ messages in thread From: Ken Matsui @ 2023-03-20 13:26 UTC (permalink / raw) To: Jonathan Wakely; +Cc: gcc-patches, Patrick Palka, libstdc++ [-- Attachment #1: Type: text/plain, Size: 3729 bytes --] Thank you! On Mon, Mar 20, 2023 at 2:12 AM Jonathan Wakely <jwakely.gcc@gmail.com> wrote: > On Mon, 20 Mar 2023 at 08:08, Ken Matsui <kmatsui@cs.washington.edu> > wrote: > > > > Ooh... Thank you for pointing that out! > > > > > The helper doesn't need to be defined for the case where we don't use > it. > > > > I thought that macroing them out leads to compiler errors since users > > are possibly using those helpers. But do we not have to care about > > that? > > No, absolutely not. > > > > > --- > > libstdc++-v3/ChangeLog: > > > > * include/std/type_traits (remove_pointer): Use __remove_pointer > built-in trait. > > > > --- > > diff --git a/libstdc++-v3/include/std/type_traits > > b/libstdc++-v3/include/std/type_traits > > index 2bd607a8b8f..cba98091aad 100644 > > --- a/libstdc++-v3/include/std/type_traits > > +++ b/libstdc++-v3/include/std/type_traits > > @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > > template<typename _Tp, typename> > > struct __remove_pointer_helper > > - { typedef _Tp type; }; > > + { using type = _Tp; }; > > > > template<typename _Tp, typename _Up> > > struct __remove_pointer_helper<_Tp, _Up*> > > - { typedef _Up type; }; > > + { using type = _Up; }; > > > > /// remove_pointer > > +#if __has_builtin(__remove_pointer) > > + template<typename _Tp> > > + struct remove_pointer > > + { using type = __remove_pointer(_Tp); }; > > +#else > > template<typename _Tp> > > struct remove_pointer > > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> > > { }; > > +#endif > > > > template<typename _Tp, typename = void> > > struct __add_pointer_helper > > > > On Mon, Mar 20, 2023 at 12:57 AM Jonathan Wakely <jwakely.gcc@gmail.com> > wrote: > > > > > > > > > > > > On Mon, 20 Mar 2023, 07:32 Ken Matsui via Libstdc++, < > libstdc++@gcc.gnu.org> wrote: > > >> > > >> CCing libstdc++@gcc.gnu.org. > > >> > > >> On Sun, Mar 19, 2023 at 7:53 PM Ken Matsui <kmatsui@cs.washington.edu> > wrote: > > >> > > > >> > libstdc++-v3/ChangeLog: > > >> > > > >> > * include/std/type_traits (is_reference): Use __remove_pointer > built-in trait. > > > > > > > > > The changelog entry says is_reference but the patch is for > remove_pointer. > > > > > > > > >> > > > >> > --- > > >> > diff --git a/libstdc++-v3/include/std/type_traits > > >> > b/libstdc++-v3/include/std/type_traits > > >> > index 2bd607a8b8f..cba98091aad 100644 > > >> > --- a/libstdc++-v3/include/std/type_traits > > >> > +++ b/libstdc++-v3/include/std/type_traits > > >> > @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > >> > > > >> > template<typename _Tp, typename> > > >> > struct __remove_pointer_helper > > >> > - { typedef _Tp type; }; > > >> > + { using type = _Tp; }; > > >> > > > >> > template<typename _Tp, typename _Up> > > >> > struct __remove_pointer_helper<_Tp, _Up*> > > >> > - { typedef _Up type; }; > > >> > + { using type = _Up; }; > > > > > > > > > The helper doesn't need to be defined for the case where we don't use > it. > > > > > > > > >> > > > >> > /// remove_pointer > > >> > +#if __has_builtin(__remove_pointer) > > >> > + template<typename _Tp> > > >> > + struct remove_pointer > > >> > + { using type = __remove_pointer(_Tp); }; > > >> > +#else > > >> > template<typename _Tp> > > >> > struct remove_pointer > > >> > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> > > >> > { }; > > >> > +#endif > > >> > > > >> > template<typename _Tp, typename = void> > > >> > struct __add_pointer_helper > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libstdc++: use new built-in trait __remove_pointer 2023-03-20 13:26 ` Ken Matsui @ 2023-03-20 22:24 ` Ken Matsui 0 siblings, 0 replies; 6+ messages in thread From: Ken Matsui @ 2023-03-20 22:24 UTC (permalink / raw) To: Jonathan Wakely; +Cc: gcc-patches, Patrick Palka, libstdc++ [-- Attachment #1: Type: text/plain, Size: 3976 bytes --] Please disregard this email. On Mon, Mar 20, 2023 at 6:26 AM Ken Matsui <kmatsui@cs.washington.edu> wrote: > Thank you! > > On Mon, Mar 20, 2023 at 2:12 AM Jonathan Wakely <jwakely.gcc@gmail.com> > wrote: > >> On Mon, 20 Mar 2023 at 08:08, Ken Matsui <kmatsui@cs.washington.edu> >> wrote: >> > >> > Ooh... Thank you for pointing that out! >> > >> > > The helper doesn't need to be defined for the case where we don't use >> it. >> > >> > I thought that macroing them out leads to compiler errors since users >> > are possibly using those helpers. But do we not have to care about >> > that? >> >> No, absolutely not. >> >> > >> > --- >> > libstdc++-v3/ChangeLog: >> > >> > * include/std/type_traits (remove_pointer): Use __remove_pointer >> built-in trait. >> > >> > --- >> > diff --git a/libstdc++-v3/include/std/type_traits >> > b/libstdc++-v3/include/std/type_traits >> > index 2bd607a8b8f..cba98091aad 100644 >> > --- a/libstdc++-v3/include/std/type_traits >> > +++ b/libstdc++-v3/include/std/type_traits >> > @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >> > >> > template<typename _Tp, typename> >> > struct __remove_pointer_helper >> > - { typedef _Tp type; }; >> > + { using type = _Tp; }; >> > >> > template<typename _Tp, typename _Up> >> > struct __remove_pointer_helper<_Tp, _Up*> >> > - { typedef _Up type; }; >> > + { using type = _Up; }; >> > >> > /// remove_pointer >> > +#if __has_builtin(__remove_pointer) >> > + template<typename _Tp> >> > + struct remove_pointer >> > + { using type = __remove_pointer(_Tp); }; >> > +#else >> > template<typename _Tp> >> > struct remove_pointer >> > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> >> > { }; >> > +#endif >> > >> > template<typename _Tp, typename = void> >> > struct __add_pointer_helper >> > >> > On Mon, Mar 20, 2023 at 12:57 AM Jonathan Wakely <jwakely.gcc@gmail.com> >> wrote: >> > > >> > > >> > > >> > > On Mon, 20 Mar 2023, 07:32 Ken Matsui via Libstdc++, < >> libstdc++@gcc.gnu.org> wrote: >> > >> >> > >> CCing libstdc++@gcc.gnu.org. >> > >> >> > >> On Sun, Mar 19, 2023 at 7:53 PM Ken Matsui < >> kmatsui@cs.washington.edu> wrote: >> > >> > >> > >> > libstdc++-v3/ChangeLog: >> > >> > >> > >> > * include/std/type_traits (is_reference): Use __remove_pointer >> built-in trait. >> > > >> > > >> > > The changelog entry says is_reference but the patch is for >> remove_pointer. >> > > >> > > >> > >> > >> > >> > --- >> > >> > diff --git a/libstdc++-v3/include/std/type_traits >> > >> > b/libstdc++-v3/include/std/type_traits >> > >> > index 2bd607a8b8f..cba98091aad 100644 >> > >> > --- a/libstdc++-v3/include/std/type_traits >> > >> > +++ b/libstdc++-v3/include/std/type_traits >> > >> > @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >> > >> > >> > >> > template<typename _Tp, typename> >> > >> > struct __remove_pointer_helper >> > >> > - { typedef _Tp type; }; >> > >> > + { using type = _Tp; }; >> > >> > >> > >> > template<typename _Tp, typename _Up> >> > >> > struct __remove_pointer_helper<_Tp, _Up*> >> > >> > - { typedef _Up type; }; >> > >> > + { using type = _Up; }; >> > > >> > > >> > > The helper doesn't need to be defined for the case where we don't use >> it. >> > > >> > > >> > >> > >> > >> > /// remove_pointer >> > >> > +#if __has_builtin(__remove_pointer) >> > >> > + template<typename _Tp> >> > >> > + struct remove_pointer >> > >> > + { using type = __remove_pointer(_Tp); }; >> > >> > +#else >> > >> > template<typename _Tp> >> > >> > struct remove_pointer >> > >> > : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>> >> > >> > { }; >> > >> > +#endif >> > >> > >> > >> > template<typename _Tp, typename = void> >> > >> > struct __add_pointer_helper >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-20 22:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAML+3pW_2+9XTYMWEVHDyU8BKBpQEuGTkwmYVr+dcwUtzHVgsw@mail.gmail.com>
2023-03-20 7:31 ` [PATCH] libstdc++: use new built-in trait __remove_pointer Ken Matsui
2023-03-20 7:57 ` Jonathan Wakely
2023-03-20 8:07 ` Ken Matsui
2023-03-20 9:11 ` Jonathan Wakely
2023-03-20 13:26 ` Ken Matsui
2023-03-20 22:24 ` Ken Matsui
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).