From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa36.google.com (mail-vk1-xa36.google.com [IPv6:2607:f8b0:4864:20::a36]) by sourceware.org (Postfix) with ESMTPS id E122D3858C62 for ; Sat, 24 Jun 2023 15:13:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E122D3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-vk1-xa36.google.com with SMTP id 71dfb90a1353d-4718f761333so665849e0c.0 for ; Sat, 24 Jun 2023 08:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1687619583; x=1690211583; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=StbcTgVcq3zPg1dcB7ELdUHumxKsmgiQZHy+SY3tLtU=; b=Cu0x/UuJ+BnxJpqFemUequO1kbtzw+LazchZ2oDY+XT/vSPGI7YbxDro3yGXA0EcVu oKF/BCm3Lt0q7CFPByzixVp1ssLuIuMe9A6PHR44Ya2R8CtMXJt0puzrMPjJdGV8dGuw 2UMJBgJCem+6Y59yeCCczcvQ9nYWFVgdUrlUo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687619583; x=1690211583; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=StbcTgVcq3zPg1dcB7ELdUHumxKsmgiQZHy+SY3tLtU=; b=ZH/ePml5cQUqtRGc6MVhPdgetJyY9WBnaFuVjA8+oU5wAsqOYUURJ1gD+laeJYuprn 8ISi9VYmmAPmD4QEFhegZwvQ5GYZFLCACGGww7tM7WZEB+ru4s+BYSKTI9bc5M0Wq0I9 KpDjRqoOzr+9nd5UjxktM2b5DkSXgn+itm+10fESNb/RGgFMV04RENzcKaDONh4aRtcE KS5rhd6LK48ohYUExcTIt1KGrXo99VzXROkvreLBjgAduCUVBAcEkyOmAep/wMRslzQ8 5Vj8kno8WZ+epDVUtJb6z5/+h/wjsr4Dl206gFllKbT799F4eT5Zh2pYJ9xpY5wEtoUW ZsMg== X-Gm-Message-State: AC+VfDx2nPwoGLmqk0jIa8ae9hz//mHJM/wHYZMBMaobiegoaC6JVEf5 TQ+kKJypMwhCm28zZvUP/PV2BcX9lXk0KG3KtKaC0/SQI9Oa6lplZnw= X-Google-Smtp-Source: ACHHUZ6FGm/dwXUc4fDNM21Marg8ktjEH/vhJ+yXXp4S0cqACunsHnyggLlVqq97Z42CT48Qc7aInXhifgiHsBm7zCQ= X-Received: by 2002:a1f:450a:0:b0:471:5103:9bde with SMTP id s10-20020a1f450a000000b0047151039bdemr12308355vka.7.1687619583171; Sat, 24 Jun 2023 08:13:03 -0700 (PDT) MIME-Version: 1.0 References: <20230612224109.20749-1-kmatsui@cs.washington.edu> <20230612224909.21188-1-kmatsui@cs.washington.edu> In-Reply-To: From: Ken Matsui Date: Sat, 24 Jun 2023 08:12:47 -0700 Message-ID: Subject: Re: [PATCH v7 0/6] c++, libstdc++: get std::is_object to dispatch to new built-in traits To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jun 20, 2023 at 8:32=E2=80=AFAM Patrick Palka w= rote: > > On Thu, 15 Jun 2023, Ken Matsui via Libstdc++ wrote: > > > Hi, > > > > For those curious about the performance improvements of this patch, I > > conducted a benchmark that instantiates 256k specializations of > > is_object_v based on Patrick's code. You can find the benchmark code > > at this link: > > > > https://github.com/ken-matsui/gcc-benches/blob/main/is_object_benchmark= .cc > > > > On my computer, using the gcc HEAD of this patch for a release build, > > the patch with -DUSE_BUILTIN took 64% less time and used 44-47% less > > memory compared to not using it. > > That's more like it :D Though the benchmark should also invoke the > trait on non-object types too, e.g. Instantiator& or Instantiator(int). Here is the updated benchmark: https://github.com/ken-matsui/gcc-benches/blob/main/is_object.md#sat-jun-24= -080110-am-pdt-2023 Time: -74.7544% Peak Memory Usage: -62.5913% Total Memory Usage: -64.2708% > > > > Sincerely, > > Ken Matsui > > > > On Mon, Jun 12, 2023 at 3:49=E2=80=AFPM Ken Matsui wrote: > > > > > > Hi, > > > > > > This patch series gets std::is_object to dispatch to built-in traits = and > > > implements the following built-in traits, on which std::object depend= s. > > > > > > * __is_reference > > > * __is_function > > > * __is_void > > > > > > std::is_object was depending on them with disjunction and negation. > > > > > > __not_<__or_, is_reference<_Tp>, is_void<_Tp>>>::typ= e > > > > > > Therefore, this patch uses them directly instead of implementing an a= dditional > > > built-in trait __is_object, which makes the compiler slightly bigger = and > > > slower. > > > > > > __bool_constant > > > > > > This would instantiate only __bool_constant and __bool_constant= , > > > which can be mostly shared. That is, the purpose of built-in traits i= s > > > considered as achieved. > > > > > > Changes in v7 > > > > > > * Removed an unnecessary new line. > > > > > > Ken Matsui (6): > > > c++: implement __is_reference built-in trait > > > libstdc++: use new built-in trait __is_reference for std::is_refere= nce > > > c++: implement __is_function built-in trait > > > libstdc++: use new built-in trait __is_function for std::is_functio= n > > > c++, libstdc++: implement __is_void built-in trait > > > libstdc++: make std::is_object dispatch to new built-in traits > > > > > > gcc/cp/constraint.cc | 9 +++ > > > gcc/cp/cp-trait.def | 3 + > > > gcc/cp/semantics.cc | 12 ++++ > > > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 9 +++ > > > gcc/testsuite/g++.dg/ext/is_function.C | 58 +++++++++++++++++= ++ > > > gcc/testsuite/g++.dg/ext/is_reference.C | 34 +++++++++++ > > > gcc/testsuite/g++.dg/ext/is_void.C | 35 +++++++++++ > > > gcc/testsuite/g++.dg/tm/pr46567.C | 6 +- > > > libstdc++-v3/include/bits/cpp_type_traits.h | 15 ----- > > > libstdc++-v3/include/debug/helper_functions.h | 5 +- > > > libstdc++-v3/include/std/type_traits | 51 ++++++++++++++++ > > > 11 files changed, 216 insertions(+), 21 deletions(-) > > > create mode 100644 gcc/testsuite/g++.dg/ext/is_function.C > > > create mode 100644 gcc/testsuite/g++.dg/ext/is_reference.C > > > create mode 100644 gcc/testsuite/g++.dg/ext/is_void.C > > > > > > -- > > > 2.41.0 > > > > > > >