From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by sourceware.org (Postfix) with ESMTPS id ACCF6385702F for ; Mon, 16 Oct 2023 20:26:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACCF6385702F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ACCF6385702F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::934 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697487995; cv=none; b=hqKvxsixH8Or2YCDRVhyFkiqliIQ7BC16XHEUeNDAJY20eqX/6v+a1oNtiIzhgxpKCzmBPvwytdk5gRRFsiPVfObq+kiKFYehdLkeXoNVAJWEWajnVrnRgZcXGOX4LI5of7RgqbQ14jxdguwSjy/NCx1drLs6efUFScR6LF8EOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697487995; c=relaxed/simple; bh=R4+tOo9FThQT4+rYE0ofYz9iCfKfmT4MG9uHpXqNzic=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ZpMznfl64ROKUjX67ihEpojdIcgCJFrgNoYRSpaOEWskGrDxqvkiSinuFA726dgsKuhAHuMtA8nGczPzPUUBEHA9dJltn22FcryTEu16YUpCjvlPDdUan9ukM2i3VFjkyQ8JqZLruA2FL/OaZhS/UYezFZMzAddF37uhwIhwsjs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ua1-x934.google.com with SMTP id a1e0cc1a2514c-7ae19da7b79so1867091241.2 for ; Mon, 16 Oct 2023 13:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1697487992; x=1698092792; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cpzkZC3QvgULBaPEinwHgFGWad4u4dcgQYYCJbNXEJE=; b=F7jMVXFuHx5MSjhskciQpD9Wc88q2XCq08cnGWyilInVDw0S9TwHn9GcCzgwFYNCVW 2fVEJOnk/vO+mqFxTYEHe1Q++U3N/O7SVj0t4RTpFXQKm1kDTyX6KSqFR46KOsC0XdXo fJpZYb8n7lEft8WlHDtsU+GWUGqFhLApc3T2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697487992; x=1698092792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cpzkZC3QvgULBaPEinwHgFGWad4u4dcgQYYCJbNXEJE=; b=nDqg02VpYSmtD9v0jh/BrbH74DbrnaJrxm1ZD9fLgU+CPsa/ifT6T43lJnQzTFeuQV gRDRSoBI6NJpviQvAyNYHqw+KbPfzQQn+g7y539W0sER5jXa4tei6d4AnFGbobYngJMq 4gsOd0gkjVZaNccm29LP3fYrKnDB2fDvh+pS2PTUV1sGg5tC91WbaUL6G01NUHXPBqiL lIa1ucTxMrvvJs+8eFMHvVAUHF3A4v2nd2KPKRiyQJRbBAsLmb5Apc4cuy04B7RGsZOB BTsrJhQJKV0MMoJpbjXL3/pMUqhXfoLKTdEbYTKxv5T80l1n8X5E1pEKsidqjMg3pVim SjBQ== X-Gm-Message-State: AOJu0YzMOCAA91YjwlQ92XYEEfI891Ec9v+hY3r6LftN7ueQmc5S1BLv F7wQxIqwO7QvHU6xKrfZAnB+HFcuCwIvQPCpBJjlaA== X-Google-Smtp-Source: AGHT+IGEPDfXOs9f0pICJembtCFEMqMHl0tH7lbiCgU6vyV5h0jR8zInuWe186kzrbaepWS6AZR4ApJKudKkz2k5GHk= X-Received: by 2002:a05:6102:2006:b0:452:85eb:e36d with SMTP id p6-20020a056102200600b0045285ebe36dmr471322vsr.20.1697487991975; Mon, 16 Oct 2023 13:26:31 -0700 (PDT) MIME-Version: 1.0 References: <20231013223957.1634024-1-kmatsui@gcc.gnu.org> <20231016001227.2717180-1-kmatsui@gcc.gnu.org> <20231016001227.2717180-32-kmatsui@gcc.gnu.org> In-Reply-To: From: Ken Matsui Date: Mon, 16 Oct 2023 13:25:55 -0700 Message-ID: Subject: Re: [PATCH v20 31/40] c++: Implement __is_arithmetic built-in trait To: Patrick Palka Cc: Ken Matsui , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 16, 2023 at 10:16=E2=80=AFAM Patrick Palka = wrote: > > On Sun, 15 Oct 2023, Ken Matsui wrote: > > > This patch implements built-in trait for std::is_arithmetic. > > > > gcc/cp/ChangeLog: > > > > * cp-trait.def: Define __is_arithmetic. > > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_ARITHMETIC. > > * semantics.cc (trait_expr_value): Likewise. > > (finish_trait_expr): Likewise. > > > > gcc/testsuite/ChangeLog: > > > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_arithmetic. > > * g++.dg/ext/is_arithmetic.C: New test. > > > > Signed-off-by: Ken Matsui > > --- > > gcc/cp/constraint.cc | 3 +++ > > gcc/cp/cp-trait.def | 1 + > > gcc/cp/semantics.cc | 4 +++ > > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > > gcc/testsuite/g++.dg/ext/is_arithmetic.C | 33 ++++++++++++++++++++++++ > > 5 files changed, 44 insertions(+) > > create mode 100644 gcc/testsuite/g++.dg/ext/is_arithmetic.C > > > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > > index c9d627fa782..3a7f968eae8 100644 > > --- a/gcc/cp/constraint.cc > > +++ b/gcc/cp/constraint.cc > > @@ -3714,6 +3714,9 @@ diagnose_trait_expr (tree expr, tree args) > > case CPTK_IS_AGGREGATE: > > inform (loc, " %qT is not an aggregate", t1); > > break; > > + case CPTK_IS_ARITHMETIC: > > + inform (loc, " %qT is not an arithmetic type", t1); > > + break; > > case CPTK_IS_ARRAY: > > inform (loc, " %qT is not an array", t1); > > break; > > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > > index c60724e869e..b2be7b7bbd7 100644 > > --- a/gcc/cp/cp-trait.def > > +++ b/gcc/cp/cp-trait.def > > @@ -59,6 +59,7 @@ DEFTRAIT_EXPR (HAS_UNIQUE_OBJ_REPRESENTATIONS, "__has= _unique_object_representati > > DEFTRAIT_EXPR (HAS_VIRTUAL_DESTRUCTOR, "__has_virtual_destructor", 1) > > DEFTRAIT_EXPR (IS_ABSTRACT, "__is_abstract", 1) > > DEFTRAIT_EXPR (IS_AGGREGATE, "__is_aggregate", 1) > > +DEFTRAIT_EXPR (IS_ARITHMETIC, "__is_arithmetic", 1) > > DEFTRAIT_EXPR (IS_ARRAY, "__is_array", 1) > > DEFTRAIT_EXPR (IS_ASSIGNABLE, "__is_assignable", 2) > > DEFTRAIT_EXPR (IS_BASE_OF, "__is_base_of", 2) > > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > > index 83ed674b9d4..deab0134509 100644 > > --- a/gcc/cp/semantics.cc > > +++ b/gcc/cp/semantics.cc > > @@ -12143,6 +12143,9 @@ trait_expr_value (cp_trait_kind kind, tree type= 1, tree type2) > > case CPTK_IS_AGGREGATE: > > return CP_AGGREGATE_TYPE_P (type1); > > > > + case CPTK_IS_ARITHMETIC: > > + return ARITHMETIC_TYPE_P (type1); > > + > > For built-ins corresponding to is_arithmetic and other standard traits > defined in terms of it (e.g. is_scalar, is_unsigned, is_signed, > is_fundamental) we need to make sure we preserve their behavior for > __int128, which IIUC is currently recognized as an integral type > (according to std::is_integral) only in GNU mode. > > This'll probably be subtle to get right, so if you don't mind let's > split out the work for those built-in traits into a separate patch > series in order to ease review of the main patch series. > I agree. I am postponing work on integral-related traits, so isolating non-ready-for-review patches makes a lot of sense. > > case CPTK_IS_ARRAY: > > return type_code1 =3D=3D ARRAY_TYPE; > > > > @@ -12406,6 +12409,7 @@ finish_trait_expr (location_t loc, cp_trait_kin= d kind, tree type1, tree type2) > > return error_mark_node; > > break; > > > > + case CPTK_IS_ARITHMETIC: > > case CPTK_IS_ARRAY: > > case CPTK_IS_BOUNDED_ARRAY: > > case CPTK_IS_CLASS: > > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g= ++.dg/ext/has-builtin-1.C > > index efce04fd09d..4bc85f4babb 100644 > > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > > @@ -56,6 +56,9 @@ > > #if !__has_builtin (__is_aggregate) > > # error "__has_builtin (__is_aggregate) failed" > > #endif > > +#if !__has_builtin (__is_arithmetic) > > +# error "__has_builtin (__is_arithmetic) failed" > > +#endif > > #if !__has_builtin (__is_array) > > # error "__has_builtin (__is_array) failed" > > #endif > > diff --git a/gcc/testsuite/g++.dg/ext/is_arithmetic.C b/gcc/testsuite/g= ++.dg/ext/is_arithmetic.C > > new file mode 100644 > > index 00000000000..fd35831f646 > > --- /dev/null > > +++ b/gcc/testsuite/g++.dg/ext/is_arithmetic.C > > @@ -0,0 +1,33 @@ > > +// { dg-do compile { target c++11 } } > > + > > +#include > > + > > +using namespace __gnu_test; > > + > > +#define SA(X) static_assert((X),#X) > > +#define SA_TEST_CATEGORY(TRAIT, TYPE, EXPECT) \ > > + SA(TRAIT(TYPE) =3D=3D EXPECT); \ > > + SA(TRAIT(const TYPE) =3D=3D EXPECT); \ > > + SA(TRAIT(volatile TYPE) =3D=3D EXPECT); \ > > + SA(TRAIT(const volatile TYPE) =3D=3D EXPECT) > > + > > +SA_TEST_CATEGORY(__is_arithmetic, void, false); > > + > > +SA_TEST_CATEGORY(__is_arithmetic, char, true); > > +SA_TEST_CATEGORY(__is_arithmetic, signed char, true); > > +SA_TEST_CATEGORY(__is_arithmetic, unsigned char, true); > > +SA_TEST_CATEGORY(__is_arithmetic, wchar_t, true); > > +SA_TEST_CATEGORY(__is_arithmetic, short, true); > > +SA_TEST_CATEGORY(__is_arithmetic, unsigned short, true); > > +SA_TEST_CATEGORY(__is_arithmetic, int, true); > > +SA_TEST_CATEGORY(__is_arithmetic, unsigned int, true); > > +SA_TEST_CATEGORY(__is_arithmetic, long, true); > > +SA_TEST_CATEGORY(__is_arithmetic, unsigned long, true); > > +SA_TEST_CATEGORY(__is_arithmetic, long long, true); > > +SA_TEST_CATEGORY(__is_arithmetic, unsigned long long, true); > > +SA_TEST_CATEGORY(__is_arithmetic, float, true); > > +SA_TEST_CATEGORY(__is_arithmetic, double, true); > > +SA_TEST_CATEGORY(__is_arithmetic, long double, true); > > + > > +// Sanity check. > > +SA_TEST_CATEGORY(__is_arithmetic, ClassType, false); > > -- > > 2.42.0 > > > > >