From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by sourceware.org (Postfix) with ESMTPS id BD6CF385AE54 for ; Sat, 16 Dec 2023 16:57:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD6CF385AE54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD6CF385AE54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702745837; cv=none; b=xlmrqkyWuuJF6vMrqZMxQXYxeZMfmD/O3yTd/lPxdJ+8KZpxXLlBeYrwoPppZckqj11HDy6eqFKQrn6doDN80f4/zHQ8wYFarSoIqQzppQkK9G/vsh/OEgx2UDpRJpPWRjQCxDW4zHgfAYT524OBMxZU8+6fOvVY5AQ5Jew1Jj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702745837; c=relaxed/simple; bh=AMI2XDgkQXMdCeyoHIrTd+PwhNEZ2cp6IYstEYBNRzY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ASGrrow/pDkLlZNVuguoHp0hAPv/ukJyZLCGEyWlhjEubVK91gfc62y+KmgjqPFPYTBGzTJvMRC6kSb5TQ56SMTRcBrsRpmOdVJMRhEppJcdD5fxOkWYZeU4tEQiP4l4MnXqgeMNCIdGoiRlS1l6VSww902jPDqTIzeSgclg1Qk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-590b3337d2bso1275784eaf.2 for ; Sat, 16 Dec 2023 08:57:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1702745834; x=1703350634; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EDkMnPIv6jTO7tvvrJ0vK0/VhxxdgYvxXb8qbwd9SBo=; b=W434WyJ1FqlqfaRG+14mfHNP95u0AQTtZ/uqAXTELWe1wzFZOX4D3V417QQ8IoaxZT 47Ybgv75RDuBdS35+OpwOGPduTFZuTmYXEtruNET89kGpJWJwyOddYMGavQlzrue7BV0 RY91rCD6podKJXr4cD+Q2ojtcbBxuA48MrWOs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702745834; x=1703350634; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EDkMnPIv6jTO7tvvrJ0vK0/VhxxdgYvxXb8qbwd9SBo=; b=vDUJdLUHlkpWM6N4KJdOf7xuHqy4zyvjxWO1lo0iHcNMDVnULgFL7Lsp4pcROsBf7j MEx+E6JXjeM0/x9zBtqjyn9Fb0LPAZnFAZUypmtj8aeM7MIQkMn6xL6z4q/6DG7GPaXk ZSN3NEPQm9dk4bW94itV9T4v5+wnlX44V7HH3VLSbX+jQpmn7bX5zCssfcKuhERMjdRR D+ZREmgphLFcH3h05J0zETCq8JhVnr/2BlJce+u7k3A+y8hkgpLvi0O02KhPcuTLYgaW D1DBl96VMLmZuEy6U8t4mXkSK+Z5rniIXsMCOgl1YGDcKsmahIX5e2J7miwHNQVwe1GC YtOQ== X-Gm-Message-State: AOJu0Yzkd04/w6VwqzQ5QL8gGJU3E4Ajupq9x97qNLRraBX5LAMiVcXq TRHuEzjtMPw2rxsOXOFIaheVqQvvOhESWjKSUQ8+Cw== X-Google-Smtp-Source: AGHT+IF4tB06x/a0iS78SxGiqQQBbXyoaN8TvFEzqFfRh/3ucJQ3c88HBwEegpf7AE+SsTZ2HO2yOvryO57UpAH+J9o= X-Received: by 2002:a05:6808:bcf:b0:3b9:dadc:5558 with SMTP id o15-20020a0568080bcf00b003b9dadc5558mr18356972oik.16.1702745834176; Sat, 16 Dec 2023 08:57:14 -0800 (PST) MIME-Version: 1.0 References: <20231024020424.699427-1-kmatsui@gcc.gnu.org> <20231207051513.969952-1-kmatsui@gcc.gnu.org> <72a53d86-b4d8-4321-9e75-fe1f16099887@redhat.com> In-Reply-To: From: Ken Matsui Date: Sat, 16 Dec 2023 08:56:38 -0800 Message-ID: Subject: Re: [PATCH v26 00/23] Optimize type traits compilation performance To: Jonathan Wakely Cc: Jason Merrill , Ken Matsui , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Dec 16, 2023 at 8:40=E2=80=AFAM Jonathan Wakely wrote: > > On Sun, 10 Dec 2023 at 18:19, Jason Merrill wrote: > > > > On 12/7/23 00:11, Ken Matsui wrote: > > > This patch series optimizes type traits compilation performance by > > > implementing built-in type traits and using them in libstdc++. > > > > > > Changes in v26: > > > > > > * Rebased on top of trunk. > > > * Moved is_function_v under is_const_v. > > > * Isolated patches for is_const, is_volatile, is_pointer, and > > > is_unbounded_array, which contain performance regression, from > > > this patch series since they are not ready for review yet. > > > > I've applied all the compiler patches, with a few small tweaks, > > including this one as a separate commit. One other was a formatting > > fix, the lats was using TYPE_PTRDATAMEM_P for CPTK_IS_MEMBER_OBJECT_POI= NTER. > > > > I'm leaving the library patches for library folks to apply. > > I've reviewed all the library patches in v26 and they are all OK for > trunk. Please push (or Patrick can do so). > > Thanks, Ken! Great work, I'm really happy to see this land in GCC trunk. > > +Reviewed-by: Jonathan Wakely > Thank you so much for taking the time to review my patches and for your kind support! I will push :)