public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ken Matsui <kmatsui@cs.washington.edu>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, ppalka@redhat.com
Subject: Re: [PATCH 2/2] libstdc++: use new built-in trait __is_unsigned
Date: Tue, 21 Mar 2023 10:02:34 -0700	[thread overview]
Message-ID: <CAML+3pXLkO7R62OiWWBxjncLQep3ZUDkX=-a=n2BfPhf0buE_Q@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4kH22UaBgNiDgtepfgoodQsAQNiC=4riCvC0Wx9eV2h6g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

I see. Thank you!


On Tue, Mar 21, 2023 at 9:44 AM Jonathan Wakely <jwakely@redhat.com> wrote:

>
>
> On Tue, 21 Mar 2023 at 16:41, Ken Matsui via Libstdc++ <
> libstdc++@gcc.gnu.org> wrote:
>
>> This patch lets libstdc++ use new built-in trait __is_unsigned.
>>
>> libstdc++-v3/ChangeLog:
>>
>>         * include/std/type_traits (is_unsigned): Use __is_unsigned
>> built-in trait.
>>
>
> Please wrap the ChangeLog entry to less than 80 columns (including 8 for
> the leading tab).
>
>
>
>> ---
>>  libstdc++-v3/include/std/type_traits | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/libstdc++-v3/include/std/type_traits
>> b/libstdc++-v3/include/std/type_traits
>> index 2bd607a8b8f..8d5a05cd0a6 100644
>> --- a/libstdc++-v3/include/std/type_traits
>> +++ b/libstdc++-v3/include/std/type_traits
>> @@ -884,10 +884,17 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>>      { };
>>
>>    /// is_unsigned
>> +#if __has_builtin(__is_unsigned)
>> +  template<typename _Tp>
>> +    struct is_unsigned
>> +    : public __bool_constant<__is_unsigned(_Tp)>
>> +    { };
>> +#else
>>    template<typename _Tp>
>>      struct is_unsigned
>>      : public __and_<is_arithmetic<_Tp>, __not_<is_signed<_Tp>>>::type
>>      { };
>> +#endif
>>
>
> Thanks, I expect this trait to make a much bigger difference than
> add_const, so I'm very happy to see this one!
>
>
>
>>
>>    /// @cond undocumented
>>    template<typename _Tp, typename _Up = _Tp&&>
>> --
>> 2.40.0
>>
>>

  reply	other threads:[~2023-03-21 17:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 16:39 [PATCH 1/2] c++: implement __is_unsigned built-in trait Ken Matsui
2023-03-21 16:39 ` [PATCH 2/2] libstdc++: use new built-in trait __is_unsigned Ken Matsui
2023-03-21 16:44   ` Jonathan Wakely
2023-03-21 17:02     ` Ken Matsui [this message]
2023-03-23  0:42     ` [PATCH v2 " Ken Matsui
2023-03-21 17:08   ` Ken Matsui
2023-03-21 16:42 ` [PATCH 1/2] c++: implement __is_unsigned built-in trait Jonathan Wakely
2023-03-23  0:41   ` [PATCH v2 " Ken Matsui
2023-07-08  5:54     ` [PATCH v3 " Ken Matsui
2023-07-08 11:13       ` [PATCH v4 " Ken Matsui
2023-07-08 11:13         ` [PATCH v4 2/2] libstdc++: use new built-in trait __is_unsigned Ken Matsui
2023-07-12 10:04           ` Jonathan Wakely
2023-07-08 11:25         ` [PATCH v4 1/2] c++: implement __is_unsigned built-in trait Ken Matsui
2023-09-04 15:00           ` [PING][PATCH " Ken Matsui
2023-03-21 17:06 ` [PATCH v2 " Ken Matsui
2023-03-22 21:23   ` Ken Matsui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAML+3pXLkO7R62OiWWBxjncLQep3ZUDkX=-a=n2BfPhf0buE_Q@mail.gmail.com' \
    --to=kmatsui@cs.washington.edu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ppalka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).