From: Ken Matsui <kmatsui@cs.washington.edu>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>,
Ken Matsui <kmatsui@gcc.gnu.org>
Subject: [PING][PATCH v2 2/2] libstdc++: Use new built-in trait __is_signed
Date: Fri, 1 Sep 2023 06:00:00 -0700 [thread overview]
Message-ID: <CAML+3pXcuSeiE0aOeODsd35hei3DhAn08w9NJtk8KQWxW39qdw@mail.gmail.com> (raw)
Ping for the use of __is_signed built-in.
Sincerely,
Ken Matsui
On Wed, Jul 12, 2023 at 6:45 PM Ken Matsui <kmatsui@gcc.gnu.org> wrote:
>
> This patch lets libstdc++ use new built-in trait __is_signed.
>
> libstdc++-v3/ChangeLog:
>
> * include/std/type_traits (is_signed): Use __is_signed built-in trait.
> (is_signed_v): Likewise.
>
> Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
> ---
> libstdc++-v3/include/std/type_traits | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits
> index 0e7a9c9c7f3..23ab5a4b1e5 100644
> --- a/libstdc++-v3/include/std/type_traits
> +++ b/libstdc++-v3/include/std/type_traits
> @@ -865,6 +865,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> : public __bool_constant<__is_abstract(_Tp)>
> { };
>
> + /// is_signed
> +#if __has_builtin(__is_signed)
> + template<typename _Tp>
> + struct is_signed
> + : public __bool_constant<__is_signed(_Tp)>
> + { };
> +#else
> /// @cond undocumented
> template<typename _Tp,
> bool = is_arithmetic<_Tp>::value>
> @@ -877,11 +884,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> { };
> /// @endcond
>
> - /// is_signed
> template<typename _Tp>
> struct is_signed
> : public __is_signed_helper<_Tp>::type
> { };
> +#endif
>
> /// is_unsigned
> template<typename _Tp>
> @@ -3240,8 +3247,14 @@ template <typename _Tp>
> template <typename _Tp>
> inline constexpr bool is_final_v = __is_final(_Tp);
>
> +#if __has_builtin(__is_signed)
> +template <typename _Tp>
> + inline constexpr bool is_signed_v = __is_signed(_Tp);
> +#else
> template <typename _Tp>
> inline constexpr bool is_signed_v = is_signed<_Tp>::value;
> +#endif
> +
> template <typename _Tp>
> inline constexpr bool is_unsigned_v = is_unsigned<_Tp>::value;
>
> --
> 2.41.0
>
next reply other threads:[~2023-09-01 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 13:00 Ken Matsui [this message]
2023-09-04 10:25 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAML+3pXcuSeiE0aOeODsd35hei3DhAn08w9NJtk8KQWxW39qdw@mail.gmail.com \
--to=kmatsui@cs.washington.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=kmatsui@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).