From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5DD13385E02E for ; Tue, 18 Jan 2022 19:44:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5DD13385E02E Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-244-Evp-8AqIOyOLFuPdfFsVoQ-1; Tue, 18 Jan 2022 14:44:46 -0500 X-MC-Unique: Evp-8AqIOyOLFuPdfFsVoQ-1 Received: by mail-ed1-f72.google.com with SMTP id a8-20020a056402168800b004022fcdeb25so7268348edv.21 for ; Tue, 18 Jan 2022 11:44:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehf9jqXWT0ht8uDq+ELcMVHeZigdFFDnzmtCSKUuQyo=; b=LLViZzIX8z0Jea6G+20flsQM30+Ao1tAMDKrT/k6CQHLXpJ5g2CQCy7rZKXn4+g7hB Q6UKacZOs567nlkziWK4y8ILaIQDSxAwGCj5Nu5VFMtHlUbIEukUusjfsfT3ENkTz+EM JU2Q+AmZAylbkSAhzlmYPQG1FOKTanlwXHGMgtOw1lX6RBj6Ju4C8wXQdnPO5CCeeODN WgMDvOAg6l2JCxmJBtmufNKT6N2w9zzIsDl7XyFIFDbQRGfyp4YznUo1SLgLeujvZoIq u7ZEMkOQIQ8Jd2XfF0ZM4gg0H4mtQ8Lpa7UqruTUUW0866OkKSboRMpQAUAdeL4lzQVw ew4Q== X-Gm-Message-State: AOAM533AZIiOiHaxaw/INPvCKuNcmWwLykFkD4EzEeGbq4Vt4eFDLNSQ OgVainVkbZ7ifowgotlzs+JtPUc5V3p1UQw2HwssCZbFtknA/eyzwm2oFbDkKlZ/8hflTSDuoyI qJr1pgotos4JoluEBzymJdDjWuF0mmNQ= X-Received: by 2002:a17:906:7d97:: with SMTP id v23mr2319427ejo.128.1642535085606; Tue, 18 Jan 2022 11:44:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJz60E5k+3beNTM27K0qkVT4L6maWeki63eAtw9CcmD9u8iIwpAF89erudhFcGVwwljLCv2Hv2s6R/YoGgG7KHM= X-Received: by 2002:a17:906:7d97:: with SMTP id v23mr2319416ejo.128.1642535085421; Tue, 18 Jan 2022 11:44:45 -0800 (PST) MIME-Version: 1.0 References: <20220118101220.3578219-1-jwakely@redhat.com> <20220118101220.3578219-2-jwakely@redhat.com> In-Reply-To: <20220118101220.3578219-2-jwakely@redhat.com> From: Patrick Palka Date: Tue, 18 Jan 2022 14:44:34 -0500 Message-ID: Subject: Re: [committed 2/2] libstdc++: Use GCC's predefined macro for endianness [PR104080] To: Jonathan Wakely Cc: "Jonathan Wakely via Libstdc++" , GCC Patches , hp@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 19:44:49 -0000 On Tue, Jan 18, 2022 at 5:12 AM Jonathan Wakely wrote: > > Tested x86_64-linux, pushed to trunk. > > > Instead of hardcoded preprocessor conditionals with explicit target > checks, just rely on the fact that __BYTE_ORDER__ is always defined by > GCC. Thanks a lot for fixing these! I apparently missed removing this batch of #includes from the amalgamation in r12-6647. For completeness I suppose we should remove these #includes too. I wonder if we can rely on __BYTE_ORDER__ being defined by other compilers? > > libstdc++-v3/ChangeLog: > > PR libstdc++/104080 > * src/c++17/fast_float/LOCAL_PATCHES: Update. > * src/c++17/fast_float/fast_float.h (FASTFLOAT_IS_BIG_ENDIAN): > Define in terms of __BYTE_ORDER__. > --- > libstdc++-v3/src/c++17/fast_float/LOCAL_PATCHES | 1 + > libstdc++-v3/src/c++17/fast_float/fast_float.h | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libstdc++-v3/src/c++17/fast_float/LOCAL_PATCHES b/libstdc++-v3/src/c++17/fast_float/LOCAL_PATCHES > index 447c7ed2cdb..5bb42933398 100644 > --- a/libstdc++-v3/src/c++17/fast_float/LOCAL_PATCHES > +++ b/libstdc++-v3/src/c++17/fast_float/LOCAL_PATCHES > @@ -1,3 +1,4 @@ > r12-6647 > r12-6648 > r12-6664 > +r12-6665 > diff --git a/libstdc++-v3/src/c++17/fast_float/fast_float.h b/libstdc++-v3/src/c++17/fast_float/fast_float.h > index ee129309ba3..31fb88b8aba 100644 > --- a/libstdc++-v3/src/c++17/fast_float/fast_float.h > +++ b/libstdc++-v3/src/c++17/fast_float/fast_float.h > @@ -128,7 +128,9 @@ from_chars_result from_chars_advanced(const char *first, const char *last, > #define FASTFLOAT_VISUAL_STUDIO 1 > #endif > > -#ifdef _WIN32 > +#ifdef __BYTE_ORDER__ > +#define FASTFLOAT_IS_BIG_ENDIAN (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__) > +#elif defined _WIN32 > #define FASTFLOAT_IS_BIG_ENDIAN 0 > #else > #if defined(__APPLE__) || defined(__FreeBSD__) > -- > 2.31.1 >