From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 021823858D32 for ; Wed, 12 Apr 2023 16:59:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 021823858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681318797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7ZBHxqY1TEUdxy1zH9HRiJ4nHkEwAEfCHrmVk0biShs=; b=GhuItLdLt4lZ3XDI9ZP9Ltv9F4pA2iv6itV99W11d4e9XG9JE52rqMlsn2dOYeIYmupc08 rrfdBYlmVoEoqavsIwjyO9m+jXDZ1RzQl4oC9DJ5+35vu0HrSq4AqbT9RwG6ww9SOmq3sz Vz1LnEZrBDBTw4A5ucJrMhUCcCGcX1I= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-ObUteNyXN92v8Rj-X3OrfA-1; Wed, 12 Apr 2023 12:59:56 -0400 X-MC-Unique: ObUteNyXN92v8Rj-X3OrfA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-94a355c0f93so175007366b.2 for ; Wed, 12 Apr 2023 09:59:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681318795; x=1683910795; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ZBHxqY1TEUdxy1zH9HRiJ4nHkEwAEfCHrmVk0biShs=; b=EAa3QLt1xdjfBfrUn/bPozdPPf1wwuNbmyg7MCjjQRuXUid4yvWDC+h4cPK0e5t9n8 ieMBB0pqHs15/qA0OTiha7Aelt32daZT8M22I9/wm5mMexoBh7NxFW36FgHMf83OlDWV AkYuU3MvNyFAXEWJdMPvPhzc82qPNClfPOymlbw5026VgxBeR05hJyi1ImZSsiS6qh12 lShkSnvkmPBaJxoL2oatK1VWqEF/ZokOTS1iszU5b/euyeveLtyOj0VhjtDqMC/GXlSQ iSBf+lKRvO9kzgT92oKswB387xqoz1Nv8OtpdczSE+GHFzpVzkljCzhzK5DzRvdqyWOV VX2A== X-Gm-Message-State: AAQBX9fcE3pYGnLv1GMz3iYJZxerQA1bgQ5Uy6IK9AkwF9cy5tpEZAys mg4KHX4ZP3SXJZIFZuBvYddVO6C+Hs+DnzQoHi6d0QI2BkQ/GWFxu0O9MK6YHsvNKxjFTRicILl 7gEOUopNSY55xd948kYoP9FEbPNmc6xl7HJSmhN2Dog== X-Received: by 2002:a50:8ad7:0:b0:505:4fb:4430 with SMTP id k23-20020a508ad7000000b0050504fb4430mr1329543edk.6.1681318795117; Wed, 12 Apr 2023 09:59:55 -0700 (PDT) X-Google-Smtp-Source: AKy350YvFgPZc62AHqwOwpdhfCezW3f/gEuTXwiHHeeN9QHLGjZUMFaWAg3LJUJJIKLLsC7tjiKk2/pXpk22SYSZRYY= X-Received: by 2002:a50:8ad7:0:b0:505:4fb:4430 with SMTP id k23-20020a508ad7000000b0050504fb4430mr1329536edk.6.1681318794764; Wed, 12 Apr 2023 09:59:54 -0700 (PDT) MIME-Version: 1.0 References: <20230412134502.3147419-1-ppalka@redhat.com> In-Reply-To: From: Patrick Palka Date: Wed, 12 Apr 2023 12:59:43 -0400 Message-ID: Subject: Re: [PATCH] libstdc++: Ensure headers used by fast_float are included To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 12, 2023 at 11:04=E2=80=AFAM Jonathan Wakely wrote: > > On Wed, 12 Apr 2023 at 14:45, Patrick Palka via Libstdc++ > wrote: > > > > This makes floating_from_chars.cc explicitly include all headers > > that are used by the original fast_float amalgamation according to > > r12-6647-gf5c8b82512f9d3, except: > > > > 1. since fast_float doesn't seem to use anything from it > > 2. since fast_float doesn't seem to use anything directly > > from it (as opposed to from ) > > 3. since std::errc is naturally already available > > from > > > > This avoids potential build failures on platforms for which some > > required headers (namely ) end up not getting transitively > > included from elsewhere. > > > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/12? > > Yes for both, thanks. Thanks, pushed as r13-7159-g13669111e7219e and r12-9396-g43ab94d20e1f68 > > > > > > libstdc++-v3/ChangeLog: > > > > * src/c++17/floating_from_chars.cc: Include , > > , and . > > --- > > libstdc++-v3/src/c++17/floating_from_chars.cc | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/libstdc++-v3/src/c++17/floating_from_chars.cc b/libstdc++-= v3/src/c++17/floating_from_chars.cc > > index 5d18ca32dbb..3a411cf546a 100644 > > --- a/libstdc++-v3/src/c++17/floating_from_chars.cc > > +++ b/libstdc++-v3/src/c++17/floating_from_chars.cc > > @@ -30,14 +30,18 @@ > > // Prefer to use std::pmr::string if possible, which requires the cxx1= 1 ABI. > > #define _GLIBCXX_USE_CXX11_ABI 1 > > > > +#include > > #include > > #include > > #include > > +#include > > +#include > > #include > > #include > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > -- > > 2.40.0.315.g0607f793cb > > >