From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by sourceware.org (Postfix) with ESMTPS id D89FC3858287 for ; Thu, 8 Sep 2022 07:37:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D89FC3858287 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cd-adapco.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cd-adapco.com Received: by mail-yb1-xb2e.google.com with SMTP id 11so25193886ybu.0 for ; Thu, 08 Sep 2022 00:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cd-adapco.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=IGdNA996vbkt5QUJ3Q3Ar9xmaZAXgfWv3opkN4WhXpU=; b=Mgo4ksz+tkrK+/K8WAPUx5TtvBxaH3xB3flKZuMlRfxzuXEgUYIvYzKTnrvLosanVk nKKbLwA+v/wz0hztetGtGvXhoM5jd/4lIRYS7JHzaneLv/iYJt4yeUtKOCYON7Iv983c Zw5YqBTWnse87SFd9ZMNy+fpfB2FQOelW05KM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=IGdNA996vbkt5QUJ3Q3Ar9xmaZAXgfWv3opkN4WhXpU=; b=eny84e50lYuSxcVrSy+1rSnSFqSWA+5ZrTS8L2DkC/RR9jwxu5i072mDmUa0cdZIca FilZt0YTZfmabh8dIwyudqQZbaPqzm9dSl28VBLVURy6zGl3TvpHwQX7ZL7cNA6xydTU BTVmYvYbK5FQ3ChxaAFWu2IuhAJUNVtq44yxEOBrNFdVn3ksNIiWOfUKUMGmq+1RUNxV 9VNpy90GyecAcQa3SollO3xvZbnOpREVgai5nCz68lSECg4bWWpKR0nuT0/y48GAXR+X y1GOo6sOj5+/P2czCc8LLxJYa7+O8jsC5AM8SsJqd6Tob6QcCv9FTI7UJIZrVM+/Ar03 z2oQ== X-Gm-Message-State: ACgBeo2M7cqH0t41rIt1aghNRJCEW8p5V43uUkHnoQb2mSQvcr/H81Ob +fAo8tyQeI/E/QbTPtyTNUrX9S1Bpxg1fa3tfpWcGA== X-Google-Smtp-Source: AA6agR5+E13yjplMUh74cn5q7++Qf/N9Pi2yTO7J9NOKqfV4U9wgpkyIi8+QRCeAA29AQhhdRaeUZ6TZd4RVDfhd7GQ= X-Received: by 2002:a25:8247:0:b0:6a9:443a:cc0b with SMTP id d7-20020a258247000000b006a9443acc0bmr6165096ybn.89.1662622675190; Thu, 08 Sep 2022 00:37:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tom James Date: Thu, 8 Sep 2022 08:37:44 +0100 Message-ID: Subject: Re: GPL carve-out missing for barrier To: Jonathan Wakely Cc: "libstdc++" , Moritz Kreutzer , "Jones, Philip" Content-Type: multipart/alternative; boundary="000000000000f35c0005e82581a9" X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000f35c0005e82581a9 Content-Type: text/plain; charset="UTF-8" Fantastic, thanks for your help! On Wed, 7 Sept 2022 at 20:27, Jonathan Wakely wrote: > On Wed, 7 Sept 2022 at 12:22, Jonathan Wakely > wrote: > > > > On Wed, 7 Sept 2022 at 10:49, Tom James wrote: > > > > > > Hi Jonathan, > > > > > > Thanks for that, that's all useful information. > > > > > > I've had a more detailed chat with our legal people and I think > getting this fixed in master solves the problem for us. > > I've pushed the change to master now. Backports will follow at some > point before the next releases from the branches. > > Thanks for noticing the problem and bringing it to our attention! > > > > > > > > > I had wondered whether it would be possible to bump the 11.2 tag > > > > No, definitely not. > > > > > to include this change because it's not code, but actually that > shouldn't be necessary. It looks like we don't use barrier at the moment, > and we're unlikely to do so any time soon. > > > > > > Thanks, > > > Tom > > > > > > On Tue, 6 Sept 2022 at 11:56, Jonathan Wakely > wrote: > > >> > > >> On Tue, 6 Sept 2022 at 11:29, Tom James > wrote: > > >> > > > >> > Hi, > > >> > > > >> > I'm working on a closed-source c++ project that compiles with gcc > 11.2. We > > >> > need to ship the GNU 11.2 run-time alongside our product, and it > looks like > > >> > the std::barrier header is missing the GPL3 carve-out for shipping > > >> > run-times. > > >> > > >> Ouch, I'm pretty sure that's unintentional. I'll go back through my > > >> email to confirm that. > > >> > > >> > > >> > For the purposes of comparison, let's look at algorithm: > > >> > > https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/std/algorithm > > >> > > > >> > Lines 16-18 read as follows: > > >> > // Under Section 7 of GPL version 3, you are granted additional > > >> > // permissions described in the GCC Runtime Library Exception, > version > > >> > // 3.1, as published by the Free Software Foundation. > > >> > > > >> > These lines are necessary to prevent the GPL infecting our > closed-source > > >> > code. > > >> > > >> What exactly are you shipping? There is no code from in > > >> libstdc++.so so unless your own code is including the header > > >> and odr-using the inline functions and templates in that header, I > > >> think your compiled code will not be affected by the license of > > >> . If you are including that header in the works you > > >> propagate, or shipping it to customers for compiling their own works > > >> which they will propagate, then the license exception matters. > > >> > > >> > The barrier header appears to be missing these lines: > > >> > > https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/std/barrier > > >> > > > >> > > > >> > Would it be possible to please make the following changes? > > >> > 1. Add these lines to the master branch, > > >> > 2. Backport these lines to gnu 11.2 (which is the most recent > version > > >> > supported by our toolchain). > > >> > > >> No, we can't backport anything to 11.2 because that's already been > released. > > >> > > >> I'll add it to the master, gcc-12, and gcc-11 branches, which will > > >> mean it's present for 11.4, 12.3 and 13.1 (and all releases that > > >> follow them). > > >> > > >> If you are producing a combined work that includes the code, > > >> then unless/until you're able to wait for 11.4 and use that, you could > > >> copy the fixed header into your own GCC 11.2 that you distribute. > > > > > > > > > > > > -- > > > Tom James > > > > > > Siemens Digital Industries Software > > > Simulation and Test Solutions, Solution Domains Development, Server, > Platform, Simulation Framework, High Performance Computing > > > thomasjames@siemens.com > > > sw.siemens.com > -- Tom James Siemens Digital Industries Software Simulation and Test Solutions, Solution Domains Development, Server, Platform, Simulation Framework, High Performance Computing thomasjames@siemens.com sw.siemens.com --000000000000f35c0005e82581a9--