From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by sourceware.org (Postfix) with ESMTPS id 47C243858C74; Wed, 23 Aug 2023 08:08:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47C243858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-d7766072ba4so3085021276.1; Wed, 23 Aug 2023 01:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692778111; x=1693382911; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iulzSIQAHvcz+gwgA4x06h3EkJZ9kMoTkCE+yYsYzuA=; b=mQVFzDPhl5QKrJvbcQmKVao/xh/0fj6kYTV3hqHwbF0EFK0UhBazFIYKt3kKAoxhpG 7paxogMd+wtNJXT8GJuR2BPTC0JKU4Nz0gNWmi8k8VWWjySXR9J+WjaS4vwXqJODYN0G V7D4kTOvDqYglNrdA3tHBKAljoBQyjSs3QPhMnyjmUsrqNyO3vTqTAiu3LQF5TLHzYmr /u7vWndFIrzioy9vs7HyjUhnTMiKGYPFQRfyRY+Xvb9ia+m053fT8MsnwgXyH/Wl2DHB 7fTVnBHjUrV68WyAjjcNLHMI53mWM7lGF4CqUlXY6I5KQnOW4lalQ1qcTxMy07Efcr/d KtPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692778111; x=1693382911; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iulzSIQAHvcz+gwgA4x06h3EkJZ9kMoTkCE+yYsYzuA=; b=N8WYm6vn+XiDEjA4o/wKDScd/KYN/8l6MR1zJlRSBZy9Exz4puhdexrQwYeL4LZvFp OhY07PDMG7XKNSLRntCnoLXE/+BCwkU4kaiEltK5zwRE8IPUMN6jZMzAHxGKGYJRPJAE 16650IMgRhgOwFqfX5sEsUvjsUYXPWkH2JR8c14Z/nDyMPHfq12gC5lUCyZTA4eN86An zg/CTlIQ8a98lLItziSSoulL0EXugrp+5/K3bo9yYSQ2c9HjEVZDpmUZhSeM5MSKFU4e cp4iLViho0Xig0EomfosfUlaLX4XH6tOWo1a2Hktd1UR5YPCEPI7du2RDnMa97yoFjXw ADJA== X-Gm-Message-State: AOJu0YyxdRhH8KQ0qXtaYPWx69a8PJhd6yGXdVfH940k4xQzOlEaY594 4fC74ijSSVelJtllXWirREu5xrN36Ko4NHlrWDw= X-Google-Smtp-Source: AGHT+IEygBkK3zXHN1W1B+sDZ+6QIV3n/9RtSzAOtncdasL/t88rRx3TDrpGFe9im+EzLcgDbj+SPG6RWjjqUdrp1lo= X-Received: by 2002:a25:7351:0:b0:d71:6835:c250 with SMTP id o78-20020a257351000000b00d716835c250mr10156370ybc.30.1692778111229; Wed, 23 Aug 2023 01:08:31 -0700 (PDT) MIME-Version: 1.0 References: <20230807211335.701619-1-jwakely@redhat.com> In-Reply-To: From: Hongtao Liu Date: Wed, 23 Aug 2023 16:08:19 +0800 Message-ID: Subject: Re: [committed] i386: Fix grammar typo in diagnostic To: Jonathan Wakely Cc: Marek Polacek , Jonathan Wakely , "libstdc++" , gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Aug 23, 2023 at 3:02=E2=80=AFPM Jonathan Wakely wrote: > > > > On Wed, 23 Aug 2023, 06:15 Hongtao Liu via Libstdc++, wrote: >> >> On Wed, Aug 23, 2023 at 7:28=E2=80=AFAM Hongtao Liu = wrote: >> > >> > On Tue, Aug 8, 2023 at 5:22=E2=80=AFAM Marek Polacek via Libstdc++ >> > wrote: >> > > >> > > On Mon, Aug 07, 2023 at 10:12:35PM +0100, Jonathan Wakely via Gcc-pa= tches wrote: >> > > > Committed as obvious. >> > > > >> > > > Less obvious (to me) is whether it's correct to say "GCC V13" here= . I >> > > > don't think we refer to a version that way anywhere else, do we? >> > > > >> > > > Would "since GCC 13.1.0" be better? >> > > >> > > x86_field_alignment uses >> > > >> > > inform (input_location, "the alignment of %<_Atomic %T= %> " >> > > "fields changed in %{GCC 11.1%= }", >> > > >> > > so maybe the below should use %{GCC 13.1%}. "GCC V13" looks unusual >> > > to me. >> > %{GCC 13.1%} sounds reasonable. >> looks like %{ can't be using in const char*, so use % instead= . >> >> How about: >> >> Author: liuhongt >> Date: Wed Aug 23 07:31:13 2023 +0800 >> >> Adjust GCC V13 to GCC 13.1 in diagnotic. >> >> gcc/ChangeLog: >> >> * config/i386/i386.cc (ix86_invalid_conversion): Adjust GCC >> V13 to GCC 13.1. >> >> diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc >> index e7822ef6500..88d9d7d537f 100644 >> --- a/gcc/config/i386/i386.cc >> +++ b/gcc/config/i386/i386.cc >> @@ -22899,7 +22899,7 @@ ix86_invalid_conversion (const_tree fromtype, >> const_tree totype) >> || (TYPE_MODE (totype) =3D=3D BFmode >> && TYPE_MODE (fromtype) =3D=3D HImode)) >> warning (0, "%<__bfloat16%> is redefined from typedef % = " >> - "to real %<__bf16%> since GCC V13, be careful of " >> + "to real %<__bf16%> since %, be careful of " >> "implicit conversion between %<__bf16%> and %; = " >> "an explicit bitcast may be needed here"); >> } > > > > Why does it need to be quoted? What's wrong with just saying GCC 13.1 wit= hout the %< decoration? I'll just remove that. > > > >> >> > > >> > > > -- >8 -- >> > > > >> > > > gcc/ChangeLog: >> > > > >> > > > * config/i386/i386.cc (ix86_invalid_conversion): Fix grammar= . >> > > > --- >> > > > gcc/config/i386/i386.cc | 2 +- >> > > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > > >> > > > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc >> > > > index 50860050049..5d57726e22c 100644 >> > > > --- a/gcc/config/i386/i386.cc >> > > > +++ b/gcc/config/i386/i386.cc >> > > > @@ -22890,7 +22890,7 @@ ix86_invalid_conversion (const_tree fromty= pe, const_tree totype) >> > > > warning (0, "%<__bfloat16%> is redefined from typedef % " >> > > > "to real %<__bf16%> since GCC V13, be careful of " >> > > > "implicit conversion between %<__bf16%> and %; " >> > > > - "a explicit bitcast may be needed here"); >> > > > + "an explicit bitcast may be needed here"); >> > > > } >> > > > >> > > > /* Conversion allowed. */ >> > > > -- >> > > > 2.41.0 >> > > > >> > > >> > > Marek >> > > >> > >> > >> > -- >> > BR, >> > Hongtao >> >> >> >> -- >> BR, >> Hongtao --=20 BR, Hongtao