From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by sourceware.org (Postfix) with ESMTPS id 3214F3858C01; Thu, 24 Aug 2023 03:38:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3214F3858C01 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-5920efd91c7so42776477b3.2; Wed, 23 Aug 2023 20:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692848326; x=1693453126; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N3qcv2yExPtR6rJtyldFmAy0N91WijjBh2fJgky3NBM=; b=IUnRU2W9hnOhluIWLbPQgoYL/kYb2Ifyb1lnp/+pwwhPAXosbaqgN2H4JqLOiXDObk KHU2dUe9CH7A4iuS75O9HZqSo2IhaoYiCW7eqyfyiE5/Pm4zIOTTe1qR/Bgo+JR+tu5U bc1y/PdTrzm9auLP6CTyzZYj4b5ar4GG8jW6FPMckgqBzXclwdWycwoFEnjiTTrf6yI2 djO68zcPs9NbM8t07sU1Wcpx8GBRcZKm77psbhCdjyuZto4KKd9sowEALIj84brW3Emu va4B81l5Zk42eW81Ap4/+JwUh3MBk1hroS5yxR51eH4ERT+Ds9t7/uLD2a7FxYlSPS32 cp6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692848326; x=1693453126; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N3qcv2yExPtR6rJtyldFmAy0N91WijjBh2fJgky3NBM=; b=klsHPF9i3q1P9HVJ41+Kd+BBjXQVcN4aNuz3Za2R7Nd2mnWuaFvHJCbvtbRFL1Ec/m KwfiQpIgWvR+vId6AlsuiQHdudZWGkHUmhXJi1vwzGvc0/9+XWyQmQ5hjQv4Rbmg5PHX YjlfwCXayj8tzVnXxs/dBEOnQN1kHwWyhuB+Q8W+3J9b62fDWtivyRcFjnpvURvfbdSY SmKMV6HccxWC/RbWaWrI+u/xNFVAU8lM2i4QB4dTBrJNf/3+DsaK77SeupOAoBz7EuOn rfp/IYipRh1ieDpg8MiUhYii2G0j9hfitmnXf7Z4WPxR5K4yIUK8tBiBplT+DP6QpgX9 jUpQ== X-Gm-Message-State: AOJu0YyNgkLBOIAp2CukMR8XcFnoNkNHp3Vw8DQ6MU/4lyZM/53CZROf 3KQEvPO0a+kGT8aby/FZ/2OhsQU+NnZfk09TLSI= X-Google-Smtp-Source: AGHT+IGp8s4mQe5P82PFAOF1OE9UKiffQKSmer6ynJR+GKk12r+gVmYIfVrQdN4CaUwcbuOVY9vMkdJHFDwXlJ/h6TM= X-Received: by 2002:a0d:fe47:0:b0:57a:75b8:b790 with SMTP id o68-20020a0dfe47000000b0057a75b8b790mr12948271ywf.29.1692848326453; Wed, 23 Aug 2023 20:38:46 -0700 (PDT) MIME-Version: 1.0 References: <20230807211335.701619-1-jwakely@redhat.com> In-Reply-To: From: Hongtao Liu Date: Thu, 24 Aug 2023 11:38:34 +0800 Message-ID: Subject: Re: [committed] i386: Fix grammar typo in diagnostic To: Jonathan Wakely Cc: Marek Polacek , Jonathan Wakely , "libstdc++" , gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Aug 23, 2023 at 4:08=E2=80=AFPM Hongtao Liu wr= ote: > > On Wed, Aug 23, 2023 at 3:02=E2=80=AFPM Jonathan Wakely wrote: > > > > > > > > On Wed, 23 Aug 2023, 06:15 Hongtao Liu via Libstdc++, wrote: > >> > >> On Wed, Aug 23, 2023 at 7:28=E2=80=AFAM Hongtao Liu wrote: > >> > > >> > On Tue, Aug 8, 2023 at 5:22=E2=80=AFAM Marek Polacek via Libstdc++ > >> > wrote: > >> > > > >> > > On Mon, Aug 07, 2023 at 10:12:35PM +0100, Jonathan Wakely via Gcc-= patches wrote: > >> > > > Committed as obvious. > >> > > > > >> > > > Less obvious (to me) is whether it's correct to say "GCC V13" he= re. I > >> > > > don't think we refer to a version that way anywhere else, do we? > >> > > > > >> > > > Would "since GCC 13.1.0" be better? > >> > > > >> > > x86_field_alignment uses > >> > > > >> > > inform (input_location, "the alignment of %<_Atomic = %T%> " > >> > > "fields changed in %{GCC 11.= 1%}", > >> > > > >> > > so maybe the below should use %{GCC 13.1%}. "GCC V13" looks unusu= al > >> > > to me. > >> > %{GCC 13.1%} sounds reasonable. > >> looks like %{ can't be using in const char*, so use % inste= ad. > >> > >> How about: > >> > >> Author: liuhongt > >> Date: Wed Aug 23 07:31:13 2023 +0800 > >> > >> Adjust GCC V13 to GCC 13.1 in diagnotic. > >> > >> gcc/ChangeLog: > >> > >> * config/i386/i386.cc (ix86_invalid_conversion): Adjust GC= C > >> V13 to GCC 13.1. > >> > >> diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > >> index e7822ef6500..88d9d7d537f 100644 > >> --- a/gcc/config/i386/i386.cc > >> +++ b/gcc/config/i386/i386.cc > >> @@ -22899,7 +22899,7 @@ ix86_invalid_conversion (const_tree fromtype, > >> const_tree totype) > >> || (TYPE_MODE (totype) =3D=3D BFmode > >> && TYPE_MODE (fromtype) =3D=3D HImode)) > >> warning (0, "%<__bfloat16%> is redefined from typedef % " > >> - "to real %<__bf16%> since GCC V13, be careful of " > >> + "to real %<__bf16%> since %, be careful of = " > >> "implicit conversion between %<__bf16%> and %= ; " > >> "an explicit bitcast may be needed here"); > >> } > > > > > > > > Why does it need to be quoted? What's wrong with just saying GCC 13.1 w= ithout the %< decoration? > I'll just remove that. pushed to trunk and backport to GCC13 release branch. > > > > > > > >> > >> > > > >> > > > -- >8 -- > >> > > > > >> > > > gcc/ChangeLog: > >> > > > > >> > > > * config/i386/i386.cc (ix86_invalid_conversion): Fix gramm= ar. > >> > > > --- > >> > > > gcc/config/i386/i386.cc | 2 +- > >> > > > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > > > >> > > > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > >> > > > index 50860050049..5d57726e22c 100644 > >> > > > --- a/gcc/config/i386/i386.cc > >> > > > +++ b/gcc/config/i386/i386.cc > >> > > > @@ -22890,7 +22890,7 @@ ix86_invalid_conversion (const_tree from= type, const_tree totype) > >> > > > warning (0, "%<__bfloat16%> is redefined from typedef % " > >> > > > "to real %<__bf16%> since GCC V13, be careful of " > >> > > > "implicit conversion between %<__bf16%> and %; " > >> > > > - "a explicit bitcast may be needed here"); > >> > > > + "an explicit bitcast may be needed here"); > >> > > > } > >> > > > > >> > > > /* Conversion allowed. */ > >> > > > -- > >> > > > 2.41.0 > >> > > > > >> > > > >> > > Marek > >> > > > >> > > >> > > >> > -- > >> > BR, > >> > Hongtao > >> > >> > >> > >> -- > >> BR, > >> Hongtao > > > > -- > BR, > Hongtao --=20 BR, Hongtao